From: David Miller <davem@davemloft.net>
To: lukas@wunner.de
Cc: kuba@kernel.org, vincent.ldev@duvert.net, chris@disavowed.jp,
doug@downtowndougbrown.com, yuehaibing@huawei.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] appletalk: Fix atalk_proc_init() return path
Date: Mon, 03 Aug 2020 15:49:31 -0700 (PDT) [thread overview]
Message-ID: <20200803.154931.851692800404466253.davem@davemloft.net> (raw)
In-Reply-To: <086b426f44bc24360cc89476fe18d2758a2652af.1596344622.git.lukas@wunner.de>
From: Lukas Wunner <lukas@wunner.de>
Date: Sun, 2 Aug 2020 07:06:51 +0200
> From: Vincent Duvert <vincent.ldev@duvert.net>
>
> Add a missing return statement to atalk_proc_init so it doesn't return
> -ENOMEM when successful. This allows the appletalk module to load
> properly.
>
> Fixes: e2bcd8b0ce6e ("appletalk: use remove_proc_subtree to simplify procfs code")
> Link: https://www.downtowndougbrown.com/2020/08/hacking-up-a-fix-for-the-broken-appletalk-kernel-module-in-linux-5-1-and-newer/
> Reported-by: Christopher KOBAYASHI <chris@disavowed.jp>
> Reported-by: Doug Brown <doug@downtowndougbrown.com>
> Signed-off-by: Vincent Duvert <vincent.ldev@duvert.net>
> [lukas: add missing tags]
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Shows how many people are actually using appletalk if it doesn't even
load since v5.1
Applied.
prev parent reply other threads:[~2020-08-03 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 5:06 [PATCH] appletalk: Fix atalk_proc_init() return path Lukas Wunner
2020-08-03 22:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803.154931.851692800404466253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris@disavowed.jp \
--cc=doug@downtowndougbrown.com \
--cc=kuba@kernel.org \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=vincent.ldev@duvert.net \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.