* [PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call
@ 2020-08-02 13:53 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2020-08-02 13:53 UTC (permalink / raw)
To: kou.ishizaki, davem, kuba, linas
Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()', in
'spider_net_init_chain()'.
Fixes: d4ed8f8d1fb7 ("Spidernet DMA coalescing")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
NOT compile tested, because I don't have the configuration for that
---
drivers/net/ethernet/toshiba/spider_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c
index 3902b3aeb0c2..2d61400144a2 100644
--- a/drivers/net/ethernet/toshiba/spider_net.c
+++ b/drivers/net/ethernet/toshiba/spider_net.c
@@ -283,8 +283,8 @@ spider_net_free_chain(struct spider_net_card *card,
descr = descr->next;
} while (descr != chain->ring);
- dma_free_coherent(&card->pdev->dev, chain->num_desc,
- chain->hwring, chain->dma_addr);
+ dma_free_coherent(&card->pdev->dev, chain->num_desc * sizeof(struct spider_net_hw_descr),
+ chain->hwring, chain->dma_addr);
}
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call
@ 2020-08-02 13:53 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2020-08-02 13:53 UTC (permalink / raw)
To: kou.ishizaki, davem, kuba, linas
Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET
Update the size used in 'dma_free_coherent()' in order to match the one
used in the corresponding 'dma_alloc_coherent()', in
'spider_net_init_chain()'.
Fixes: d4ed8f8d1fb7 ("Spidernet DMA coalescing")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
NOT compile tested, because I don't have the configuration for that
---
drivers/net/ethernet/toshiba/spider_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c
index 3902b3aeb0c2..2d61400144a2 100644
--- a/drivers/net/ethernet/toshiba/spider_net.c
+++ b/drivers/net/ethernet/toshiba/spider_net.c
@@ -283,8 +283,8 @@ spider_net_free_chain(struct spider_net_card *card,
descr = descr->next;
} while (descr != chain->ring);
- dma_free_coherent(&card->pdev->dev, chain->num_desc,
- chain->hwring, chain->dma_addr);
+ dma_free_coherent(&card->pdev->dev, chain->num_desc * sizeof(struct spider_net_hw_descr),
+ chain->hwring, chain->dma_addr);
}
/**
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call
2020-08-02 13:53 ` Christophe JAILLET
@ 2020-08-03 23:01 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-08-03 23:01 UTC (permalink / raw)
To: christophe.jaillet
Cc: kou.ishizaki, kuba, linas, netdev, linux-kernel, kernel-janitors
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sun, 2 Aug 2020 15:53:33 +0200
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()', in
> 'spider_net_init_chain()'.
>
> Fixes: d4ed8f8d1fb7 ("Spidernet DMA coalescing")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call
@ 2020-08-03 23:01 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-08-03 23:01 UTC (permalink / raw)
To: christophe.jaillet
Cc: kou.ishizaki, kuba, linas, netdev, linux-kernel, kernel-janitors
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sun, 2 Aug 2020 15:53:33 +0200
> Update the size used in 'dma_free_coherent()' in order to match the one
> used in the corresponding 'dma_alloc_coherent()', in
> 'spider_net_init_chain()'.
>
> Fixes: d4ed8f8d1fb7 ("Spidernet DMA coalescing")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-03 23:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-02 13:53 [PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call Christophe JAILLET
2020-08-02 13:53 ` Christophe JAILLET
2020-08-03 23:01 ` David Miller
2020-08-03 23:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.