From: Jakub Kicinski <kuba@kernel.org>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Ganji Aravind <ganji.aravind@chelsio.com>,
netdev@vger.kernel.org, davem@davemloft.net, vishal@chelsio.com
Subject: Re: [PATCH net-next] cxgb4: Add support to flash firmware config image
Date: Mon, 3 Aug 2020 14:13:04 -0700 [thread overview]
Message-ID: <20200803141304.79a7d05f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200802171221.GA29010@chelsio.com>
On Sun, 2 Aug 2020 22:42:28 +0530 Rahul Lakkireddy wrote:
> The config file contains very low-level firmware and device specific
> params and most of them are dependent on the type of Chelsio NIC.
> The params are mostly device dependent register-value pairs.
> We don't see users messing around with the params on their own
> without consultation. The users only need some mechanism to flash
> the custom config file shared by us on to their adapter. After
> device restart, the firmware will automatically pick up the flashed
> config file and redistribute the resources, as per their requested
> use-case.
>
> We're already foreseeing very long awkward list (more than 50 params)
> for mapping the config file to devlink-dev params and are hoping this
> is fine. Here's a sample on how it would look.
>
> hw_sge_reg_1008=0x40800
> hw_sge_reg_100c=0x22222222
> hw_sge_reg_10a0=0x01040810
> hw_tp_reg_7d04=0x00010000
> hw_tp_reg_7dc0=0x0e2f8849
>
> and so on.
I have no details on what you're actually storing in the config,
and I don't care what your format is.
If it's a configuration parameter - it needs a proper API.
If it's a low level board param or such - it doesn't need a separate
flashable partition and can come with the rest of FW.
I know the firmware flashing interface is a lovely, binary, opaque
interface which vendors love. We'll not entertain this kind of abuse.
Nacked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2020-08-03 21:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 15:11 [PATCH net-next] cxgb4: Add support to flash firmware config image Ganji Aravind
2020-07-30 23:23 ` Jakub Kicinski
2020-07-31 11:09 ` Ganji Aravind
2020-07-31 18:00 ` Jakub Kicinski
2020-07-31 21:17 ` Rahul Lakkireddy
2020-08-02 4:22 ` Jakub Kicinski
2020-08-02 17:12 ` Rahul Lakkireddy
2020-08-03 21:13 ` Jakub Kicinski [this message]
2020-08-04 9:43 ` Rahul Lakkireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803141304.79a7d05f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ganji.aravind@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.