From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E41D6C433DF for ; Mon, 3 Aug 2020 16:36:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE28E206DA for ; Mon, 3 Aug 2020 16:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="FV7dbQIG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE28E206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2dRU-00070H-Um for qemu-devel@archiver.kernel.org; Mon, 03 Aug 2020 12:36:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2dQu-0006aP-Ig for qemu-devel@nongnu.org; Mon, 03 Aug 2020 12:35:28 -0400 Received: from esa3.hc3370-68.iphmx.com ([216.71.145.155]:14382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2dQs-0006Zc-LD for qemu-devel@nongnu.org; Mon, 03 Aug 2020 12:35:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596472527; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MNUVdjqhQRP1dXRs4Aum5uFSIWFSBncZmJg7V1idQrI=; b=FV7dbQIGL/tWpvr2paN8xJwY6+AYJHTH59l95+CXKa2Ee1Jw8qod1i5+ cV9dpfeSf/6aFONgSBo0FW2CCBGlpxjFHZdT3CFkQ+Ea1fol3LWMGpG/N snJBWV6XP36yUfmpnOF4Jn5G3Bl/NbrF27612cVPG/i99GzasrxyWTPFE w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: eqxk+0NeEGUCj9KM0nptCEKSlI8fcrI1rJOm9i9MdbTNrJp/02pz/cmIxq3i+fECreBovjI9qA nUceFlwzOFccjUgAF6MnJnCsRZCsB0oy0AIpvGLwjE3tB/h73VNLkzc2W3zjXXpTlFEe9T7et6 X1vpKQR+oOBEETDdXor5t6Nn/7MZZql07QpVvkdWYesPdnrVPQIWDM5Bq4EX2IoBSgpb9N53mQ X/h4V2OAJUKsYDQmm3RhHQdcTitw1SUryXRVpBOpqI7Xzr0i7KXrcSmFuMCnDgX04+9KiQ40HX RI4= X-SBRS: 3.7 X-MesageID: 23748486 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,430,1589256000"; d="scan'208";a="23748486" Date: Mon, 3 Aug 2020 17:35:15 +0100 From: Anthony PERARD To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH-for-5.1] accel/xen: Fix xen_enabled() behavior on target-agnostic objects Message-ID: <20200803163515.GD2866@perard.uk.xensource.com> References: <20200728100925.10454-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200728100925.10454-1-philmd@redhat.com> Received-SPF: pass client-ip=216.71.145.155; envelope-from=anthony.perard@citrix.com; helo=esa3.hc3370-68.iphmx.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/03 12:35:21 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stefano Stabellini , Paul Durrant , Paul Durrant , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 28, 2020 at 12:09:25PM +0200, Philippe Mathieu-Daudé wrote: > CONFIG_XEN is generated by configure and stored in "config-target.h", > which is (obviously) only include for target-specific objects. > This is a problem for target-agnostic objects as CONFIG_XEN is never > defined and xen_enabled() is always inlined as 'false'. > > Fix by following the KVM schema, defining CONFIG_XEN_IS_POSSIBLE > when we don't know to force the call of the non-inlined function, > returning the xen_allowed boolean. > > Fixes: da278d58a092 ("accel: Move Xen accelerator code under accel/xen/") > Reported-by: Paul Durrant > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD