From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 3 Aug 2020 13:11:26 -0400 Subject: [PATCH v4 11/14] test: environment in ext4 In-Reply-To: <0fb0f38f-243d-9b4d-9da1-099a29f8c0e5@wwwdotorg.org> References: <20200728095128.2363-1-patrick.delaunay@st.com> <20200728095128.2363-12-patrick.delaunay@st.com> <20200803155136.GT6965@bill-the-cat> <0fb0f38f-243d-9b4d-9da1-099a29f8c0e5@wwwdotorg.org> Message-ID: <20200803171126.GV6965@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Aug 03, 2020 at 10:57:21AM -0600, Stephen Warren wrote: > On 8/3/20 9:51 AM, Tom Rini wrote: > > On Mon, Aug 03, 2020 at 09:43:18AM -0600, Stephen Warren wrote: > >> On 7/28/20 3:51 AM, Patrick Delaunay wrote: > >>> Add basic test to persistent environment in ext4: > >>> save and load in host ext4 file 'uboot.env'. > >>> > >>> On first execution an empty EXT4 file system is created in > >>> persistent data dir: env.ext4.img. > >> > >>> diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py > >> > >>> +def mk_env_ext4(state_test_env): > >> > >>> + u_boot_utils.run_and_log(c, 'mkfs.ext4 -O ^metadata_csum %s' % persistent) > >> > >> Is "-O ^metadata_csum" necessary? The mkfs.ext4 in Ubuntu 16.04 doesn't > >> support that option, which causes this command to fail. > > > > Yes, it's required because we don't support that feature in our ext4 > > codebase and newer tools default to enabling that. Supporting that flag > > is on my wishlist of items. > > Hmm. Is there a way to detect that, and only use the flag when necessary? I'm not sure. I mean, we could put the above in a try/except? -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: