From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE4FC433E0 for ; Tue, 4 Aug 2020 00:29:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D81C22CAE for ; Tue, 4 Aug 2020 00:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596500962; bh=+v27rXt/ydPKZ2V67yzg9rR+cbQUfDh5jgGvR+33jAw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=GpiqYfFbxWVCacyrv7WKrzqJ/8WcucncHHm9UJZunTBsqfTtehNakAq5tkvSGZh1z 3qkxVnOfCL1PlemfB5osivdpsw8YEX47ux5b6ePo/gLokMwiNROej+Qnsr8S6IaS+r TDVpyaFr4Bul8L7GrTqiWdtLa4yiUL9ofYmP3nG0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729288AbgHDA3V (ORCPT ); Mon, 3 Aug 2020 20:29:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:55602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728329AbgHDA3U (ORCPT ); Mon, 3 Aug 2020 20:29:20 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B0C722B42; Tue, 4 Aug 2020 00:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596500960; bh=+v27rXt/ydPKZ2V67yzg9rR+cbQUfDh5jgGvR+33jAw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yOJOw+c6tGACyHM7qzLdVZx+NcwDQyXacpTUma2aZRASUVoEmL3rilixeb8LEc2WZ FepjErunaAffawnhtB7TINkGiLJQNNim0mZk7H5bxkFmDbqpNiz8pIUX8WIqHcvsg/ mKoIY3YKw3zKdnH6auH5h/ctOIMsicvPWkso3saA= Date: Tue, 4 Aug 2020 09:29:13 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Arvind Sankar , Masami Hiramatsu , Kees Cook , Ingo Molnar , Frank Rowand , Randy Dunlap , Namhyung Kim , Tim Bird , Jiri Olsa , Arnaldo Carvalho de Melo , Tom Zanussi , Rob Herring , Andrew Morton , Thomas Gleixner , Greg Kroah-Hartman , Alexey Dobriyan , Jonathan Corbet , Linus Torvalds , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 08/22] bootconfig: init: Allow admin to use bootconfig for init command line Message-Id: <20200804092913.0d5556f604d141955c53324a@kernel.org> In-Reply-To: <20200803132238.1e40aa37@oasis.local.home> References: <157867220019.17873.13377985653744804396.stgit@devnote2> <157867229521.17873.654222294326542349.stgit@devnote2> <202002070954.C18E7F58B@keescook> <20200207144603.30688b94@oasis.local.home> <20200802023318.GA3981683@rani.riverdale.lan> <20200804000345.f5727ac28647aa8c092cc109@kernel.org> <20200803152959.GA1168816@rani.riverdale.lan> <20200803132238.1e40aa37@oasis.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Aug 2020 13:22:38 -0400 Steven Rostedt wrote: > On Mon, 3 Aug 2020 11:29:59 -0400 > Arvind Sankar wrote: > > > > + /* parse_args() stops at '--' and returns an address */ > > > + if (!IS_ERR(err) && err) > > > + initargs_found = true; > > > + > > > > I think you can drop the second IS_ERR, since we already checked that. > > Masami, > > Can you send this with the update as a normal patch (not a Cc to this > thread). That way it gets caught by my patchwork scanning of my inbox. OK, I'll update it. > > Thanks! > > (/me is currently going through all his patchwork patches to pull in > for the merge window.) Thank you! > > -- Steve -- Masami Hiramatsu