From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5053FC433E0 for ; Wed, 5 Aug 2020 05:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33261207FC for ; Wed, 5 Aug 2020 05:00:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Hm+vhUbO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbgHEFAb (ORCPT ); Wed, 5 Aug 2020 01:00:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgHEFAb (ORCPT ); Wed, 5 Aug 2020 01:00:31 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F66BC06174A; Tue, 4 Aug 2020 22:00:31 -0700 (PDT) Received: from nazgul.tnic (unknown [78.130.214.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9267A1EC011B; Wed, 5 Aug 2020 07:00:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1596603626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=M3haVkitNUiWuc7NCIim2ARWnDN/wpkJsTyk3+Ptaso=; b=Hm+vhUbO75VtUiOsdn2m1nNHe8V07GnWzm6HS3yR8ekG4/FriMesY9AbCnqW3xGDueT/f/ fzNwWc5ECYygQ5Iikp0On0tyGy6cQ41kUkJoTiFgivsbTlFKlIr7ZHzWuvlbee6NJX98j9 mJGfFdkRggKXd8J2iDxJwX+zh1max8I= Date: Wed, 5 Aug 2020 06:59:55 +0200 From: Borislav Petkov To: Luca Stefani Cc: Tony Luck , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] RAS/CEC: Fix cec_init prototype Message-ID: <20200805045955.GB9127@nazgul.tnic> References: <20200804161847.825391-1-luca.stefani.ge1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200804161847.825391-1-luca.stefani.ge1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2020 at 06:18:47PM +0200, Luca Stefani wrote: > * late_initcall expects a function to return an integer Please write a proper sentence for a commit message. > Signed-off-by: Luca Stefani > --- > drivers/ras/cec.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c > index 569d9ad2c594..e048e0e3949a 100644 > --- a/drivers/ras/cec.c > +++ b/drivers/ras/cec.c > @@ -553,20 +553,20 @@ static struct notifier_block cec_nb = { > .priority = MCE_PRIO_CEC, > }; > > -static void __init cec_init(void) > +static int __init cec_init(void) > { > if (ce_arr.disabled) > - return; > + return 0; Why 0? I'm thinking all the cases when the init doesn't succeed should return !0... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette