From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5812C433E0 for ; Wed, 5 Aug 2020 09:07:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ED8120792 for ; Wed, 5 Aug 2020 09:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WharFQIr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ED8120792 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3FO5-0002sr-Re for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 05:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3FNX-0002T6-1Y for qemu-devel@nongnu.org; Wed, 05 Aug 2020 05:06:31 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55186 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3FNV-0002Qp-Gt for qemu-devel@nongnu.org; Wed, 05 Aug 2020 05:06:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596618388; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=DcqANlyPiNB6qBjsAIt7RjkjtOr7MNm8WxS7JFaH8ek=; b=WharFQIrPBJ35/WQrquJpfq59nrRYfioGRnEM8+gq6MOKi6cNmJ1/xyTOB98xwkLeFHKNp VLVICnAJ5753QU1q0qsJ8//G/yjiE2ISxHKQK7BDYMatEwqqzVK6Y0uyoGqxUteGOisL5Q Y2yCbMBQ74e01GzWal8pd2C7mIT1Ni4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-YWdOnaB8MNuyBvo485lz4Q-1; Wed, 05 Aug 2020 05:05:56 -0400 X-MC-Unique: YWdOnaB8MNuyBvo485lz4Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B610257; Wed, 5 Aug 2020 09:05:55 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 521C960BF3; Wed, 5 Aug 2020 09:05:43 +0000 (UTC) Date: Wed, 5 Aug 2020 10:05:40 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Subject: Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline) Message-ID: <20200805090540.GC4127670@redhat.com> References: <87ft94klyl.fsf@dusky.pond.sub.org> <490a0786-73f3-411e-4dfe-8c2ae90de251@redhat.com> <87y2mvhg3k.fsf@dusky.pond.sub.org> <87k0yeg7mc.fsf@dusky.pond.sub.org> <6e5df5fc-94f8-ee8e-0c14-f56135de25e4@redhat.com> <87o8np5ysp.fsf@dusky.pond.sub.org> <9f83eb93-5389-7aad-3031-0777de0c35b0@redhat.com> <20200805083949.GA3004@work-vm> <241436db-1aec-b804-314f-7893954e981b@redhat.com> MIME-Version: 1.0 In-Reply-To: <241436db-1aec-b804-314f-7893954e981b@redhat.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 03:37:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Jason Wang , Juan Quintela , Yuval Shaia , "Dr. David Alan Gilbert" , Markus Armbruster , Gerd Hoffmann , Andrea Bolognani , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , John Snow , Michael Roth , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 05, 2020 at 10:49:35AM +0200, Paolo Bonzini wrote: > On 05/08/20 10:39, Dr. David Alan Gilbert wrote: > >> Do you really use "git blame" that much? "git log -S" does more or less > >> the same function (in a different way) and is not affected as much by > >> large code movement and transformation patches. > > > > I use it a lot! Following stuff back to find where a change came > > from and then asking people. > > Indeed, but I use "git log -S" instead. :) Another possibility is to > just do "git log -p" and search for a relevant line of the code I'm > "blaming". I used git blame alot too, but I don't think its a reason to not do the cleanups. It is easy enough to just tell blame to use an earlier commit if you see it displaying a refactor. I don't think such mild inconvenience should stop us making otherwise desirable code changes Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|