From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 232A3C433E1 for ; Fri, 7 Aug 2020 04:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0789822CAF for ; Fri, 7 Aug 2020 04:57:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OjdveiZ5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726202AbgHGE5n (ORCPT ); Fri, 7 Aug 2020 00:57:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgHGE5m (ORCPT ); Fri, 7 Aug 2020 00:57:42 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20730C061575 for ; Thu, 6 Aug 2020 21:57:42 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id o1so503254plk.1 for ; Thu, 06 Aug 2020 21:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RKSuRZnH7B8qwd05Kn2/tUaiHF4PaG/VCbDqHCt8jc8=; b=OjdveiZ5BMzMt4uuuBFfbVyKjxX6XK2+AGeN6VCnojt4THMeCzJT0uoWCWUfuKZUNT U2tctUfwtrU11T1yawCmWqczY0+tTEFo8wHCthmuevSco7dxSco6nitoSK2whpBy9jMl RsY1NoVjR7dHTR9SvOS3XvJAG4jbBt9xg95/AiM33vpXDzIg09ca/ZDnOkmV0VNYiy86 IW8iBivM1FBJTzvuYi0zObHF53ambZhfBAhxD0Ab9jIvT9upu+crAr0kb4OuIaE0ftUl Doul1zkdXMBaLdhTEgLYq/nJlbzn3w9Ojw87XLwYYXhRux1fGvjOQ0v956I1dXJwGGnu VNYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RKSuRZnH7B8qwd05Kn2/tUaiHF4PaG/VCbDqHCt8jc8=; b=KzMx2m9AEUaw+Th3vt37poWtFeIZY8I+LdYyxbHVH3bQvapqRV/kOGdJwSOmt8a3Ik MXydOSTLY3Djq0yoxXGTK/35055eUCpvd2d0YZH3d1wEW0k15DLCDxQnUj1ned3QlzV0 8Q2FOG7wzD2+xGbkAMdIDcUZ1KnhXEiSGG87vmHOqAacV2CFTOBghRY7PBOZmgHYkV9V tBECfo/OQbNKEuEj67M9Ia3lTT3Vhe+rhwaw961tTJYRCRBiHJO/6Cqd4lYEwepccmGx /kWymXYqpUZXs2KMEJeXSXBlmYbc4NN7JYkuDD5g8+shJNteoSPb09908TBfTWYRm4Vn TO2w== X-Gm-Message-State: AOAM530CrVTR53yxSuET5DN7eJ1w4mOgVB/exy7KG7LAIORM3eExiPTV pO9D42K02f6zFeZGOLEKpYlnBw== X-Google-Smtp-Source: ABdhPJzuYLI2KYeV5yyGVoEvDb+KX0w0VZv7SeXrBF18U5ssl8L0wVqq9k258KyhPf3jdnGkhtWKRg== X-Received: by 2002:a17:90a:c7:: with SMTP id v7mr11862593pjd.139.1596776261665; Thu, 06 Aug 2020 21:57:41 -0700 (PDT) Received: from localhost ([223.190.59.99]) by smtp.gmail.com with ESMTPSA id f63sm8326666pjk.53.2020.08.06.21.57.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Aug 2020 21:57:41 -0700 (PDT) Date: Fri, 7 Aug 2020 10:27:35 +0530 From: Viresh Kumar To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Kukjin Kim , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 36/41] cpufreq: s3c2412: use global s3c2412_cpufreq_setrefresh Message-ID: <20200807045735.xnury5wtxst3vfyl@vireshk-mac-ubuntu> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-36-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200806182059.2431-36-krzk@kernel.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-08-20, 20:20, Krzysztof Kozlowski wrote: > From: Arnd Bergmann > > There are two identical copies of the s3c2412_cpufreq_setrefresh > function: a static one in the cpufreq driver and a global > version in iotiming-s3c2412.c. > > As the function requires the use of a hardcoded register address > from a header that we want to not be visible to drivers, just > move the existing global function and add a declaration in > one of the cpufreq header files. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > --- > drivers/cpufreq/s3c2412-cpufreq.c | 23 -------------------- > include/linux/soc/samsung/s3c-cpufreq-core.h | 1 + > 2 files changed, 1 insertion(+), 23 deletions(-) Acked-by: Viresh Kumar -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD65C433DF for ; Fri, 7 Aug 2020 04:59:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EF80221E2 for ; Fri, 7 Aug 2020 04:59:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ndX9+3oh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OjdveiZ5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EF80221E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OCoycUQHmO1ARy4+v00W2fWR+9PwRaJJ+u6CzvqtaAk=; b=ndX9+3oh8pSuTdbn8weSrtazP BVeMloGXM9T++V+KjiNq31OpZzx8Lho46APWlE1LZIF4FCRFaTCg2GCwuvK0mY0oSvNmloEiF88Jt EGsBK3Rq0IsxbUxKzPQjlTyqHUmRcB3xqpGe0H+SlJWB5PCzB0hPIci3cnhNqlZqh/7azcDy/vmMR pxWkspZvILT3jL7ZZcjQ3tXh2WzlGCcnoLSqqJs2s9DOtRBWPkuFQWMmoMdDN4+qNzLt9XtnwtmVj eH46Zn5VHfiEK+OhWNHyKHlK7UGjAvU+ip457q0wR7HI+Nvnb2yM2ldcTh5h5UQM9zFjvz2Gr54dr 05wwPOtsA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3uRv-00037f-2n; Fri, 07 Aug 2020 04:57:47 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3uRs-00036b-FR for linux-arm-kernel@lists.infradead.org; Fri, 07 Aug 2020 04:57:45 +0000 Received: by mail-pl1-x644.google.com with SMTP id f10so487758plj.8 for ; Thu, 06 Aug 2020 21:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RKSuRZnH7B8qwd05Kn2/tUaiHF4PaG/VCbDqHCt8jc8=; b=OjdveiZ5BMzMt4uuuBFfbVyKjxX6XK2+AGeN6VCnojt4THMeCzJT0uoWCWUfuKZUNT U2tctUfwtrU11T1yawCmWqczY0+tTEFo8wHCthmuevSco7dxSco6nitoSK2whpBy9jMl RsY1NoVjR7dHTR9SvOS3XvJAG4jbBt9xg95/AiM33vpXDzIg09ca/ZDnOkmV0VNYiy86 IW8iBivM1FBJTzvuYi0zObHF53ambZhfBAhxD0Ab9jIvT9upu+crAr0kb4OuIaE0ftUl Doul1zkdXMBaLdhTEgLYq/nJlbzn3w9Ojw87XLwYYXhRux1fGvjOQ0v956I1dXJwGGnu VNYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RKSuRZnH7B8qwd05Kn2/tUaiHF4PaG/VCbDqHCt8jc8=; b=ZUR+5+8/2M26GFqK6MgXwLxtlkKauK5O84HWYwqF9ed2p0hK9sZ9kG5X7gz4g3/Utn nbaAMREBMvT6dfY+bRwzeFI6Sfsutak0Sqh/1YoOGHDmWnW/2wHqCBzNmEP9jiW8GzrV hJF4xWe7fDOTHqrghX4/8aUPVz6JHCCMCpetypo0tfefYTMShPiT9DAnoDqXwiVoglIZ QhF7vTytcH2LB3Q8aelDg1bu5OO2AxDE14bpHpSz1Fbt1wvBFP79DUAayBfemK1Prl19 fwSUvnRh/qDQx53py/CayHeqVnjKH17T6Nqpmv+TPCBA2F541Y7agKv4x9nLgzqv85LS L42A== X-Gm-Message-State: AOAM531mq/SU4Jw/hSlHkzDcrK6hdk7jmREl48NfV1O4eB0MLTesgJz1 7UF43QUAdaSZfWd8cufBx8MYMQ== X-Google-Smtp-Source: ABdhPJzuYLI2KYeV5yyGVoEvDb+KX0w0VZv7SeXrBF18U5ssl8L0wVqq9k258KyhPf3jdnGkhtWKRg== X-Received: by 2002:a17:90a:c7:: with SMTP id v7mr11862593pjd.139.1596776261665; Thu, 06 Aug 2020 21:57:41 -0700 (PDT) Received: from localhost ([223.190.59.99]) by smtp.gmail.com with ESMTPSA id f63sm8326666pjk.53.2020.08.06.21.57.40 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Aug 2020 21:57:41 -0700 (PDT) Date: Fri, 7 Aug 2020 10:27:35 +0530 From: Viresh Kumar To: Krzysztof Kozlowski Subject: Re: [PATCH v2 36/41] cpufreq: s3c2412: use global s3c2412_cpufreq_setrefresh Message-ID: <20200807045735.xnury5wtxst3vfyl@vireshk-mac-ubuntu> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-36-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200806182059.2431-36-krzk@kernel.org> User-Agent: NeoMutt/20170609 (1.8.3) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200807_005744_600094_CBEEC96B X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Arnd Bergmann , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06-08-20, 20:20, Krzysztof Kozlowski wrote: > From: Arnd Bergmann > > There are two identical copies of the s3c2412_cpufreq_setrefresh > function: a static one in the cpufreq driver and a global > version in iotiming-s3c2412.c. > > As the function requires the use of a hardcoded register address > from a header that we want to not be visible to drivers, just > move the existing global function and add a declaration in > one of the cpufreq header files. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > --- > drivers/cpufreq/s3c2412-cpufreq.c | 23 -------------------- > include/linux/soc/samsung/s3c-cpufreq-core.h | 1 + > 2 files changed, 1 insertion(+), 23 deletions(-) Acked-by: Viresh Kumar -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel