All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Edward Cree <ecree@solarflare.com>
Cc: linux-net-drivers@solarflare.com, davem@davemloft.net,
	netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time
Date: Sat, 8 Aug 2020 17:29:47 -0700	[thread overview]
Message-ID: <20200809002947.GA92634@roeck-us.net> (raw)
In-Reply-To: <827807a1-c4d6-d7de-7e9c-939d927d66cc@solarflare.com>

On Mon, Aug 03, 2020 at 09:33:20PM +0100, Edward Cree wrote:
> Several parts of the EF100 architecture are parameterised (to allow
>  varying capabilities on FPGAs according to resource constraints), and
>  these parameters are exposed to the driver through a TLV-encoded
>  region of the BAR.
> For the most part we either don't care about these values at all or
>  just need to sanity-check them against the driver's assumptions, but
>  there are a number of TSO limits which we record so that we will be
>  able to check against them in the TX path when handling GSO skbs.
> 
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> ---
>  drivers/net/ethernet/sfc/ef100_nic.c | 216 +++++++++++++++++++++++++++
>  drivers/net/ethernet/sfc/ef100_nic.h |   4 +
>  2 files changed, 220 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/ef100_nic.c b/drivers/net/ethernet/sfc/ef100_nic.c
> index c2bec2bdbc1f..9b5e4b42fe51 100644
> --- a/drivers/net/ethernet/sfc/ef100_nic.c
> +++ b/drivers/net/ethernet/sfc/ef100_nic.c

[ ... ]

> +		if (EFX_MIN_DMAQ_SIZE % reader->value) {

This is a 64-bit operation (value is 64 bit). Result on 32-bit builds:

ERROR: modpost: "__umoddi3" [drivers/net/ethernet/sfc/sfc.ko] undefined!

Guenter

  reply	other threads:[~2020-08-09  0:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 20:30 [PATCH v3 net-next 00/11] sfc: driver for EF100 family NICs, part 2 Edward Cree
2020-08-03 20:32 ` [PATCH v3 net-next 01/11] sfc_ef100: check firmware version at start-of-day Edward Cree
2020-08-03 20:32 ` [PATCH v3 net-next 02/11] sfc_ef100: fail the probe if NIC uses unsol_ev credits Edward Cree
2020-08-03 20:33 ` [PATCH v3 net-next 03/11] sfc_ef100: read Design Parameters at probe time Edward Cree
2020-08-09  0:29   ` Guenter Roeck [this message]
2020-08-10  8:15     ` Edward Cree
2020-08-10 15:52       ` Guenter Roeck
2020-08-03 20:34 ` [PATCH v3 net-next 04/11] sfc_ef100: TX path for EF100 NICs Edward Cree
2020-08-03 20:34 ` [PATCH v3 net-next 05/11] sfc_ef100: RX filter table management and related gubbins Edward Cree
2020-08-03 20:36 ` [PATCH v3 net-next 06/11] sfc_ef100: RX path for EF100 Edward Cree
2020-08-03 20:36 ` [PATCH v3 net-next 07/11] sfc_ef100: plumb in fini_dmaq Edward Cree
2020-08-03 20:37 ` [PATCH v3 net-next 08/11] sfc_ef100: statistics gathering Edward Cree
2020-08-03 20:37 ` [PATCH v3 net-next 09/11] sfc_ef100: functions for selftests Edward Cree
2020-08-03 20:38 ` [PATCH v3 net-next 10/11] sfc_ef100: read pf_index at probe time Edward Cree
2020-08-03 20:40 ` [PATCH v3 net-next 11/11] sfc_ef100: add nic-type for VFs, and bind to them Edward Cree
2020-08-04  1:16   ` kernel test robot
2020-08-04  1:16     ` kernel test robot
2020-08-04  1:30     ` David Miller
2020-08-04  1:30       ` David Miller
2020-08-04 13:31       ` Edward Cree
2020-08-04 13:31         ` Edward Cree
2020-08-03 22:26 ` [PATCH v3 net-next 00/11] sfc: driver for EF100 family NICs, part 2 Jakub Kicinski
2020-08-04  1:23   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200809002947.GA92634@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=davem@davemloft.net \
    --cc=ecree@solarflare.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.