From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25134C433DF for ; Mon, 10 Aug 2020 15:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D395122CF7 for ; Mon, 10 Aug 2020 15:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597073220; bh=NajSs1Z99avoqEJYEN3KQczFfF3ZREaKMTzEr1nsvuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ry4shr1cWPByHkBG71DC1cY2LReOzIwc/ujqiNvKCM6WYqHi2N2XWxOt58SrhmJsJ htl0xiseQaldRJHn7G8UMckZHVcpPcja1FpT53hI5MwRWKzW6tdNGwiWrNsvyAKA4v c+fFnmFdFuCwd1/l+dW1amjtsLAvrtWY4CKre+TY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbgHJP06 (ORCPT ); Mon, 10 Aug 2020 11:26:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:60966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728685AbgHJP0z (ORCPT ); Mon, 10 Aug 2020 11:26:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9791022B47; Mon, 10 Aug 2020 15:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597073215; bh=NajSs1Z99avoqEJYEN3KQczFfF3ZREaKMTzEr1nsvuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yyBa89Oi2lrxNlCFR44vkAuoopd5Hgfc7M0GKX+GDUd+nj5L3rD1zjCndlqMVuKBT id+mJT0jmQsTr8ZV0nNlAKjKBV8FSg7t31sZNIDT+dXkxrMWtCpjvBOiO67Mz+z3zT 207pL8zDgUuf8R4yVHmsNrjnVOtN/fh2AUkaxqE4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hui Wang , Takashi Iwai Subject: [PATCH 5.4 08/67] Revert "ALSA: hda: call runtime_allow() for all hda controllers" Date: Mon, 10 Aug 2020 17:20:55 +0200 Message-Id: <20200810151809.844857572@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810151809.438685785@linuxfoundation.org> References: <20200810151809.438685785@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hui Wang commit 07c9983b567d0ef33aefc063299de95a987e12a8 upstream. This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow() for all hda controllers"). The reverted patch already introduced some regressions on some machines: - on gemini-lake machines, the error of "azx_get_response timeout" happens in the hda driver. - on the machines with alc662 codec, the audio jack detection doesn't work anymore. Fixes: 9a6418487b56 ("ALSA: hda: call runtime_allow() for all hda controllers") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511 Cc: Signed-off-by: Hui Wang Link: https://lore.kernel.org/r/20200803064638.6139-1-hui.wang@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2306,7 +2306,6 @@ static int azx_probe_continue(struct azx if (azx_has_pm_runtime(chip)) { pm_runtime_use_autosuspend(&pci->dev); - pm_runtime_allow(&pci->dev); pm_runtime_put_autosuspend(&pci->dev); }