All of lore.kernel.org
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org
Subject: Re: What's cooking in git.git (Aug 2020, #02; Mon, 10)
Date: Tue, 11 Aug 2020 09:59:42 +0000	[thread overview]
Message-ID: <20200811095942.GG8085@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20200811065347.GA1486938@coredump.intra.peff.net>

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

On 2020-08-11 at 06:53:47, Jeff King wrote:
> diff --git a/t/t1416-ref-transaction-hooks.sh b/t/t1416-ref-transaction-hooks.sh
> index d4d19194bf..f6e741c6c0 100755
> --- a/t/t1416-ref-transaction-hooks.sh
> +++ b/t/t1416-ref-transaction-hooks.sh
> @@ -7,6 +7,7 @@ test_description='reference transaction hooks'
>  test_expect_success setup '
>  	mkdir -p .git/hooks &&
>  	test_commit PRE &&
> +	PRE_OID=$(git rev-parse PRE) &&
>  	test_commit POST &&
>  	POST_OID=$(git rev-parse POST)
>  '
> @@ -120,10 +121,10 @@ test_expect_success 'interleaving hook calls succeed' '
>  	EOF
>  
>  	cat >expect <<-EOF &&
> -		hooks/update refs/tags/PRE 0000000000000000000000000000000000000000 63ac8e7bcdb882293465435909f54a96de17d4f7
> +		hooks/update refs/tags/PRE $ZERO_OID $PRE_OID
>  		hooks/reference-transaction prepared
>  		hooks/reference-transaction committed
> -		hooks/update refs/tags/POST 0000000000000000000000000000000000000000 99d53161c3a0a903b6561b9f6c0c665b3a476401
> +		hooks/update refs/tags/POST $ZERO_OID $POST_OID
>  		hooks/reference-transaction prepared
>  		hooks/reference-transaction committed
>  	EOF

Yeah, this looks reasonable.  I'm glad we've got CI working on the
SHA-256 code now to catch these kinds of things.
-- 
brian m. carlson: Houston, Texas, US

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  parent reply	other threads:[~2020-08-11 10:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 19:44 What's cooking in git.git (Aug 2020, #02; Mon, 10) Junio C Hamano
2020-08-11  5:01 ` Eric Sunshine
2020-08-11 19:24   ` Junio C Hamano
2020-08-11  6:53 ` Jeff King
2020-08-11  9:33   ` Patrick Steinhardt
2020-08-11  9:59   ` brian m. carlson [this message]
2020-08-11 10:10 ` Sergey Organov
2020-08-11 19:23   ` Junio C Hamano
2020-08-11 19:34     ` Sergey Organov
2020-08-11 20:17       ` Sergey Organov
2020-08-11 21:36         ` Junio C Hamano
2020-08-12  8:15           ` Sergey Organov
2020-08-11 20:28       ` Junio C Hamano
2020-08-11 21:26         ` Sergey Organov
2020-08-11 22:12           ` Junio C Hamano
2020-08-11 13:48 ` Taylor Blau
2020-08-11 14:27 ` Matheus Tavares Bernardino
2020-08-11 19:20   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811095942.GG8085@camp.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.