From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67C6C433E0 for ; Tue, 11 Aug 2020 16:01:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A2BF20774 for ; Tue, 11 Aug 2020 16:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597161672; bh=WqOeCwBrfL1Ph4eW+msUcABQxFvWOzeS+Ilt/PQFHLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PD3YJZ7w7Y7sXHCKoxeVzvKA+vtbsKQlOfkDNNfKnage/UOgIa3noQnJkiq+HBBpO HSVj4FwmVwGcz1y0cC3u1b3VSYTEcK54kLepRrospOVpGRjF8kRzHiNsE7ZNWPOUFS S3ifUIUPxlGqU87W9uIs2/DZgws+NJJFPZUkRk70= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728978AbgHKQBK (ORCPT ); Tue, 11 Aug 2020 12:01:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:54978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728783AbgHKQBH (ORCPT ); Tue, 11 Aug 2020 12:01:07 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82D16206B5; Tue, 11 Aug 2020 16:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597161667; bh=WqOeCwBrfL1Ph4eW+msUcABQxFvWOzeS+Ilt/PQFHLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKwI0NPsElnu0sNHlCbru4nBORecokpfU8RGDSlJMxTaHdd1bMlBL5hXfBbaLG2M5 oUfD0Z3cuNCKmjUXoioD4LvkIKSu8Siq4rnmHHsr6yGM5N8GOirH9JAq2us/QOkOwX rQ34UJ3RKhpxxS7jq79uRjcLEZ7nu9OiPABjc3qQ= Date: Tue, 11 Aug 2020 17:00:39 +0100 From: Mark Brown To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Lee Jones , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/33] mfd, regulator: get rid of unused code at HiSilicon SPMI PMIC Message-ID: <20200811160039.GI6967@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mhOzvPhkurUs4vA9" Content-Disposition: inline In-Reply-To: X-Cookie: Gravity is a myth, the Earth sucks. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mhOzvPhkurUs4vA9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 11, 2020 at 05:41:30PM +0200, Mauro Carvalho Chehab wrote: > There are some checks there which could make sense for > downstream builds, but doesn't make much sense for > upstream ones. They came from the official Hikey970 tree > from Linaro, but even there, the commented-out code is not > set via other Kconfig vars. > So, let's just get rid of that. If needed later, this > patch can be (partially?) reversed. > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/mfd/hisi_pmic_spmi.c | 63 -------- > drivers/regulator/hisi_regulator_spmi.c | 196 +----------------------- > include/linux/mfd/hisi_pmic.h | 42 ----- > 3 files changed, 8 insertions(+), 293 deletions(-) This is fixing stuff added in the previous patch, please just fold these fixes into the first patch. --mhOzvPhkurUs4vA9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8ywKYACgkQJNaLcl1U h9DfTgf/R98UUwdsptqlmy77TLWRqmGvuqch0ReEGcX0+dvQjwpmLMJTnhxcWIdV 3HOx7BUNAXDC40wVtk3cFPH5HbsY+5vVSH/adlDxlhW/u07/B7M9NlraomuDoXAP mv60PGLMoQzI/ofealJWfAnxvP+a9ihJULkX+8ppu/JnEtY3e/SjzOvZeOTVtmwV hIs52HoLyzBBUtbcqFLGThgJuu8DCL41ovj91rFEIy/NUz0Q7v388or51x5aq64r j1nSV1mbfyW4kWL2LoqdeEa8PX6Gbz8OOH/L5D/eYBvx4gmzUjFjlUF4gyaDlLTH UkmL3HMYEqFndRCp5V6IKMYLrUSkQA== =FdxW -----END PGP SIGNATURE----- --mhOzvPhkurUs4vA9--