All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Antti Keränen" <antti@keraset.fi>,
	"Taylor Blau" <me@ttaylorr.com>,
	phillip.wood@dunelm.org.uk, "Antti Keränen" <detegr@rbx.email>,
	git@vger.kernel.org, "Jussi Keränen" <jussike@gmail.com>,
	"Alban Gruin" <alban.gruin@gmail.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] rebase -i: Fix possibly wrong onto hash in todo
Date: Tue, 11 Aug 2020 15:01:39 -0400	[thread overview]
Message-ID: <20200811190139.GB34058@syl.lan> (raw)
In-Reply-To: <xmqqsgct9fi1.fsf@gitster.c.googlers.com>

On Tue, Aug 11, 2020 at 11:58:14AM -0700, Junio C Hamano wrote:
> Antti Keränen <antti@keraset.fi> writes:
>
> > On Tue, Aug 11, 2020 at 11:36:21AM -0400, Taylor Blau wrote:
> >> Ack, I noticed this too during my review, but apparently forgot to
> >> comment on it. I'm puzzled by the first '..*'. If you're searching for
> >> any non-empty string, how about '.+' instead?
> >
> > That's true. Good point. I pretty much copy&pasted the 'todo count' test
> > so I didn't give this much thought. I'll fix this.
>
> Please don't shorten ..* into .+ if you are writing a portable sed
> script---stick to the BRE.

Sure, and sorry -- I didn't know that we cared about the difference
between BRE and ERE. Do you prefer ..* over .\+? Both should be
supported in BRE, if I'm reading [1] correctly.

Thanks,
Taylor

[1]: https://www.gnu.org/software/sed/manual/html_node/BRE-vs-ERE.html#BRE-vs-ERE

  reply	other threads:[~2020-08-11 19:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 13:13 [PATCH] rebase -i: Fix possibly wrong onto hash in todo Antti Keränen
2020-08-11 15:28 ` Taylor Blau
2020-08-11 18:10   ` Antti Keränen
2020-08-11 18:24     ` Taylor Blau
2020-08-11 15:32 ` Phillip Wood
2020-08-11 15:36   ` Taylor Blau
2020-08-11 18:15     ` Antti Keränen
2020-08-11 18:58       ` Junio C Hamano
2020-08-11 19:01         ` Taylor Blau [this message]
2020-08-11 19:05           ` Junio C Hamano
2020-08-12 14:03             ` Taylor Blau
2020-08-12 19:40               ` Junio C Hamano
2020-08-12 13:59       ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811190139.GB34058@syl.lan \
    --to=me@ttaylorr.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alban.gruin@gmail.com \
    --cc=antti@keraset.fi \
    --cc=detegr@rbx.email \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jussike@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.