From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E668C433DF for ; Tue, 11 Aug 2020 19:17:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47D312076B for ; Tue, 11 Aug 2020 19:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbgHKTRL (ORCPT ); Tue, 11 Aug 2020 15:17:11 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:39568 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgHKTRK (ORCPT ); Tue, 11 Aug 2020 15:17:10 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A092620023; Tue, 11 Aug 2020 21:17:05 +0200 (CEST) Date: Tue, 11 Aug 2020 21:17:04 +0200 From: Sam Ravnborg To: Laurent Pinchart , Vinay Simha B N Cc: Vinay Simha B N , Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , open list , "open list:DRM DRIVERS" , Andrzej Hajda Subject: Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver Message-ID: <20200811191704.GA524675@ravnborg.org> References: <1594388491-15129-1-git-send-email-simhavcs@gmail.com> <1594388491-15129-2-git-send-email-simhavcs@gmail.com> <20200808213022.GW6186@pendragon.ideasonboard.com> <20200810175440.GC292825@ravnborg.org> <20200811101942.GB6054@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200811101942.GB6054@pendragon.ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=WC5eoWgHUSoulA4aEAAA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinay. > > > > If Laurent or others identify further things to improve we can take > > it in-tree. > > Just one thing, please see below. > > > > > >> + d2l_write(tc->i2c, VTIM1, vtime1); > > > > >> + d2l_write(tc->i2c, HTIM2, htime2); > > > > >> + d2l_write(tc->i2c, VTIM2, vtime2); > > > > >> + > > > > >> + d2l_write(tc->i2c, VFUEN, VFUEN_EN); > > > > >> + d2l_write(tc->i2c, SYSRST, SYS_RST_LCD); > > > > >> + d2l_write(tc->i2c, LVPHY0, LV_PHY0_PRBS_ON(4) | LV_PHY0_ND(6)); > > > > >> + > > > > >> + dev_dbg(tc->dev, "bus_formats %04x bpc %d\n", > > > > >> + connector->display_info.bus_formats[0], > > > > >> + tc->bpc); > > > > >> + /* > > > > >> + * Default hardware register settings of tc358775 configured > > > > >> + * with MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA jeida-24 format > > > > >> + */ > > > > >> + if (connector->display_info.bus_formats[0] == > > > > >> + MEDIA_BUS_FMT_RGB888_1X7X4_SPWG) { > > This shouldn't come from the connector, but from the > drm_bridge_state.output_bus_cfg.format. The drm_bridge_funcs > .atomic_get_input_bus_fmts() operation likely needs to be implemented. I trust you will look into this and submit a patch on top of drm-misc-next. Please add a proper "Fixes:" tag identifying the commit that introduced this bug - in this case the commit introducing the driver. Do not hesitate to reply to all if you have any questions. We will help you if we can. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FB3C433E0 for ; Tue, 11 Aug 2020 19:17:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B92CD2076B for ; Tue, 11 Aug 2020 19:17:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B92CD2076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B2E66E573; Tue, 11 Aug 2020 19:17:11 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 301006E573 for ; Tue, 11 Aug 2020 19:17:10 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A092620023; Tue, 11 Aug 2020 21:17:05 +0200 (CEST) Date: Tue, 11 Aug 2020 21:17:04 +0200 From: Sam Ravnborg To: Laurent Pinchart , Vinay Simha B N Subject: Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver Message-ID: <20200811191704.GA524675@ravnborg.org> References: <1594388491-15129-1-git-send-email-simhavcs@gmail.com> <1594388491-15129-2-git-send-email-simhavcs@gmail.com> <20200808213022.GW6186@pendragon.ideasonboard.com> <20200810175440.GC292825@ravnborg.org> <20200811101942.GB6054@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200811101942.GB6054@pendragon.ideasonboard.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=WC5eoWgHUSoulA4aEAAA:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Neil Armstrong , David Airlie , Jonas Karlman , open list , "open list:DRM DRIVERS" , Andrzej Hajda , Vinay Simha B N Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Vinay. > > > > If Laurent or others identify further things to improve we can take > > it in-tree. > > Just one thing, please see below. > > > > > >> + d2l_write(tc->i2c, VTIM1, vtime1); > > > > >> + d2l_write(tc->i2c, HTIM2, htime2); > > > > >> + d2l_write(tc->i2c, VTIM2, vtime2); > > > > >> + > > > > >> + d2l_write(tc->i2c, VFUEN, VFUEN_EN); > > > > >> + d2l_write(tc->i2c, SYSRST, SYS_RST_LCD); > > > > >> + d2l_write(tc->i2c, LVPHY0, LV_PHY0_PRBS_ON(4) | LV_PHY0_ND(6)); > > > > >> + > > > > >> + dev_dbg(tc->dev, "bus_formats %04x bpc %d\n", > > > > >> + connector->display_info.bus_formats[0], > > > > >> + tc->bpc); > > > > >> + /* > > > > >> + * Default hardware register settings of tc358775 configured > > > > >> + * with MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA jeida-24 format > > > > >> + */ > > > > >> + if (connector->display_info.bus_formats[0] == > > > > >> + MEDIA_BUS_FMT_RGB888_1X7X4_SPWG) { > > This shouldn't come from the connector, but from the > drm_bridge_state.output_bus_cfg.format. The drm_bridge_funcs > .atomic_get_input_bus_fmts() operation likely needs to be implemented. I trust you will look into this and submit a patch on top of drm-misc-next. Please add a proper "Fixes:" tag identifying the commit that introduced this bug - in this case the commit introducing the driver. Do not hesitate to reply to all if you have any questions. We will help you if we can. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel