All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm list <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Oliver Upton <oupton@google.com>, Peter Shier <pshier@google.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] kvm: x86: Read PDPTEs on CR0.CD and CR0.NW changes
Date: Tue, 11 Aug 2020 21:18:12 -0600	[thread overview]
Message-ID: <20200811211812.31e8dd63@x1.home> (raw)
In-Reply-To: <CALMp9eSq-PenitkYiCJu3hXcYsWqi4FCpPnAA2TXfH_rmAxgAw@mail.gmail.com>

On Tue, 11 Aug 2020 19:45:17 -0700
Jim Mattson <jmattson@google.com> wrote:

> On Tue, Aug 11, 2020 at 6:34 PM Alex Williamson
> <alex.williamson@redhat.com> wrote:
> >
> > On Tue,  7 Jul 2020 15:36:30 -0700
> > Jim Mattson <jmattson@google.com> wrote:
> >  
> > > According to the SDM, when PAE paging would be in use following a
> > > MOV-to-CR0 that modifies any of CR0.CD, CR0.NW, or CR0.PG, then the
> > > PDPTEs are loaded from the address in CR3. Previously, kvm only loaded
> > > the PDPTEs when PAE paging would be in use following a MOV-to-CR0 that
> > > modified CR0.PG.
> > >
> > > Signed-off-by: Jim Mattson <jmattson@google.com>
> > > Reviewed-by: Oliver Upton <oupton@google.com>
> > > Reviewed-by: Peter Shier <pshier@google.com>
> > > ---  
> >
> > I can't even boot the simplest edk2 VM with this commit:  
> 
> You'll probably want to apply Sean's [PATCH] KVM: x86: Don't attempt
> to load PDPTRs when 64-bit mode is enabled.

Thanks for the pointer, yes, that resolves it.  Thanks,

Alex


      reply	other threads:[~2020-08-12  3:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 22:36 [PATCH] kvm: x86: Read PDPTEs on CR0.CD and CR0.NW changes Jim Mattson
2020-07-08  9:45 ` Paolo Bonzini
2020-08-12  1:34 ` Alex Williamson
2020-08-12  2:45   ` Jim Mattson
2020-08-12  3:18     ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811211812.31e8dd63@x1.home \
    --to=alex.williamson@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=lersek@redhat.com \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pshier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.