From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6907AC433E0 for ; Tue, 11 Aug 2020 22:46:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46876206DA for ; Tue, 11 Aug 2020 22:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A6gVIwrd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbgHKWqF (ORCPT ); Tue, 11 Aug 2020 18:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbgHKWqF (ORCPT ); Tue, 11 Aug 2020 18:46:05 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58CC5C06174A for ; Tue, 11 Aug 2020 15:46:05 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id mt12so161400pjb.4 for ; Tue, 11 Aug 2020 15:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AAlB7AADi1d+qrv8BbA2OuomHwJe1ObClWJvHdEt10k=; b=A6gVIwrdYXgM7QuIVj86358/aLJZuUzMqDOEA2hxs/8xvFM9OPYJk0obw3ZJnmD3xp D/DdcfbhvS/ihd/SPS7S19BbkHZstlgvWXsUWrfSeDFbhCS6t9B5cf/bAQ0zbHchu4h6 FNtwY2nTNAydaTiJtNHn2uzgajQJ/ZPeFhU3IL0tJ26PosnU2VHhDGlCsHbFHuFEdk4r GsA6lk55x0ArSM9pvsKTlrD14YrJoChaExi1xNFDH+leFysVmIZ3WlQENBeVcki+T06u K/ghB6dSSDzPHv9H7MvfeG9eb6qs1DxW8kaXGyDiemGrSvkqWlGQTdBxuZu8jVP8av3Z 9s4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AAlB7AADi1d+qrv8BbA2OuomHwJe1ObClWJvHdEt10k=; b=pPyAsAZ5gKpGsiPJTk0wNo10qgO1x8XL1cqDqcaJ/SBpZNMFgj2UknXyJCqTeEhlYi kVYqmyprI6IpSUYA4wu4okId7ADG1Ly7Oj8v0cLz/Wya+hoBZ5qPCqKbuq6MNXPUeqiw isJ0ZgWALAv8VqyE8by1w8c3y4hapGfZKMKn/82Nckxwm5ajU6y1W1bpHNUogWODWLRV 0s5SC+OBNg9T8qm9XiCkaX3mcWNk6KCZimCwk1c4FXpkrfxAQbCEz17T7ptMxu0xKuN7 KivTV1xVQMaTgUkAicuFpVYgpO48QM5z3xcGc1Wuxx892KRZ2DEynHqzKOs5+DgOUfVR JTqg== X-Gm-Message-State: AOAM532HsseOVm9RUgkhoMrMzsKS70sN/ebBjzebDibVKWXQiET6fdMQ vvVubDk0sltBGJkeSbbWL82yfA== X-Google-Smtp-Source: ABdhPJw139s9RYvi6HdwGiQP3oI8ROpCRG7hB09mor/U3JqJiqPAxtwLUcDJA7GP1pFhY8RzOlxcZg== X-Received: by 2002:a17:90a:202c:: with SMTP id n41mr3429775pjc.126.1597185964913; Tue, 11 Aug 2020 15:46:04 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id s18sm195630pgj.3.2020.08.11.15.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 15:46:04 -0700 (PDT) Date: Tue, 11 Aug 2020 16:46:02 -0600 From: Mathieu Poirier To: peng.fan@nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, o.rempel@pengutronix.de, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] remoteproc: imx_rproc: add elf memory hooks Message-ID: <20200811224602.GF3370567@xps15> References: <1595928673-26306-1-git-send-email-peng.fan@nxp.com> <1595928673-26306-2-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1595928673-26306-2-git-send-email-peng.fan@nxp.com> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jul 28, 2020 at 05:31:13PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > Please not apply 2/2 for now, this 2/2 has not gone through > test on all i.MX8 platforms. Why sending patches to the mailing list if they are not ready to be applied? > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 8957ed271d20..8ad860c65256 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -241,10 +242,22 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len) > return va; > } > > +static void *imx_rproc_memcpy(struct rproc *rproc, void *dest, const void *src, size_t count) > +{ > + memcpy_toio((void * __iomem)dest, src, count); > +} > + > +static void *imx_rproc_memset(struct rproc *rproc, void *s, int c, size_t count) > +{ > + memset_io((void * __iomem)s, c, count); > +} > + > static const struct rproc_ops imx_rproc_ops = { > .start = imx_rproc_start, > .stop = imx_rproc_stop, > .da_to_va = imx_rproc_da_to_va, > + .memset = imx_rproc_memset, > + .memcpy = imx_rproc_memcpy, That won't work - you are modifying how _all_ the platforms out there are working. As I indicated on the series on iMX8M, add a field to imx_rproc_dcfg and apply the correct memory accessor based on that. It might also suggest that it is time to split the iMX platform drivers, i.e older MCU and iMX8M. > }; > > static int imx_rproc_addr_init(struct imx_rproc *priv, > -- > 2.16.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B84C433DF for ; Tue, 11 Aug 2020 22:47:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2122206DA for ; Tue, 11 Aug 2020 22:47:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DqTrg3NT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A6gVIwrd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2122206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qi3Qs1xc24IZysGR03G203EutzgeU5a+ntt0csPw71Y=; b=DqTrg3NTK7BRHgKdcRQEBmOw0 dg+t7PT0ejYmWNhjvanut9t2mZ8LpOybtyQj6osFqshZk3d3mJPC1PU9lOv6UBVmcsodV+59oBp9Q 3OpB00xFYX20US2JusQAaQ0azlz+O6F+jFEYrBiX+7fCWUYJ/6YbE+KdxWfC+kzxSgIQbEgtp/0Ko yUh/PeeZUZIUGq2bHya99L4F6nKsBPO719PtjdTDMojjtZpmQEAAscCTgOwAppMDJDlpoFhIBUSGZ h9KWEkpMA3MbybDCDxIiobIMrFaypG0ResEuAb52nEILalAEziE3RgHw/TimuDGaxtruY+e+E3ZSV /hRF9e8xw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5d21-0007WZ-IQ; Tue, 11 Aug 2020 22:46:09 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5d1z-0007W6-1c for linux-arm-kernel@lists.infradead.org; Tue, 11 Aug 2020 22:46:07 +0000 Received: by mail-pj1-x1041.google.com with SMTP id c10so2082118pjn.1 for ; Tue, 11 Aug 2020 15:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AAlB7AADi1d+qrv8BbA2OuomHwJe1ObClWJvHdEt10k=; b=A6gVIwrdYXgM7QuIVj86358/aLJZuUzMqDOEA2hxs/8xvFM9OPYJk0obw3ZJnmD3xp D/DdcfbhvS/ihd/SPS7S19BbkHZstlgvWXsUWrfSeDFbhCS6t9B5cf/bAQ0zbHchu4h6 FNtwY2nTNAydaTiJtNHn2uzgajQJ/ZPeFhU3IL0tJ26PosnU2VHhDGlCsHbFHuFEdk4r GsA6lk55x0ArSM9pvsKTlrD14YrJoChaExi1xNFDH+leFysVmIZ3WlQENBeVcki+T06u K/ghB6dSSDzPHv9H7MvfeG9eb6qs1DxW8kaXGyDiemGrSvkqWlGQTdBxuZu8jVP8av3Z 9s4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AAlB7AADi1d+qrv8BbA2OuomHwJe1ObClWJvHdEt10k=; b=GmSnFznHIWReiQzcKruuquhJsYUT7T6DgtnNdB+Nk55mSiy9peCz1WxyaNtlnmwjIs cGdAr4rgE4d7aEn/G5kt0B3AdEa1L6Vnyoo1LZQmxpDqLAtUze2HOSE8q/DhnMXIlCW2 q4JVDlFeF0JOS2dtwLOF6Q/3B+narjVgI3s/HHqePf9EWT3CZXznbRpkgpnoY+a+Tevt xxH2fiSnPy83EqF2KvIYI6kGerPAxUZY9iMoXDrTqKAJh/u53qV0aMh/X1imtEIiS29i V8aLHvg1nBUfDgxJ2KknrwED8v/wcFI/sY5lBtMnITHfV9+5YevgUz+ul4hPnyxhZMU4 RjTA== X-Gm-Message-State: AOAM533Pit8rsTtr+K73lE1BfeCN1eFXbENeGP+vFT5sUBr+auVHuS28 00EXoXpYoGqAqWTgr3ODQ895dA== X-Google-Smtp-Source: ABdhPJw139s9RYvi6HdwGiQP3oI8ROpCRG7hB09mor/U3JqJiqPAxtwLUcDJA7GP1pFhY8RzOlxcZg== X-Received: by 2002:a17:90a:202c:: with SMTP id n41mr3429775pjc.126.1597185964913; Tue, 11 Aug 2020 15:46:04 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id s18sm195630pgj.3.2020.08.11.15.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 15:46:04 -0700 (PDT) Date: Tue, 11 Aug 2020 16:46:02 -0600 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH 2/2] remoteproc: imx_rproc: add elf memory hooks Message-ID: <20200811224602.GF3370567@xps15> References: <1595928673-26306-1-git-send-email-peng.fan@nxp.com> <1595928673-26306-2-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1595928673-26306-2-git-send-email-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200811_184607_221958_72F227DB X-CRM114-Status: GOOD ( 21.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 28, 2020 at 05:31:13PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > Please not apply 2/2 for now, this 2/2 has not gone through > test on all i.MX8 platforms. Why sending patches to the mailing list if they are not ready to be applied? > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 8957ed271d20..8ad860c65256 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -6,6 +6,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -241,10 +242,22 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len) > return va; > } > > +static void *imx_rproc_memcpy(struct rproc *rproc, void *dest, const void *src, size_t count) > +{ > + memcpy_toio((void * __iomem)dest, src, count); > +} > + > +static void *imx_rproc_memset(struct rproc *rproc, void *s, int c, size_t count) > +{ > + memset_io((void * __iomem)s, c, count); > +} > + > static const struct rproc_ops imx_rproc_ops = { > .start = imx_rproc_start, > .stop = imx_rproc_stop, > .da_to_va = imx_rproc_da_to_va, > + .memset = imx_rproc_memset, > + .memcpy = imx_rproc_memcpy, That won't work - you are modifying how _all_ the platforms out there are working. As I indicated on the series on iMX8M, add a field to imx_rproc_dcfg and apply the correct memory accessor based on that. It might also suggest that it is time to split the iMX platform drivers, i.e older MCU and iMX8M. > }; > > static int imx_rproc_addr_init(struct imx_rproc *priv, > -- > 2.16.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel