From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE87BC433E1 for ; Wed, 12 Aug 2020 13:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E7A3208A9 for ; Wed, 12 Aug 2020 13:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597239085; bh=E4/To4BZmhCxnbfht9VNS4HhBG2gkxXvTkLRI2p5NpE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=M3V+kFuYu94YkCQ3TQ4p2o8Fupv7eMiglnZpN3RCCwcuhaAF6phYKIIRcwuyXRlrl Gey9ejTPiA16X5vhsZPom4eo/yTgoxFTx/jEyV8KZRjNIf3CIVUD6Q+5RQAOTsHiML Ten575qs3D1B5MT8ycPAc+ijDc+a0LhSM6u7UQN0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728071AbgHLNbY (ORCPT ); Wed, 12 Aug 2020 09:31:24 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:33230 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726946AbgHLNbO (ORCPT ); Wed, 12 Aug 2020 09:31:14 -0400 Received: by mail-wm1-f67.google.com with SMTP id f18so4257081wmc.0; Wed, 12 Aug 2020 06:31:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2HXl4QZEkZ4XHgTE5pAfXdvAM2LC9rDIm1qQF4lI0C0=; b=NE9r4QyVeCz+hcmDcz/t4Jt0vv0MmVRxfgK9NCk/dTc39U7ZHMrBSbyN8hkwl3Bm74 JvEG+OFHRQQEsUiiMDIK0MCv7POBwy7mXTHEVFFSMvRL6KA+wyvnsqpmj9AjdbJadfpt AgIU6i36yb+2+TPM7qWpUobT0tetHMn/s5ZTxEtPz4N1kgmLbTyPfYOhe1rHIrlY4kkw RiTHYJiiHzlTzz9UTT5FN2cg48opVSMTU8n+ojKQUFNS8vw1Iuk8FAkUgkY/PBIDwV2V r0T37X7MqoZqAOuFLz17yVV1OY6Xl3uTlLJcutaSrtt2bTaDSW/keaMBUyHSF2/f9NiW tKvA== X-Gm-Message-State: AOAM532DY2IRtCtft5YT8C+diKKcdL+7QQeTTT5nh5NnC1HjTW1h9Q2l KmMUVn29TPDtPGJFd6PE5gg= X-Google-Smtp-Source: ABdhPJzHkyPlKfkamWjVagSZDYcuAe6tkz2hCu91pgFkTiYLa1dUV2thk5CA4SqwCpP9atHlIFXVNQ== X-Received: by 2002:a1c:b6c4:: with SMTP id g187mr8035495wmf.149.1597239072753; Wed, 12 Aug 2020 06:31:12 -0700 (PDT) Received: from pi3 ([194.230.155.117]) by smtp.googlemail.com with ESMTPSA id t13sm4154509wru.65.2020.08.12.06.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 06:31:12 -0700 (PDT) Date: Wed, 12 Aug 2020 15:31:09 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: Arnd Bergmann , Stephen Boyd , Alexandre Torgue , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Tomasz Figa , Will Deacon , Wim Van Sebroeck , Linux ARM , linux-clk , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-stm32@st-md-mailman.stormreply.com, LINUXWATCHDOG , patches@opensource.cirrus.com, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Message-ID: <20200812133109.GA15697@pi3> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Aug 12, 2020 at 03:11:41PM +0200, Sylwester Nawrocki wrote: > On 12.08.2020 13:28, Arnd Bergmann wrote: > > On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki > > wrote: > >> On 12.08.2020 11:14, Arnd Bergmann wrote: > >>> > >>> It seems there have never been any callers and the entire file > >>> can just be removed, with the rest of that platform_data header > >>> file moved to drivers/media/platform/s3c-camif/. > >> > >> Yes, it seems that patch never made it to mainline: > >> https://protect2.fireeye.com/v1/url?k=abe5f73a-f6293cfe-abe47c75-0cc47a314e9a-7fafe832d055d852&q=1&e=2596ffb6-c4cb-492a-8c6f-a0e261567842&u=https%3A%2F%2Fgit.linuxtv.org%2Fsnawrocki%2Fmedia.git%2Fcommit%2F%3Fh%3Dtesting%2Fs3c-camif%26id%3D355cbf835aff2aabf78390931cbbaa608af77967 > > > > I suppose it would still apply if anyone was interested, but I see your > > point. > > > >> I doubt there are still users of camera on the s3c2440 boards > >> with current mainline kernels, if any at all, there are much > >> better HW alternatives right now. > > > > I see two board files (and no DT) instantiate the camif device: > > NexVision Nexcoder 2440 and the FriendlyARM mini2440. > > > > Can you say whether the camif on those would actually work > > at all without your patch? If not, we know that there are no > > users of that driver and could either drop it completely or move > > it to staging for a release or two. > > Without additional patches the camif will not work, the driver > needs an instance of struct s3c_camif_plat_data which specifies > what image sensor is attached. > > I think we can drop the driver, together with the s3c_camif_device > platform device definitions. It can always be added again if anyone > ever needs it or converts the platform to DT. Since the header was in /include/media I assumed there might be some user-space tools using it. But if it is not the case, I'll drop the code then. > IMO all non-DT code in arch/arm/mach-s3c24xx is a candidate for > removal, it just adds to the maintenance effort and I seriously > doubt there are now any users of it. That is quite tricky... I really do not know whether there are any real world users of S3C24xx and S3C64xx platforms. Evalkits are mostly not available for buying so I do not expect new designs. However still existing ones might be somewhere... Few years ago, back in Samsung, I mentioned removing them. That time I think Marek or you Sylwester, said that there are industrial applications using S3C24xx. I believe, why not. The trouble is - how to find such users? How to get in touch for testing or at least for bug reports if something is broken? Or even more important - is it worth to spend effort and time on this? If there is no single production system using recent Linux kernel, the answer should be negative... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C59EC433DF for ; Wed, 12 Aug 2020 13:32:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A953204FD for ; Wed, 12 Aug 2020 13:32:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vTcj+q2y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A953204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sAl+H4dUOhJ0sffscoP6L1pyTA1pi76geLrx9ifcCtc=; b=vTcj+q2y2UMS0xlziuMiAm/eD ziF3J6O2KUwsKlwyokXjbOLfP5cwrC+eqTmQLl567s8Yh6x5WuMJ0lrY5pvxEDWG5fK/umWpgq7a3 iNHP+75YULySgmxh8tDDNIAoUNHrSm3AaKEYJX2Z/rU1SPOe0GcfvEs0GVY1Pjw4SjiJfRJofbQHP rf15adimEoCEjPs0WJlcZjtdNCck/Dp3CJM4dt5lTwc3f0V0wJj2rAgLUwyqzzXQUhQBrOKb40xbY t+2Wi43QBi6Z/3P1/IZ2XS1ngdxMtQKzYQPS5dMW2EZ7nqKzOxuuxrh5lLwsEVhqiEdRD4OAfKyJD U3yOA/DvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5qqa-0004Hn-Us; Wed, 12 Aug 2020 13:31:16 +0000 Received: from mail-wm1-f68.google.com ([209.85.128.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5qqY-0004Gd-77 for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 13:31:15 +0000 Received: by mail-wm1-f68.google.com with SMTP id f18so4257084wmc.0 for ; Wed, 12 Aug 2020 06:31:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2HXl4QZEkZ4XHgTE5pAfXdvAM2LC9rDIm1qQF4lI0C0=; b=ZE6+VLc6Puq183A5nhRKQGM8xzk5T1TgQHLw5tFJ1cLU8q6RcEPvQO33TAfa4OnPlS XM5puH4XvpMcVvN8BWLA8LiNmZQthtnfWcUJg/dct9BbaCvgFBwkcxpvGRDHgXH9PIAH 7fcFlaV07h7GXO8ZiYaaj89n9RKrAtxCicYfIs1fZZEnFqmyOJ+3pgTH0QN1FQB9EAHQ 8v/DQO2wObJRoarDtGe4aaq+sN2rQYJatXNf5GC0zXgVSsBU6iqc39+urF/a90rU2p2X /hjJs+DX5ZknfH1fe7UYHwje+njIl5hsyr8JTHKzCORFZYywi7FL88l001bacZL2EAv7 mulA== X-Gm-Message-State: AOAM533MRxnJLGp+DYUEJNnIm8m5pd65prtuOMxyfRVxhDV5kdNAE9e4 noAfpYhNwiypgXWNjI4ledo= X-Google-Smtp-Source: ABdhPJzHkyPlKfkamWjVagSZDYcuAe6tkz2hCu91pgFkTiYLa1dUV2thk5CA4SqwCpP9atHlIFXVNQ== X-Received: by 2002:a1c:b6c4:: with SMTP id g187mr8035495wmf.149.1597239072753; Wed, 12 Aug 2020 06:31:12 -0700 (PDT) Received: from pi3 ([194.230.155.117]) by smtp.googlemail.com with ESMTPSA id t13sm4154509wru.65.2020.08.12.06.31.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 06:31:12 -0700 (PDT) Date: Wed, 12 Aug 2020 15:31:09 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Message-ID: <20200812133109.GA15697@pi3> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_093114_268075_6F8023D2 X-CRM114-Status: GOOD ( 34.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Tomasz Figa , Will Deacon , linux-clk , LINUXWATCHDOG , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Sylwester Nawrocki , Cedric Roux , Russell King , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Marek Szyprowski , Guenter Roeck , Sergio Prado , Alexandre Torgue , Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , Linux ARM , Stephen Boyd , patches@opensource.cirrus.com, Kyungmin Park , Maxime Coquelin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2020 at 03:11:41PM +0200, Sylwester Nawrocki wrote: > On 12.08.2020 13:28, Arnd Bergmann wrote: > > On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki > > wrote: > >> On 12.08.2020 11:14, Arnd Bergmann wrote: > >>> > >>> It seems there have never been any callers and the entire file > >>> can just be removed, with the rest of that platform_data header > >>> file moved to drivers/media/platform/s3c-camif/. > >> > >> Yes, it seems that patch never made it to mainline: > >> https://protect2.fireeye.com/v1/url?k=abe5f73a-f6293cfe-abe47c75-0cc47a314e9a-7fafe832d055d852&q=1&e=2596ffb6-c4cb-492a-8c6f-a0e261567842&u=https%3A%2F%2Fgit.linuxtv.org%2Fsnawrocki%2Fmedia.git%2Fcommit%2F%3Fh%3Dtesting%2Fs3c-camif%26id%3D355cbf835aff2aabf78390931cbbaa608af77967 > > > > I suppose it would still apply if anyone was interested, but I see your > > point. > > > >> I doubt there are still users of camera on the s3c2440 boards > >> with current mainline kernels, if any at all, there are much > >> better HW alternatives right now. > > > > I see two board files (and no DT) instantiate the camif device: > > NexVision Nexcoder 2440 and the FriendlyARM mini2440. > > > > Can you say whether the camif on those would actually work > > at all without your patch? If not, we know that there are no > > users of that driver and could either drop it completely or move > > it to staging for a release or two. > > Without additional patches the camif will not work, the driver > needs an instance of struct s3c_camif_plat_data which specifies > what image sensor is attached. > > I think we can drop the driver, together with the s3c_camif_device > platform device definitions. It can always be added again if anyone > ever needs it or converts the platform to DT. Since the header was in /include/media I assumed there might be some user-space tools using it. But if it is not the case, I'll drop the code then. > IMO all non-DT code in arch/arm/mach-s3c24xx is a candidate for > removal, it just adds to the maintenance effort and I seriously > doubt there are now any users of it. That is quite tricky... I really do not know whether there are any real world users of S3C24xx and S3C64xx platforms. Evalkits are mostly not available for buying so I do not expect new designs. However still existing ones might be somewhere... Few years ago, back in Samsung, I mentioned removing them. That time I think Marek or you Sylwester, said that there are industrial applications using S3C24xx. I believe, why not. The trouble is - how to find such users? How to get in touch for testing or at least for bug reports if something is broken? Or even more important - is it worth to spend effort and time on this? If there is no single production system using recent Linux kernel, the answer should be negative... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel