From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AF3C433E3 for ; Wed, 12 Aug 2020 17:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2604320774 for ; Wed, 12 Aug 2020 17:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597252416; bh=yN10QFCVTqCQQlDhe9eJqyfRsxUvQug643hyfRN0cAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zthr8mhWEgpBq/YTNiCMJflp72KgPTmEvbQl99kKiXFeWTPBe+bdQX3bxq7sd2A8q zh1y5xaPVveLUb9O2hNHNBXLsDOpa2ds9Py+0LRBmVKVfrG3lvchHnS5NrSHtyTM3V NrSTM0GPq2LzR2v7xe985/vHyrrrhoGbTgD69i/I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbgHLRNf (ORCPT ); Wed, 12 Aug 2020 13:13:35 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33050 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgHLRNf (ORCPT ); Wed, 12 Aug 2020 13:13:35 -0400 Received: by mail-ed1-f66.google.com with SMTP id v22so2123870edy.0; Wed, 12 Aug 2020 10:13:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MT1HlMJVel4NfjLeoguo3S82lKmyadBedQuGtY3rkqk=; b=TfnCt8i46ssK+my+himX+2+Tux9PbfF5q6UvtbkAYYfII09bJB39WAz3TRXJ2D17au oT769zYqfbgbDLRFpa1Sh1/qY0Ni3xqTG5ipCP2oaWR1qftCOCCTAE9BMBfvQgOQAUpo Z4MAk5drl2VVDv6EH53M91CZ4J7jMhsd6IdXC0C8mcvJtsQ30P3UGLvoft97c2zsQknM rBfLddvN/XjTeQxOpogTtQflQZBpAmKeODc6y/mROOkwg98R65FFcfLpFeo+J9NHGPh7 irtqtqhNqwBg4Yo+xeSMvYXGa2/fpbFOc2cgzpr6s1a2TrrmQM8QQ9w4vWfCyz7molfv dJng== X-Gm-Message-State: AOAM5318bYz8jZQ2v+LXzBl1EAv66vj7curb0EddonzJ5hXtFVYAoYOC OvVfdUOdtIpNO1NwhSPQezQq3Dbivgg= X-Google-Smtp-Source: ABdhPJxHwROrd0TssNGyu5e5q3y0vfIOw6f27KQllbOmg3rLagqeBRyVqwp6k+Jy2UBlAMcA2OF4Tw== X-Received: by 2002:a05:6402:c84:: with SMTP id cm4mr920950edb.20.1597252412911; Wed, 12 Aug 2020 10:13:32 -0700 (PDT) Received: from kozik-lap ([194.230.155.117]) by smtp.googlemail.com with ESMTPSA id b20sm1821329eds.7.2020.08.12.10.13.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Aug 2020 10:13:32 -0700 (PDT) Date: Wed, 12 Aug 2020 19:13:29 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: Arnd Bergmann , Stephen Boyd , Alexandre Torgue , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Tomasz Figa , Will Deacon , Wim Van Sebroeck , Linux ARM , linux-clk , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-stm32@st-md-mailman.stormreply.com, LINUXWATCHDOG , patches@opensource.cirrus.com, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Message-ID: <20200812171329.GA3420@kozik-lap> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> <20200812133109.GA15697@pi3> <828b3dd5-31f0-0414-e6ea-7629b063e8ce@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <828b3dd5-31f0-0414-e6ea-7629b063e8ce@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Aug 12, 2020 at 05:58:52PM +0200, Sylwester Nawrocki wrote: > On 12.08.2020 15:31, Krzysztof Kozlowski wrote: > > On Wed, Aug 12, 2020 at 03:11:41PM +0200, Sylwester Nawrocki wrote: > >> On 12.08.2020 13:28, Arnd Bergmann wrote: > >>> On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki > >>> wrote: > >>>> On 12.08.2020 11:14, Arnd Bergmann wrote: > > >>> I see two board files (and no DT) instantiate the camif device: > >>> NexVision Nexcoder 2440 and the FriendlyARM mini2440. > >>> > >>> Can you say whether the camif on those would actually work > >>> at all without your patch? If not, we know that there are no > >>> users of that driver and could either drop it completely or move > >>> it to staging for a release or two. > >> > >> Without additional patches the camif will not work, the driver > >> needs an instance of struct s3c_camif_plat_data which specifies > >> what image sensor is attached. > >> > >> I think we can drop the driver, together with the s3c_camif_device > >> platform device definitions. It can always be added again if anyone > >> ever needs it or converts the platform to DT. > > > > Since the header was in /include/media I assumed there might be some > > user-space tools using it. But if it is not the case, I'll drop the code > > then. > > That's a kernel internal header, only for board files, it should really > have been added to include/linux/platform_data. > > >> IMO all non-DT code in arch/arm/mach-s3c24xx is a candidate for > >> removal, it just adds to the maintenance effort and I seriously > >> doubt there are now any users of it. > > > > That is quite tricky... I really do not know whether there are any real > > world users of S3C24xx and S3C64xx platforms. Evalkits are mostly not > > available for buying so I do not expect new designs. However still > > existing ones might be somewhere... Few years ago, back in Samsung, I > > mentioned removing them. That time I think Marek or you Sylwester, said > > that there are industrial applications using S3C24xx. I believe, why > > not. The trouble is - how to find such users? How to get in touch for > > testing or at least for bug reports if something is broken? > > I believe if there any such applications of the S3C24XX SoCs still existing > somewhere their long term support doesn't include updating to new kernels. > I used to keep a running S3C2440 SoC based board just for the purpose of > testing patches touching the common code, but I stopped it, I think it is > not worth to waste time and health on it any more. For example support for > the OSELAS.BSP-Pengutronix-Mini2440 BSP I used for tests ended 5 years ago > [1]. > > > Or even more important - is it worth to spend effort and time on this? > > If there is no single production system using recent Linux kernel, the > > answer should be negative... > > I suspect nobody cares about that code (non-DT s3c24xx) any more for other > than sentimental reasons. I'll start then with S3C camif driver. :) I guess drivers/media/platform/s3c-camif/ still should be left? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E4F9C433DF for ; Wed, 12 Aug 2020 17:14:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 370D02076C for ; Wed, 12 Aug 2020 17:14:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uErtZEGP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 370D02076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ruv4vNwNfliyiTuOfqbKQBEvyz2lIyb8vbqEgh1U9fU=; b=uErtZEGPyvhT+SiI3D2zvNP6C imU8qkoZ9M+zLKFyLiq/kFJ3kVhcj9iv4/GyTrDOhEjMKhECVe5T8qK0aUmYaPXUDz1Q7hFVj53w3 anRK0QKEqyGC5ityLx+TE/MbD+Dtr/H2KhyQFA/CcRUzwbwA+Ku0Ht7W4OROFsaza4YnBa7xI9olJ gGw+3VzoPCf1Reg7pu3tnaznQoZXKbJUWUfuNxveNlSaWJ9RwlCwPL6jBDg+2G4absonnOfs26Asx GAcWr9GFakcw8pJQDhqDNQ4BQmo4TBHRzv7q9unqeK8a/7Dy5nOQdZl6rhHCKA11Bn1Tk4xSIUe2Y zquPOhd/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5uJl-0006wF-1Q; Wed, 12 Aug 2020 17:13:37 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5uJi-0006vn-Dw for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 17:13:35 +0000 Received: by mail-ed1-f68.google.com with SMTP id v22so2123873edy.0 for ; Wed, 12 Aug 2020 10:13:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MT1HlMJVel4NfjLeoguo3S82lKmyadBedQuGtY3rkqk=; b=gWaHecBuFVq9vitwFmOWpNBOgXJefGHdxs71YHXiKUPxjGNc038187hvXUp+DEvjr5 oqIUpPLjCVuGyFgBEadcTSCN+fGRBmkHymU7GVv/mQ8Y0w3i7FU+Xqh97q42GbynL+tf Q56xDYRp2yFmaRUj2LxZaAngVah5y66buvMVEZ2SJDVSW25gKWtSSDY26XuzzrvBcWuj uugicFAGudQidgKIvBNq/HPm32faGyQdyX1HMh+TCHkNkrkoDvG534o0QjaGb4uoyJ1X 5qa3Na1dsDBYN1/r8i9mTfItbfKMDm95L00eEL/nS2beNEmKlVpdsBvOX+2e+mzLYSgd B4Wg== X-Gm-Message-State: AOAM533fP3cNiOWUOJhi3O+c1EOeeUnldjLhDOaFDHPYokh3R7KiEdP1 kI/6+8UHNrIbu/2LliPa5jA= X-Google-Smtp-Source: ABdhPJxHwROrd0TssNGyu5e5q3y0vfIOw6f27KQllbOmg3rLagqeBRyVqwp6k+Jy2UBlAMcA2OF4Tw== X-Received: by 2002:a05:6402:c84:: with SMTP id cm4mr920950edb.20.1597252412911; Wed, 12 Aug 2020 10:13:32 -0700 (PDT) Received: from kozik-lap ([194.230.155.117]) by smtp.googlemail.com with ESMTPSA id b20sm1821329eds.7.2020.08.12.10.13.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Aug 2020 10:13:32 -0700 (PDT) Date: Wed, 12 Aug 2020 19:13:29 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration Message-ID: <20200812171329.GA3420@kozik-lap> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> <6ccf14a9-802f-25b8-494d-e957cafd073d@samsung.com> <20200812133109.GA15697@pi3> <828b3dd5-31f0-0414-e6ea-7629b063e8ce@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <828b3dd5-31f0-0414-e6ea-7629b063e8ce@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_131334_482997_2F0DBBFC X-CRM114-Status: GOOD ( 39.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Tomasz Figa , Will Deacon , linux-clk , LINUXWATCHDOG , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Sylwester Nawrocki , Cedric Roux , Russell King , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Marek Szyprowski , Guenter Roeck , Sergio Prado , Alexandre Torgue , Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , Linux ARM , Stephen Boyd , patches@opensource.cirrus.com, Kyungmin Park , Maxime Coquelin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2020 at 05:58:52PM +0200, Sylwester Nawrocki wrote: > On 12.08.2020 15:31, Krzysztof Kozlowski wrote: > > On Wed, Aug 12, 2020 at 03:11:41PM +0200, Sylwester Nawrocki wrote: > >> On 12.08.2020 13:28, Arnd Bergmann wrote: > >>> On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki > >>> wrote: > >>>> On 12.08.2020 11:14, Arnd Bergmann wrote: > > >>> I see two board files (and no DT) instantiate the camif device: > >>> NexVision Nexcoder 2440 and the FriendlyARM mini2440. > >>> > >>> Can you say whether the camif on those would actually work > >>> at all without your patch? If not, we know that there are no > >>> users of that driver and could either drop it completely or move > >>> it to staging for a release or two. > >> > >> Without additional patches the camif will not work, the driver > >> needs an instance of struct s3c_camif_plat_data which specifies > >> what image sensor is attached. > >> > >> I think we can drop the driver, together with the s3c_camif_device > >> platform device definitions. It can always be added again if anyone > >> ever needs it or converts the platform to DT. > > > > Since the header was in /include/media I assumed there might be some > > user-space tools using it. But if it is not the case, I'll drop the code > > then. > > That's a kernel internal header, only for board files, it should really > have been added to include/linux/platform_data. > > >> IMO all non-DT code in arch/arm/mach-s3c24xx is a candidate for > >> removal, it just adds to the maintenance effort and I seriously > >> doubt there are now any users of it. > > > > That is quite tricky... I really do not know whether there are any real > > world users of S3C24xx and S3C64xx platforms. Evalkits are mostly not > > available for buying so I do not expect new designs. However still > > existing ones might be somewhere... Few years ago, back in Samsung, I > > mentioned removing them. That time I think Marek or you Sylwester, said > > that there are industrial applications using S3C24xx. I believe, why > > not. The trouble is - how to find such users? How to get in touch for > > testing or at least for bug reports if something is broken? > > I believe if there any such applications of the S3C24XX SoCs still existing > somewhere their long term support doesn't include updating to new kernels. > I used to keep a running S3C2440 SoC based board just for the purpose of > testing patches touching the common code, but I stopped it, I think it is > not worth to waste time and health on it any more. For example support for > the OSELAS.BSP-Pengutronix-Mini2440 BSP I used for tests ended 5 years ago > [1]. > > > Or even more important - is it worth to spend effort and time on this? > > If there is no single production system using recent Linux kernel, the > > answer should be negative... > > I suspect nobody cares about that code (non-DT s3c24xx) any more for other > than sentimental reasons. I'll start then with S3C camif driver. :) I guess drivers/media/platform/s3c-camif/ still should be left? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel