From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A75FAC433E0 for ; Wed, 12 Aug 2020 17:56:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DEB72078B for ; Wed, 12 Aug 2020 17:56:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HMtgnh/I"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BF39rHON" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DEB72078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9j2YLUnfUNKNCZJ64yQm/eStu7Yb5QYrekQB/y4+Uso=; b=HMtgnh/ImQl/9i4ab6fgXOWuv HxQ40TEy20KnKILXGolIPzeqo3Di3YF+xy96AAmK31cxyvPa+apdR5q36bFhMaSRD3gak7qPuawUr 1ZLkx6kgEWKINcgWVbWCKFZxea1PBbfJ9haF8qAkP+a2duFkYw2ZZWKqMdvkxikyCZ6Wlox7zg/0s LZF+jiRK5TxDKPWdoKw1Od0TPrvchmAeY7RZBxsr2I6U4Zrq5zz4R/93lAS93SkxqMVcWeO9+pAxG AUs8eanBbmqdWIc5pjEy4uY/mXFgF/duYRbXL7/BTxxkIdIhyZggiS4Xl0gyqYale6LAi/BUQJ0It ASzwyeNrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5uxl-0002V2-JG; Wed, 12 Aug 2020 17:54:57 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5uxi-0002UL-SV for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 17:54:56 +0000 Received: by mail-pf1-x441.google.com with SMTP id u20so1409639pfn.0 for ; Wed, 12 Aug 2020 10:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bf0cTEH6FjREpNjxbk7E8Q2D/x1pqRE3xUlAU5RcImk=; b=BF39rHONh2MsQiKighF/nPKlsg9C/Mpg6J8tpxNUorr1rMQ2rNHPB3W6knYNYIe373 PjE6uAmPGweA5/hzep5TmHzKkY/3MX4629nyltrwhvXmutRRCs7KEbiPFsJE426HnRA1 kko3ki5skmJ9ak0Qe2jBllBVyAbD3HvHCaQ1i/8IIqf0gH05CilQBxs3gq4Sf3JyBx5P nBP7mWdbigzibV08jJW8jx6B66yLnVbkLHNRoIMafAGL/1Y3yULWv+tBhK3Wy/fuP3cV ogdVmz4ob27e/2s8lY2hbcNKwPowvu7+oAjoumFoi+hNfizV/MdVqaxaPeiLrZp+srO8 92+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bf0cTEH6FjREpNjxbk7E8Q2D/x1pqRE3xUlAU5RcImk=; b=qCjyl5O5/kqGkOBRK+3ABm1/JFgh+84IdJo7SQ5d+QW5bUUG08zbyxyucFAIuYFVXp d2EFODia4+ddlq12hFEv8Il/QVceitnEOUzUV6+XT70V30C8VITbFCYTMPJQ/Kpohbyf EHtKzbDCHV/0RKoNflpaXRmON3crSZfXYJX9Aq7/uN03co3uIZI8Lt2EJHx3pKIXiswK vxBY2jrWl8nbbHv9e9Rjwm7dyxwdOQkqUmEjHjooae/3llLnITeSIOzaxunITh5EagHn KLwCtdbSz0qpAxxKEFWolk5o4k3Qb4mjFjQhxxN7IA+KLgcxfv7dxGWyvZpwz3Bd9QA0 y9cg== X-Gm-Message-State: AOAM5329yaHuIJN+6vVyrSa3BBefgPwsPYntZSxdCFOCrJg3qIIgq2Ti HoJFp43JrCkxmZkR8y9kfAeZew== X-Google-Smtp-Source: ABdhPJxO0BKH1+Bwz2GURdKDs8Y23CCXfrL3O1zf16dYl29ltpIaehguu4xGGUtLXfkTvXWh+li21g== X-Received: by 2002:a63:597:: with SMTP id 145mr259681pgf.119.1597254892826; Wed, 12 Aug 2020 10:54:52 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id g129sm3099288pfb.33.2020.08.12.10.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 10:54:52 -0700 (PDT) Date: Wed, 12 Aug 2020 11:54:49 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules Message-ID: <20200812175449.GC3393195@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-4-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-4-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_135455_267292_53401097 X-CRM114-Status: GOOD ( 20.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:32PM +0800, Tingwei Zhang wrote: > From: Kim Phillips > > Checking for ifdef CONFIG_x fails if CONFIG_x=m. Use IS_ENABLED > that is true for both built-ins and modules, instead. Required > when building coresight components as modules. > > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: Randy Dunlap > Cc: Suzuki K Poulose > Cc: Greg Kroah-Hartman > Cc: Russell King > Signed-off-by: Kim Phillips > Signed-off-by: Tingwei Zhang > Reviewed-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm-perf.h | 2 +- > drivers/hwtracing/coresight/coresight-priv.h | 2 +- > include/linux/coresight.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) For patches 02 and 03: Reviewed-by: Mathieu Poirier > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.h b/drivers/hwtracing/coresight/coresight-etm-perf.h > index 015213abe00a..05f89723e282 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.h > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.h > @@ -57,7 +57,7 @@ struct etm_event_data { > struct list_head * __percpu *path; > }; > > -#ifdef CONFIG_CORESIGHT > +#if IS_ENABLED(CONFIG_CORESIGHT) > int etm_perf_symlink(struct coresight_device *csdev, bool link); > int etm_perf_add_symlink_sink(struct coresight_device *csdev); > void etm_perf_del_symlink_sink(struct coresight_device *csdev); > diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h > index f2dc625ea585..d801a2755432 100644 > --- a/drivers/hwtracing/coresight/coresight-priv.h > +++ b/drivers/hwtracing/coresight/coresight-priv.h > @@ -165,7 +165,7 @@ int coresight_make_links(struct coresight_device *orig, > void coresight_remove_links(struct coresight_device *orig, > struct coresight_connection *conn); > > -#ifdef CONFIG_CORESIGHT_SOURCE_ETM3X > +#if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM3X) > extern int etm_readl_cp14(u32 off, unsigned int *val); > extern int etm_writel_cp14(u32 off, u32 val); > #else > diff --git a/include/linux/coresight.h b/include/linux/coresight.h > index 58fffdecdbfd..3bb738f9a326 100644 > --- a/include/linux/coresight.h > +++ b/include/linux/coresight.h > @@ -324,7 +324,7 @@ struct coresight_ops { > const struct coresight_ops_ect *ect_ops; > }; > > -#ifdef CONFIG_CORESIGHT > +#if IS_ENABLED(CONFIG_CORESIGHT) > extern struct coresight_device * > coresight_register(struct coresight_desc *desc); > extern void coresight_unregister(struct coresight_device *csdev); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel