From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D03C433DF for ; Thu, 13 Aug 2020 00:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5B0320774 for ; Thu, 13 Aug 2020 00:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726685AbgHMA5J (ORCPT ); Wed, 12 Aug 2020 20:57:09 -0400 Received: from mga17.intel.com ([192.55.52.151]:22625 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbgHMA5G (ORCPT ); Wed, 12 Aug 2020 20:57:06 -0400 IronPort-SDR: k8QbWiKsX4f+Z0/SywXUlPlbIkIbvLKgA0y2iFCORx0ufmyVzDWFQAmcPEMrlYnGu6N951hblr xgc5V+fcG5UA== X-IronPort-AV: E=McAfee;i="6000,8403,9711"; a="134187941" X-IronPort-AV: E=Sophos;i="5.76,306,1592895600"; d="scan'208";a="134187941" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2020 17:57:05 -0700 IronPort-SDR: N8WknwYBhVYVYxyPM4dGFRkynYOOKCseddCByMvJs370fQ002BU4h9YH+RYj5TVi6MDvyAvz5D JHy9qYi40Qag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,306,1592895600"; d="scan'208";a="308897167" Received: from lkp-server01.sh.intel.com (HELO 7f1ebb311643) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 12 Aug 2020 17:57:04 -0700 Received: from kbuild by 7f1ebb311643 with local (Exim 4.92) (envelope-from ) id 1k61YF-0000Lc-CE; Thu, 13 Aug 2020 00:57:03 +0000 Date: Thu, 13 Aug 2020 08:56:14 +0800 From: kernel test robot To: Denis Efremov Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Julia Lawall , Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Message-ID: <20200813005614.GA85482@8851f5375e5a> References: <202008130840.TWLDLwLA%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008130840.TWLDLwLA%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/hid/hid-sony.c:611:8-16: WARNING: use scnprintf or sprintf drivers/hid/hid-sony.c:648:8-16: WARNING: use scnprintf or sprintf drivers/hid/hid-sony.c:660:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7c2a69f610e64c8dec6a06a66e721f4ce1dd783a commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script Please take the patch only if it's a positive warning. Thanks! hid-sony.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -608,7 +608,7 @@ static ssize_t ds4_show_poll_interval(st struct hid_device *hdev = to_hid_device(dev); struct sony_sc *sc = hid_get_drvdata(hdev); - return snprintf(buf, PAGE_SIZE, "%i\n", sc->ds4_bt_poll_interval); + return scnprintf(buf, PAGE_SIZE, "%i\n", sc->ds4_bt_poll_interval); } static ssize_t ds4_store_poll_interval(struct device *dev, @@ -645,7 +645,7 @@ static ssize_t sony_show_firmware_versio struct hid_device *hdev = to_hid_device(dev); struct sony_sc *sc = hid_get_drvdata(hdev); - return snprintf(buf, PAGE_SIZE, "0x%04x\n", sc->fw_version); + return scnprintf(buf, PAGE_SIZE, "0x%04x\n", sc->fw_version); } static DEVICE_ATTR(firmware_version, 0444, sony_show_firmware_version, NULL); @@ -657,7 +657,7 @@ static ssize_t sony_show_hardware_versio struct hid_device *hdev = to_hid_device(dev); struct sony_sc *sc = hid_get_drvdata(hdev); - return snprintf(buf, PAGE_SIZE, "0x%04x\n", sc->hw_version); + return scnprintf(buf, PAGE_SIZE, "0x%04x\n", sc->hw_version); } static DEVICE_ATTR(hardware_version, 0444, sony_show_hardware_version, NULL); From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4122074128803732862==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Date: Thu, 13 Aug 2020 08:56:14 +0800 Message-ID: <20200813005614.GA85482@8851f5375e5a> In-Reply-To: <202008130840.TWLDLwLA%lkp@intel.com> List-Id: --===============4122074128803732862== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/hid/hid-sony.c:611:8-16: WARNING: use scnprintf or sprintf drivers/hid/hid-sony.c:648:8-16: WARNING: use scnprintf or sprintf drivers/hid/hid-sony.c:660:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 7c2a69f610e64c8dec6a06a66e721f4ce1dd783a commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add devic= e_attr_show script Please take the patch only if it's a positive warning. Thanks! hid-sony.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -608,7 +608,7 @@ static ssize_t ds4_show_poll_interval(st struct hid_device *hdev =3D to_hid_device(dev); struct sony_sc *sc =3D hid_get_drvdata(hdev); = - return snprintf(buf, PAGE_SIZE, "%i\n", sc->ds4_bt_poll_interval); + return scnprintf(buf, PAGE_SIZE, "%i\n", sc->ds4_bt_poll_interval); } = static ssize_t ds4_store_poll_interval(struct device *dev, @@ -645,7 +645,7 @@ static ssize_t sony_show_firmware_versio struct hid_device *hdev =3D to_hid_device(dev); struct sony_sc *sc =3D hid_get_drvdata(hdev); = - return snprintf(buf, PAGE_SIZE, "0x%04x\n", sc->fw_version); + return scnprintf(buf, PAGE_SIZE, "0x%04x\n", sc->fw_version); } = static DEVICE_ATTR(firmware_version, 0444, sony_show_firmware_version, NUL= L); @@ -657,7 +657,7 @@ static ssize_t sony_show_hardware_versio struct hid_device *hdev =3D to_hid_device(dev); struct sony_sc *sc =3D hid_get_drvdata(hdev); = - return snprintf(buf, PAGE_SIZE, "0x%04x\n", sc->hw_version); + return scnprintf(buf, PAGE_SIZE, "0x%04x\n", sc->hw_version); } = static DEVICE_ATTR(hardware_version, 0444, sony_show_hardware_version, NUL= L); --===============4122074128803732862==--