From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 285CCC433E1 for ; Thu, 13 Aug 2020 18:47:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97E7E20829 for ; Thu, 13 Aug 2020 18:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oC4e+RuB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gCXB6ZSz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97E7E20829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 27F9E1616; Thu, 13 Aug 2020 20:46:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 27F9E1616 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597344425; bh=OiN7Pp8DNtX6sTqjHsbaKXAHtf76CFcD9i4VxAY00ew=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oC4e+RuB/BgOzsQc/Ajuie/f+kvaEpDQXuaZ1lMHDJnK+MHTsms+j2WYXbYsqLFx4 KPX09PbNs7ODLrj58HqlI0VjCeqsZk5zZRFIyv81ijeZDwEDIsJTk611VPXlQi4jnv HOqIZx2dfzabO2pA08WT8LmQBSjk+xeDF5Pqhego= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AED6BF8014C; Thu, 13 Aug 2020 20:46:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D569DF8015B; Thu, 13 Aug 2020 20:46:13 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4DE3EF80100 for ; Thu, 13 Aug 2020 20:46:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4DE3EF80100 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gCXB6ZSz" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 148AB20774; Thu, 13 Aug 2020 18:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597344368; bh=OiN7Pp8DNtX6sTqjHsbaKXAHtf76CFcD9i4VxAY00ew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gCXB6ZSzvQA1FlAjd6IhAjVjb7RE3kHFCNVY2GDiIdcWdTxpznG9dOav8ad5kvp/T WhErbwz/wYB08yjuepnorfJDIcLc3OtsCKpO+UNcjahVeUS8mA+G+JBUmT5oPwblcr mZpGI3c9uLnsDlQF3+mrSRmalFmSshHQQQIsvg44= Date: Thu, 13 Aug 2020 19:45:41 +0100 From: Mark Brown To: Pierre-Louis Bossart Subject: Re: [PATCH 5/5] ASoC: Intel: sof_sdw: clarify operator precedence Message-ID: <20200813184541.GD5541@sirena.org.uk> References: <20200813175839.59422-1-pierre-louis.bossart@linux.intel.com> <20200813175839.59422-6-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kvUQC+jR9YzypDnK" Content-Disposition: inline In-Reply-To: <20200813175839.59422-6-pierre-louis.bossart@linux.intel.com> X-Cookie: Your mileage may vary. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: tiwai@suse.de, alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --kvUQC+jR9YzypDnK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 13, 2020 at 12:58:39PM -0500, Pierre-Louis Bossart wrote: > - hdmi_num = sof_sdw_quirk & SOF_SDW_TGL_HDMI ? > + hdmi_num = (sof_sdw_quirk & SOF_SDW_TGL_HDMI) ? > SOF_TGL_HDMI_COUNT : SOF_PRE_TGL_HDMI_COUNT; Or better yet, just don't abuse the ternery operator like this and write normal conditional statements. --kvUQC+jR9YzypDnK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl81ilQACgkQJNaLcl1U h9AZqQf8CC20244CcDfeGg/SbvVvXGxO4ze+aTJ0JV720298h35lmYEWLLLZKy+U 5Gi3WW1FmfVS49pd0HgmrABatojsT/pdfyvZHdMW1XYfqasT9zNt3PdqdRsA9ZkU f6CWt5cwV5e9n7f84E+LSeyYk6BENF26DZxaw03BV1Vs52kPbcRpn9fHVFpbPd54 q4LY98V9Xz/imujOQiRy88axqtUBc2LMER7h3qwqjeK4XW04XerZdVJMpsNUR9/K r+MDLZl6vIuGAFL056ZEcvdW2c4aBPuvZ3p+1CQ5tD88LNNtEdTYOXcOsr8vs+7k PucBzIFWbcj6IRS9LctL46jxcmAtNw== =jvtb -----END PGP SIGNATURE----- --kvUQC+jR9YzypDnK--