Re: [RFC PATCH 7/8] btrfs: Convert to fs_context

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4584 bytes --]

Hi Marcos,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on kdave/for-next]
[also build test WARNING on next-20200812]
[cannot apply to v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Marcos-Paulo-de-Souza/btrfs-convert-to-fscontext/20200813-012641
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: mips-randconfig-r031-20200813 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 62ef1cb2079123b86878e4bfed3c14db448f1373)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from fs/btrfs/super.c:31:
   In file included from fs/btrfs/delayed-inode.h:17:
   fs/btrfs/ctree.h:2292:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   size_t __const btrfs_get_num_csums(void);
          ^~~~~~~~
   In file included from fs/btrfs/super.c:47:
   fs/btrfs/sysfs.h:16:14: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   const char * const btrfs_feature_set_name(enum btrfs_feature_set set);
                ^~~~~~
>> fs/btrfs/super.c:2420:5: warning: no previous prototype for function 'btrfs_mount_root_fc' [-Wmissing-prototypes]
   int btrfs_mount_root_fc(struct fs_context *fc, unsigned int rdonly)
       ^
   fs/btrfs/super.c:2420:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int btrfs_mount_root_fc(struct fs_context *fc, unsigned int rdonly)
   ^
   static 
   fs/btrfs/super.c:3086:32: warning: unused variable 'btrfs_root_fs_type' [-Wunused-variable]
   static struct file_system_type btrfs_root_fs_type = {
                                  ^
   fs/btrfs/super.c:1508:12: warning: unused function 'btrfs_parse_device_options' [-Wunused-function]
   static int btrfs_parse_device_options(const char *options, fmode_t flags,
              ^
   fs/btrfs/super.c:1563:12: warning: unused function 'btrfs_parse_subvol_options' [-Wunused-function]
   static int btrfs_parse_subvol_options(const char *options, char **subvol_name,
              ^
   fs/btrfs/super.c:2219:12: warning: unused function 'btrfs_set_super' [-Wunused-function]
   static int btrfs_set_super(struct super_block *s, void *data)
              ^
   7 warnings generated.

vim +/btrfs_mount_root_fc +2420 fs/btrfs/super.c

  2414	
  2415	/*
  2416	 * Duplicate the current fc and prepare for mounting the root.
  2417	 * btrfs_get_tree will be called recursively, but then will check for the
  2418	 * ctx->root being set and call btrfs_root_get_tree.
  2419	 */
> 2420	int btrfs_mount_root_fc(struct fs_context *fc, unsigned int rdonly)
  2421	{
  2422		struct btrfs_fs_context *ctx, *root_ctx;
  2423		struct fs_context *root_fc;
  2424		struct vfsmount *root_mnt;
  2425		int ret;
  2426	
  2427		root_fc = vfs_dup_fs_context(fc);
  2428		if (IS_ERR(root_fc))
  2429			return PTR_ERR(root_fc);
  2430	
  2431		root_fc->sb_flags &= ~SB_RDONLY;
  2432		root_fc->sb_flags |= rdonly | SB_NOSEC;
  2433		root_ctx = root_fc->fs_private;
  2434		root_ctx->root_mnt = NULL;
  2435		root_ctx->root = true;
  2436	
  2437		/*
  2438		 * fc_mount will call btrfs_get_tree again, and by checking ctx->root
  2439		 * being true it'll call btrfs_root_get_tree to avoid infinite recursion.
  2440		 */
  2441		root_mnt = fc_mount(root_fc);
  2442		if (IS_ERR(root_mnt)) {
  2443			ret = PTR_ERR(root_mnt);
  2444			goto error_fc;
  2445		}
  2446	
  2447		ctx = fc->fs_private;
  2448		ctx->root_mnt = root_mnt;
  2449		ret = 0;
  2450	
  2451	error_fc:
  2452		put_fs_context(root_fc);
  2453		return ret;
  2454	}
  2455	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30112 bytes --]