From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A479DC433E1 for ; Thu, 13 Aug 2020 23:46:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 654B4206DC for ; Thu, 13 Aug 2020 23:46:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ppuTngtc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Ehr87ESr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 654B4206DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lmAHKz6QnZ7+m0GXX/bq8dQDXpkJXSzyREA+gcPZzWk=; b=ppuTngtcSgykxi8809+Pfb8AO jS4Js6tK6j5c4aVppHdIjOxtjtIFFYfZ99E6tlThYiFGV4Vj2tguOHb/Yqw5Skdi+3Un2f4h3Woez kgrOcUr8f8JpFxJHQUmUbxwAmfzrK9HjHzO0dMyrOvMzr+4nRif4ibSM2Odxfgp1uixMeAVrAYQry sih66fuQ+Ow5n2wz2vEumtLdNbUHyJM/X+b4bsANOVfS8gPXCKbsij41NfLQXDK5kt6WVqICviPDv ipKV784uBxRJB7Ue/cGX3g5Rx3hnjR44b/LFVzp/iczhf+kpftKQ01DMdhbZF4f/zv/ARwTsVuqWV WvKn39PVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6Mtn-0002yJ-1c; Thu, 13 Aug 2020 23:44:43 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k6Mtj-0002xk-Rk for linux-arm-kernel@lists.infradead.org; Thu, 13 Aug 2020 23:44:41 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597362279; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=H7gXug+FqrPqMB2zI2Mvo60z4OtwcArBo/an6gPwcaA=; b=Ehr87ESrXciGKRApuFABnEoMJMpD2AbnQpUuTufkv6B7QP07GUxSU5/k1j2Qc9cGvk7kdWa+ Byh07X52XWMU1fNlMmdWQaW3koIC8Z/mdIjg4dHn6j26FZJ58JafdI17p6tGbTGFMV+RxpR/ jKHnuwrRBgpts02yDbSMQc2y4bE= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5f35d0652f4952907d854736 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 13 Aug 2020 23:44:37 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 81A08C433C6; Thu, 13 Aug 2020 23:44:36 +0000 (UTC) Received: from codeaurora.org (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tingwei) by smtp.codeaurora.org (Postfix) with ESMTPSA id 19A78C433C6; Thu, 13 Aug 2020 23:44:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 19A78C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=tingweiz@codeaurora.org Date: Fri, 14 Aug 2020 07:44:22 +0800 From: Tingwei Zhang To: Mathieu Poirier Subject: Re: [PATCH v8 09/24] coresight: etm3x: allow etm3x to be built as a module Message-ID: <20200813234422.GA23242@codeaurora.org> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-10-tingwei@codeaurora.org> <375f5a93-aa4e-14c0-33d6-af4894375986@arm.com> <20200813105654.GA6742@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200813_194440_020563_BAA28875 X-CRM114-Status: GOOD ( 34.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni , Sai Prakash Ranjan , Kim Phillips , Suzuki K Poulose , Alexander Shishkin , Greg KH , Coresight ML , Mao Jinlong , Mian Yousaf Kaukab , Russell King , Randy Dunlap , Tingwei Zhang , Leo Yan , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 13, 2020 at 11:00:04AM -0600, Mathieu Poirier wrote: > On Thu, 13 Aug 2020 at 04:57, Tingwei Zhang wrote: > > > > On Thu, Aug 13, 2020 at 05:47:22PM +0800, Suzuki K Poulose wrote: > > > On 08/07/2020 12:11 PM, Tingwei Zhang wrote: > > > >From: Kim Phillips > > > > > > > >Allow to build coresight-etm3x as a module, for ease of development. > > > > > > > >- Kconfig becomes a tristate, to allow =m > > > >- append -core to source file name to allow module to > > > > be called coresight-etm3x by the Makefile > > > >- add an etm_remove function, for module unload > > > >- add a MODULE_DEVICE_TABLE for autoloading on boot > > > > > > > >Cc: Mathieu Poirier > > > >Cc: Leo Yan > > > >Cc: Alexander Shishkin > > > >Cc: Randy Dunlap > > > >Cc: Suzuki K Poulose > > > >Cc: Greg Kroah-Hartman > > > >Cc: Russell King > > > >Signed-off-by: Kim Phillips > > > >Signed-off-by: Tingwei Zhang > > > >Reviewed-by: Mike Leach > > > >--- > > > > drivers/hwtracing/coresight/Kconfig | 5 +++- > > > > drivers/hwtracing/coresight/Makefile | 3 ++- > > > > ...resight-etm3x.c => coresight-etm3x-core.c} | 27 ++++++++++++++++++- > > > > 3 files changed, 32 insertions(+), 3 deletions(-) > > > > rename drivers/hwtracing/coresight/{coresight-etm3x.c => > > > >coresight-etm3x-core.c} (97%) > > > > > > > >diff --git a/drivers/hwtracing/coresight/Kconfig > > > >b/drivers/hwtracing/coresight/Kconfig > > > >index 6433f835fc97..8fd9fd139cf3 100644 > > > >--- a/drivers/hwtracing/coresight/Kconfig > > > >+++ b/drivers/hwtracing/coresight/Kconfig > > > >@@ -65,7 +65,7 @@ config CORESIGHT_SINK_ETBV10 > > > > special enhancement or added features. > > > > > > > > config CORESIGHT_SOURCE_ETM3X > > > >- bool "CoreSight Embedded Trace Macrocell 3.x driver" > > > >+ tristate "CoreSight Embedded Trace Macrocell 3.x driver" > > > > depends on !ARM64 > > > > select CORESIGHT_LINKS_AND_SINKS > > > > help > > > >@@ -74,6 +74,9 @@ config CORESIGHT_SOURCE_ETM3X > > > > This is primarily useful for instruction level tracing. Depending > > > > the ETM version data tracing may also be available. > > > > > > > >+ To compile this driver as a module, choose M here: the > > > >+ module will be called coresight-etm3x. > > > >+ > > > > config CORESIGHT_SOURCE_ETM4X > > > > bool "CoreSight Embedded Trace Macrocell 4.x driver" > > > > depends on ARM64 > > > >diff --git a/drivers/hwtracing/coresight/Makefile > > > >b/drivers/hwtracing/coresight/Makefile > > > >index 19497d1d92bf..d619cfd0abd8 100644 > > > >--- a/drivers/hwtracing/coresight/Makefile > > > >+++ b/drivers/hwtracing/coresight/Makefile > > > >@@ -11,7 +11,8 @@ obj-$(CONFIG_CORESIGHT_SINK_TPIU) += coresight-tpiu.o > > > > obj-$(CONFIG_CORESIGHT_SINK_ETBV10) += coresight-etb10.o > > > > obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o \ > > > > coresight-replicator.o > > > >-obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > > > >coresight-etm-cp14.o \ > > > >+obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o > > > >+coresight-etm3x-y := coresight-etm3x-core.o coresight-etm-cp14.o \ > > > > coresight-etm3x-sysfs.o > > > > obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \ > > > > coresight-etm4x-sysfs.o > > > >diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c > > > >b/drivers/hwtracing/coresight/coresight-etm3x-core.c > > > >similarity index 97% > > > >rename from drivers/hwtracing/coresight/coresight-etm3x.c > > > >rename to drivers/hwtracing/coresight/coresight-etm3x-core.c > > > >index bf22dcfd3327..82b333c40006 100644 > > > >--- a/drivers/hwtracing/coresight/coresight-etm3x.c > > > >+++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c > > > >@@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev, const > > > >struct amba_id *id) > > > > return ret; > > > > } > > > > > > > >+static int __exit etm_remove(struct amba_device *adev) > > > >+{ > > > >+ struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev); > > > >+ > > > >+ etm_perf_symlink(drvdata->csdev, false); > > > >+ > > > >+ if (--etm_count == 0) { > > > >+ cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING); > > > >+ if (hp_online) > > > >+ cpuhp_remove_state_nocalls(hp_online); > > > >+ } > > > >+ > > > > > > As mentioned in the previous version, this needs fixing > > > similar to the etm4x to avoid races with etm_count. I understand > > > that it is an exisiting problem. But this set exposes it more > > > due to etm_remove() calls and is much more probable to hit it. > > > > > OK. I'll fix this. Can you help to review ETM4 fix? If that's fine, > > I'll make similar fix here. > > > > Unfortunately, I don't have any device with ETM3. Can anyone help > > to verify the function on ETM3? I'll really appreciate that. > > I'll take care of ETMv3. Please wait before sending a new revision > since I am still reviewing the current set. I will let you know when > I am done. > Thanks a lot, Mathieu. I'll wait for your comments. > > > > Thanks, > > Tingwei > > > > > > Suzuki > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel