All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Meelis Roos <mroos@linux.ee>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
	linux-parisc@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>,
	Abdul Haleem <abdhalee@linux.vnet.ibm.com>,
	Andy Lutomirski <luto@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Joerg Roedel <joro@8bytes.org>, Joerg Roedel <jroedel@suse.de>,
	Max Filippov <jcmvbkbc@gmail.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
	Stafford Horne <shorne@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Steven Rostedt <rostedt@goodmis.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: (bisected) parisc boot crash in post-5.8 git - pgalloc changes
Date: Sat, 15 Aug 2020 19:42:00 +0100	[thread overview]
Message-ID: <20200815184200.GA17456@casper.infradead.org> (raw)
In-Reply-To: <9f2b5ebd-e4a4-0fa1-6cd3-4b9f6892d1ad@linux.ee>

On Sat, Aug 15, 2020 at 09:35:05PM +0300, Meelis Roos wrote:
> > While 5.8.0 worked fine on my HP RP2470 (Gentoo with 10.2.0 kgcc), yesterdays dddcbc139e96 and todays a1d21081a60d crash on boot. I have started bisecting it.
> 
> And finished now. I included all CC-s and SOB-s from the commit to this mail - sorry if too broad.
> 
> 1355c31eeb7ea61a7f2f2937d17cd4e343a6b5af is the first bad commit

yes, I see the problem.

arch/parisc/include/asm/pgtable.h:#define PMD_ORDER     1 /* Number of pages per pmd */

-static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
-{
-       pmd_t *pmd = (pmd_t *)__get_free_pages(GFP_KERNEL, PMD_ORDER);

+       page = alloc_pages(gfp, 0);

So I think the quick fix is to restore the parisc pmd_alloc_one and define
__HAVE_ARCH_PMD_ALLOC_ONE.  I wasn't following this series too closely,
so I shan't propose a patch, but leave it up to Mike.  I'd probably miss
some subtlety.

  reply	other threads:[~2020-08-15 22:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 10:24 rp2470 boot crash in post-5.8 git Meelis Roos
2020-08-15 18:35 ` (bisected) parisc boot crash in post-5.8 git - pgalloc changes Meelis Roos
2020-08-15 18:42   ` Matthew Wilcox [this message]
2020-08-16  7:34     ` Mike Rapoport
2020-08-16 11:13       ` Meelis Roos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200815184200.GA17456@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=abdhalee@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=geert@linux-m68k.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=linux-parisc@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mroos@linux.ee \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rppt@linux.ibm.com \
    --cc=sathnaga@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=shorne@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.