From: Christoph Hellwig <hch@infradead.org>
To: Qian Cai <cai@lca.pw>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
darrick.wong@oracle.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
khlebnikov@yandex-team.ru
Subject: Re: WARN_ON_ONCE(1) in iomap_dio_actor()
Date: Mon, 17 Aug 2020 08:07:26 +0100 [thread overview]
Message-ID: <20200817070726.GA28668@infradead.org> (raw)
In-Reply-To: <B409CB60-3A36-480D-964B-90043490B7B9@lca.pw>
On Thu, Aug 13, 2020 at 03:52:13AM -0400, Qian Cai wrote:
> > No sane application would ever do this, it's behaviour as expected,
> > so I don't think there's anything to care about here.
>
> It looks me the kernel warning is trivial to trigger by an non-root user. Shouldn???t we worry a bit because this could be a DoS for systems which set panic_on_warn?
Yes, we should trigger a WARN_ON on user behavior. a
pr_info_ratelimited + tracepoint and a good comment is probably the
better solution.
prev parent reply other threads:[~2020-08-17 7:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 21:17 WARN_ON_ONCE(1) in iomap_dio_actor() Qian Cai
2020-06-20 0:17 ` Matthew Wilcox
2020-06-21 2:04 ` Qian Cai
2020-07-24 18:24 ` Qian Cai
2020-07-26 15:24 ` Christoph Hellwig
2020-07-26 22:51 ` Qian Cai
2020-08-11 2:03 ` Qian Cai
2020-08-13 5:44 ` Dave Chinner
2020-08-13 7:52 ` Qian Cai
2020-08-17 7:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817070726.GA28668@infradead.org \
--to=hch@infradead.org \
--cc=cai@lca.pw \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.