From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964BBC433E1 for ; Mon, 17 Aug 2020 05:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75B8E206DA for ; Mon, 17 Aug 2020 05:59:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="Tbfi4l6E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbgHQF7f (ORCPT ); Mon, 17 Aug 2020 01:59:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgHQF7e (ORCPT ); Mon, 17 Aug 2020 01:59:34 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B22F6C061388; Sun, 16 Aug 2020 22:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HZyl5q+jnCvX1fyjf0e5q25W96mTDQeUnBuw8XcBjho=; b=Tbfi4l6EOYQY5R4kZrucj5ihlG Pa24jwPDsNSiAcgBzp880XtY4ytb+tBXkFJnRNQvQfJxkOr0Nii6011LKqUcs35/fhyQYn+b4XwNL CltUqh8GD4Ww7OiU3tQ5DHo8fMtqzAY7U4++7NisYLeFiwnKcSoMObWYX1x25O1Xigkc=; Received: from p200300ccff0cdf001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0c:df00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k7YAy-0004Iy-4D; Mon, 17 Aug 2020 07:59:20 +0200 Date: Mon, 17 Aug 2020 07:59:18 +0200 From: Andreas Kemnade To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com, marcel.ziswiler@toradex.com, sebastien.szymanski@armadeus.com, rjones@gateworks.com, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, letux-kernel@openphoenux.org Subject: Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD Message-ID: <20200817075918.4e53e6b8@aktux> In-Reply-To: <20200816155751.GB103070@latitude> References: <20200815193336.21598-1-andreas@kemnade.info> <20200815193336.21598-3-andreas@kemnade.info> <20200816125247.GA103070@latitude> <20200816165058.3a17d97a@aktux> <20200816155751.GB103070@latitude> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, 16 Aug 2020 17:57:51 +0200 Jonathan Neusch=C3=A4fer wrote: > On Sun, Aug 16, 2020 at 04:50:58PM +0200, Andreas Kemnade wrote: > > Hi, > >=20 > > Seems that we have different hardware, so the first question is > > first the most interesting thing: how much does the hw actually differ, > > especially do they require different device trees? > >=20 > > Can you provide me a photo of your hardware? > > Or is it a Shine 3? =20 >=20 > It is a Shine 2HD >=20 > >=20 > > Mine is at https://misc.andi.de1.cc/tolino2.jpg =20 >=20 > Mine: >=20 > https://raw.githubusercontent.com/wiki/neuschaefer/linux/Tolino-Shine2HD.= jpg >=20 >=20 > It appears to be the next PCB revision (+4A3 instead of +4A2), but I > think the PCB layout looks the same. The Realtek-based Wifi module is > exactly where the CyberTan WC121 was. >=20 =46rom other sources I also think these revisions are same besides wifi. So the only thing warranting separate dtbs might be the OOB IRQ thing. In the Tolino sources there is the function dhd_customer_oob_irq_map in the bcmdhd driver, and it gets its number from this: drivers/net/wireless/bcmdhd/Makefile: -DCUSTOMER_HW2 -DCUSTOM_OOB_GPIO_NUM= =3D127 -DOOB_INTR_ONLY -DHW_OOB The brcmfmac driver is upstream and has devicetree support, but the rtl8189fs is not. For the Clara I am using this one: https://github.com/jwrdegoede/rtl8189ES_linux.git (branch 8189fs) It has no devicetree support, so things cannot be defined anyway. On one hand the hardware should be described in the devicetree as good as possible but on the other hand the OOB IRQ is not mandatory. Regards, Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B32CC433DF for ; Mon, 17 Aug 2020 06:01:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0743920758 for ; Mon, 17 Aug 2020 06:01:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ubqjo0Fr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="Tbfi4l6E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0743920758 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vmlKxnfYEm8wadToNrp97waz24g8PsDC2cFKFRgcH2E=; b=ubqjo0Fre5g4FXO4MoVaLXlJl pMlEpE3ufELxx6PQ1/6//F5Wa+izhqmkdolJiRhcMZwcJhi8REebhT13lmX4JlOpVXrnCoFrF7Eh7 +tBPVdMoFez25ObFh03Zj2RhUD6iNDaF0WNAt88r70p/1EMWBaxwj8zZQIDMUW6ZEPOKIPgO8RF2V WWCDyb61zeXAO6XPJFx9Sh9kUPBDfS/OeGTPXLzYAtWDhs0338DVcHP1v9Po1P8lOcUvY/0zCb5+l Hm31yrrzGzsOc+BCvOHLauks9cLgcYzCunZfxUl1eqgNggPmpNWP0oAzkJEBz4fj5ZzNl2M8i6bPv 5LZ695yig==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7YBJ-00018d-8F; Mon, 17 Aug 2020 05:59:41 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7YBG-00017z-HE for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 05:59:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HZyl5q+jnCvX1fyjf0e5q25W96mTDQeUnBuw8XcBjho=; b=Tbfi4l6EOYQY5R4kZrucj5ihlG Pa24jwPDsNSiAcgBzp880XtY4ytb+tBXkFJnRNQvQfJxkOr0Nii6011LKqUcs35/fhyQYn+b4XwNL CltUqh8GD4Ww7OiU3tQ5DHo8fMtqzAY7U4++7NisYLeFiwnKcSoMObWYX1x25O1Xigkc=; Received: from p200300ccff0cdf001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0c:df00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k7YAy-0004Iy-4D; Mon, 17 Aug 2020 07:59:20 +0200 Date: Mon, 17 Aug 2020 07:59:18 +0200 From: Andreas Kemnade To: Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= Subject: Re: [PATCH RFC 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD Message-ID: <20200817075918.4e53e6b8@aktux> In-Reply-To: <20200816155751.GB103070@latitude> References: <20200815193336.21598-1-andreas@kemnade.info> <20200815193336.21598-3-andreas@kemnade.info> <20200816125247.GA103070@latitude> <20200816165058.3a17d97a@aktux> <20200816155751.GB103070@latitude> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_015938_690372_D3136BBD X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, rjones@gateworks.com, Anson.Huang@nxp.com, marcel.ziswiler@toradex.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, sebastien.szymanski@armadeus.com, letux-kernel@openphoenux.org, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBTdW4sIDE2IEF1ZyAyMDIwIDE3OjU3OjUxICswMjAwCkpvbmF0aGFuIE5ldXNjaMOk ZmVyIDxqLm5ldXNjaGFlZmVyQGdteC5uZXQ+IHdyb3RlOgoKPiBPbiBTdW4sIEF1ZyAxNiwgMjAy MCBhdCAwNDo1MDo1OFBNICswMjAwLCBBbmRyZWFzIEtlbW5hZGUgd3JvdGU6Cj4gPiBIaSwKPiA+ IAo+ID4gU2VlbXMgdGhhdCB3ZSBoYXZlIGRpZmZlcmVudCBoYXJkd2FyZSwgc28gdGhlIGZpcnN0 IHF1ZXN0aW9uIGlzCj4gPiBmaXJzdCB0aGUgbW9zdCBpbnRlcmVzdGluZyB0aGluZzogaG93IG11 Y2ggZG9lcyB0aGUgaHcgYWN0dWFsbHkgZGlmZmVyLAo+ID4gZXNwZWNpYWxseSBkbyB0aGV5IHJl cXVpcmUgZGlmZmVyZW50IGRldmljZSB0cmVlcz8KPiA+IAo+ID4gQ2FuIHlvdSBwcm92aWRlIG1l IGEgcGhvdG8gb2YgeW91ciBoYXJkd2FyZT8KPiA+IE9yIGlzIGl0IGEgU2hpbmUgMz8gIAo+IAo+ IEl0IGlzIGEgU2hpbmUgMkhECj4gCj4gPiAKPiA+IE1pbmUgaXMgYXQgaHR0cHM6Ly9taXNjLmFu ZGkuZGUxLmNjL3RvbGlubzIuanBnICAKPiAKPiBNaW5lOgo+IAo+IGh0dHBzOi8vcmF3LmdpdGh1 YnVzZXJjb250ZW50LmNvbS93aWtpL25ldXNjaGFlZmVyL2xpbnV4L1RvbGluby1TaGluZTJIRC5q cGcKPiAKPiAKPiBJdCBhcHBlYXJzIHRvIGJlIHRoZSBuZXh0IFBDQiByZXZpc2lvbiAoKzRBMyBp bnN0ZWFkIG9mICs0QTIpLCBidXQgSQo+IHRoaW5rIHRoZSBQQ0IgbGF5b3V0IGxvb2tzIHRoZSBz YW1lLiBUaGUgUmVhbHRlay1iYXNlZCBXaWZpIG1vZHVsZSBpcwo+IGV4YWN0bHkgd2hlcmUgdGhl IEN5YmVyVGFuIFdDMTIxIHdhcy4KPiAKCkZyb20gb3RoZXIgc291cmNlcyBJIGFsc28gdGhpbmsg dGhlc2UgcmV2aXNpb25zIGFyZSBzYW1lIGJlc2lkZXMgd2lmaS4KClNvIHRoZSBvbmx5IHRoaW5n IHdhcnJhbnRpbmcgc2VwYXJhdGUgZHRicyBtaWdodCBiZSB0aGUgT09CIElSUSB0aGluZy4KSW4g dGhlIFRvbGlubyBzb3VyY2VzIHRoZXJlIGlzIHRoZSBmdW5jdGlvbiBkaGRfY3VzdG9tZXJfb29i X2lycV9tYXAgaW4KdGhlIGJjbWRoZCBkcml2ZXIsIGFuZCBpdCBnZXRzIGl0cyBudW1iZXIgZnJv bSB0aGlzOgpkcml2ZXJzL25ldC93aXJlbGVzcy9iY21kaGQvTWFrZWZpbGU6CS1EQ1VTVE9NRVJf SFcyIC1EQ1VTVE9NX09PQl9HUElPX05VTT0xMjcgLURPT0JfSU5UUl9PTkxZIC1ESFdfT09CCgpU aGUgYnJjbWZtYWMgZHJpdmVyIGlzIHVwc3RyZWFtIGFuZCBoYXMgZGV2aWNldHJlZSBzdXBwb3J0 LCBidXQgdGhlCnJ0bDgxODlmcyBpcyBub3QuIEZvciB0aGUgQ2xhcmEgSSBhbSB1c2luZyB0aGlz IG9uZToKaHR0cHM6Ly9naXRodWIuY29tL2p3cmRlZ29lZGUvcnRsODE4OUVTX2xpbnV4LmdpdCAo YnJhbmNoIDgxODlmcykKSXQgaGFzIG5vIGRldmljZXRyZWUgc3VwcG9ydCwgc28gdGhpbmdzIGNh bm5vdCBiZSBkZWZpbmVkIGFueXdheS4KCk9uIG9uZSBoYW5kIHRoZSBoYXJkd2FyZSBzaG91bGQg YmUgZGVzY3JpYmVkIGluIHRoZSBkZXZpY2V0cmVlIGFzIGdvb2QKYXMgcG9zc2libGUgYnV0IG9u IHRoZSBvdGhlciBoYW5kIHRoZSBPT0IgSVJRIGlzIG5vdCBtYW5kYXRvcnkuCgpSZWdhcmRzLApB bmRyZWFzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==