From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB596C433E1 for ; Mon, 17 Aug 2020 07:26:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD702078A for ; Mon, 17 Aug 2020 07:26:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V1SZtanF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBD702078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7ZXR-00012M-0F for qemu-devel@archiver.kernel.org; Mon, 17 Aug 2020 03:26:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7ZWr-0000Js-LQ for qemu-devel@nongnu.org; Mon, 17 Aug 2020 03:26:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k7ZWp-0003KM-G8 for qemu-devel@nongnu.org; Mon, 17 Aug 2020 03:26:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597649158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQwWppCWKFKCrS3uSBkLY9hiXvl1i5IBy4QYAXYfel8=; b=V1SZtanFrbuPu3U08HSNi3pA9hK9mgbepxCdH85PyP2filqgZ4/7NrJ5kBBXWvtXiiXlts 0Gma1jTYH0mSA77sm6iWHln2S+wE+e6k1TCw6wd0lvVvq7gPgWffLeWGT9k3g43k8wtaXL tJA8BXCQvtOahmRnt5/xHzRPn9Kgqq0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-WXHxtavOM8SNW7UdHYk5Aw-1; Mon, 17 Aug 2020 03:25:56 -0400 X-MC-Unique: WXHxtavOM8SNW7UdHYk5Aw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32C65425CE for ; Mon, 17 Aug 2020 07:25:55 +0000 (UTC) Received: from gondolin (ovpn-112-230.ams2.redhat.com [10.36.112.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15E857010B; Mon, 17 Aug 2020 07:25:53 +0000 (UTC) Date: Mon, 17 Aug 2020 09:25:51 +0200 From: Cornelia Huck To: Eduardo Habkost Subject: Re: [PATCH 12/41] virtio-ccw: Fix definition of VIRTIO_CCW_BUS_GET_CLASS Message-ID: <20200817092551.72eae5bc.cohuck@redhat.com> In-Reply-To: <20200813222625.243136-13-ehabkost@redhat.com> References: <20200813222625.243136-1-ehabkost@redhat.com> <20200813222625.243136-13-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/17 01:24:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Daniel P. Berrange" , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 13 Aug 2020 18:25:56 -0400 Eduardo Habkost wrote: > The macro was incorrectly defined using OBJECT_CHECK. > > Signed-off-by: Eduardo Habkost > --- > hw/s390x/virtio-ccw.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h > index c0e3355248..b281896f7d 100644 > --- a/hw/s390x/virtio-ccw.h > +++ b/hw/s390x/virtio-ccw.h > @@ -65,9 +65,9 @@ typedef struct VirtioBusClass VirtioCcwBusClass; > > #define TYPE_VIRTIO_CCW_BUS "virtio-ccw-bus" > #define VIRTIO_CCW_BUS(obj) \ > - OBJECT_CHECK(VirtioCcwBus, (obj), TYPE_VIRTIO_CCW_BUS) > + OBJECT_CHECK(VirtioCcwBusState, (obj), TYPE_VIRTIO_CCW_BUS) > #define VIRTIO_CCW_BUS_GET_CLASS(obj) \ > - OBJECT_CHECK(VirtioCcwBusState, (obj), TYPE_VIRTIO_CCW_BUS) > + OBJECT_GET_CLASS(VirtioCcwBusClass, (obj), TYPE_VIRTIO_CCW_BUS) > #define VIRTIO_CCW_BUS_CLASS(klass) \ > OBJECT_CLASS_CHECK(VirtioCcwBusClass, klass, TYPE_VIRTIO_CCW_BUS) > I was wondering why nobody ever noticed, but it seems that the broken macros were simply unused. If we keep them for completeness' sake, we should make sure that they are indeed correct :) Acked-by: Cornelia Huck