From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0907C433E1 for ; Mon, 17 Aug 2020 10:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 709362078A for ; Mon, 17 Aug 2020 10:19:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WXNqC8Bk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbgHQKTd (ORCPT ); Mon, 17 Aug 2020 06:19:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60057 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726297AbgHQKTc (ORCPT ); Mon, 17 Aug 2020 06:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597659571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VGbJwI3itELdK2Hji+iycRZOmACsuMM37BEJjNDZq9g=; b=WXNqC8BkD1hU8+pAUAECJNd58GlEfYSrvbt8c4xqJ/RPLw+Op5AxxUnFJuXP3edUSMpTCk ctzg4M4erjhT5anmJbKPqMbEhoAmRh6Bqj0bikObno32KbVPj8v81EPzTUbhSJXmJPTT79 JqKeMW/3uu5Pj8G8OXC8lE0tm6kpQ1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-te4cdZJ8MhaRjjpNLyRBsQ-1; Mon, 17 Aug 2020 06:19:29 -0400 X-MC-Unique: te4cdZJ8MhaRjjpNLyRBsQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8918F425E8; Mon, 17 Aug 2020 10:19:27 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-195.ams2.redhat.com [10.36.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DDE07DFC0; Mon, 17 Aug 2020 10:19:26 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 251C29D8F; Mon, 17 Aug 2020 12:19:25 +0200 (CEST) Date: Mon, 17 Aug 2020 12:19:25 +0200 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, 1882851@bugs.launchpad.net, David Airlie , Chia-I Wu , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH] drm/virtio: fix unblank Message-ID: <20200817101925.ljpfgz336zxegsup@sirius.home.kraxel.org> References: <20200807105429.24208-1-kraxel@redhat.com> <20200807130956.GE2352366@phenom.ffwll.local> <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2020 at 11:03:42AM +0200, Gerd Hoffmann wrote: > Hi, > > > > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > > > @@ -100,6 +100,7 @@ static void virtio_gpu_crtc_atomic_enable(struct drm_crtc *crtc, > > > struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); > > > > > > output->enabled = true; > > > + output->need_update = true; > > > > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > > > @@ -163,7 +163,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane, > > > plane->state->src_w != old_state->src_w || > > > plane->state->src_h != old_state->src_h || > > > plane->state->src_x != old_state->src_x || > > > - plane->state->src_y != old_state->src_y) { > > > + plane->state->src_y != old_state->src_y || > > > + output->need_update) { > > > > Uh instead of hand-rolling what's essentially a drm_crtc_needs_modeset > > check, why not use that one? atomic helpers try to keep the usual suspects > > for state transitions already handy, to avoid every driver rolling their > > own. Or do I miss something here? > > Well, the virtio-gpu virtual hardware can't do plane updates and crtc > updates independant from each other. So the crtc callbacks handle > disable only (we don't need a fb for that) and leave the enable to the > plane update. > > I suspect calling drm_atomic_crtc_needs_modeset() in plane update isn't > going to fly ... Digged a bit more, seems crtc_state->*_changed is cleared after modeset so the following plane update wouldn't see it. Which I think means there is no way around tracking that in need_update. output->enabled is probably not needed though, seems I can replace that by either output->crtc.state->enable or ->active. Not fully sure which one, probably ->active. take care, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAD0C433DF for ; Mon, 17 Aug 2020 10:26:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFE0820738 for ; Mon, 17 Aug 2020 10:26:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFE0820738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7cLo-0007Ou-5e for qemu-devel@archiver.kernel.org; Mon, 17 Aug 2020 06:26:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7cKr-0006ob-Ou for qemu-devel@nongnu.org; Mon, 17 Aug 2020 06:25:49 -0400 Received: from indium.canonical.com ([91.189.90.7]:38424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7cKp-0008MH-EP for qemu-devel@nongnu.org; Mon, 17 Aug 2020 06:25:49 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1k7cKn-0005OX-2J for ; Mon, 17 Aug 2020 10:25:45 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id E36F22E80EA for ; Mon, 17 Aug 2020 10:25:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 17 Aug 2020 10:19:25 -0000 From: Gerd Hoffmann <1882851@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: diego-viola kraxel-redhat X-Launchpad-Bug-Reporter: Diego Viola (diego-viola) X-Launchpad-Bug-Modifier: Gerd Hoffmann (kraxel-redhat) References: <159174217343.32241.17743917589333297614.malonedeb@gac.canonical.com> <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> Message-Id: <20200817101925.ljpfgz336zxegsup@sirius.home.kraxel.org> Subject: [Bug 1882851] Re: [PATCH] drm/virtio: fix unblank X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="d6d0b96812d8def2ca0ffcc25cb4d200f2f30aeb"; Instance="production-secrets-lazr.conf" X-Launchpad-Hash: fd2dee17897baf5d7fd092993bd1342b70973a26 Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/17 04:50:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -58 X-Spam_score: -5.9 X-Spam_bar: ----- X-Spam_report: (-5.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1882851 <1882851@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 17, 2020 at 11:03:42AM +0200, Gerd Hoffmann wrote: > Hi, > = > > > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > > > @@ -100,6 +100,7 @@ static void virtio_gpu_crtc_atomic_enable(struct = drm_crtc *crtc, > > > struct virtio_gpu_output *output =3D drm_crtc_to_virtio_gpu_output(= crtc); > > > = > > > output->enabled =3D true; > > > + output->need_update =3D true; > = > > > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > > > @@ -163,7 +163,8 @@ static void virtio_gpu_primary_plane_update(struc= t drm_plane *plane, > > > plane->state->src_w !=3D old_state->src_w || > > > plane->state->src_h !=3D old_state->src_h || > > > plane->state->src_x !=3D old_state->src_x || > > > - plane->state->src_y !=3D old_state->src_y) { > > > + plane->state->src_y !=3D old_state->src_y || > > > + output->need_update) { > > = > > Uh instead of hand-rolling what's essentially a drm_crtc_needs_modeset > > check, why not use that one? atomic helpers try to keep the usual suspe= cts > > for state transitions already handy, to avoid every driver rolling their > > own. Or do I miss something here? > = > Well, the virtio-gpu virtual hardware can't do plane updates and crtc > updates independant from each other. So the crtc callbacks handle > disable only (we don't need a fb for that) and leave the enable to the > plane update. > = > I suspect calling drm_atomic_crtc_needs_modeset() in plane update isn't > going to fly ... Digged a bit more, seems crtc_state->*_changed is cleared after modeset so the following plane update wouldn't see it. Which I think means there is no way around tracking that in need_update. output->enabled is probably not needed though, seems I can replace that by either output->crtc.state->enable or ->active. Not fully sure which one, probably ->active. take care, Gerd -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1882851 Title: QEMU video freezes with "Guest disabled display" (virtio driver) Status in QEMU: New Bug description: I am using Arch Linux as my Guest and Host OS, after starting qemu with the following command: $ qemu-system-x86_64 -enable-kvm -hda arch-zoom.qcow2 -m 4G -vga virtio and waiting for a screen blank, I get this message: Guest disabled display And nothing happens after that, I can move the mouse or hit any key, and the message is still there. I can still reboot the VM but that's not optimal. I can reproduce this with the latest QEMU release (5.0.0) or git master, = I also tried this with older releases (4.0.0, 3.0.0) and the issue is sti= ll there. I can't reproduce this with other video drivers (std, qxl). With std/qxl the screen will blank a bit and then continue as normal. To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1882851/+subscriptions From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2803C433DF for ; Mon, 17 Aug 2020 10:19:36 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EAAE2078A for ; Mon, 17 Aug 2020 10:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WXNqC8Bk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EAAE2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5C3F686BE1; Mon, 17 Aug 2020 10:19:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eqgbfaC8GN3m; Mon, 17 Aug 2020 10:19:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 7A18F86B43; Mon, 17 Aug 2020 10:19:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 61FA0C088B; Mon, 17 Aug 2020 10:19:35 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id DB208C0051 for ; Mon, 17 Aug 2020 10:19:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C764386B48 for ; Mon, 17 Aug 2020 10:19:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JDQ4kYfBSiMF for ; Mon, 17 Aug 2020 10:19:33 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by whitealder.osuosl.org (Postfix) with ESMTPS id EC04C86AE5 for ; Mon, 17 Aug 2020 10:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597659571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VGbJwI3itELdK2Hji+iycRZOmACsuMM37BEJjNDZq9g=; b=WXNqC8BkD1hU8+pAUAECJNd58GlEfYSrvbt8c4xqJ/RPLw+Op5AxxUnFJuXP3edUSMpTCk ctzg4M4erjhT5anmJbKPqMbEhoAmRh6Bqj0bikObno32KbVPj8v81EPzTUbhSJXmJPTT79 JqKeMW/3uu5Pj8G8OXC8lE0tm6kpQ1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-te4cdZJ8MhaRjjpNLyRBsQ-1; Mon, 17 Aug 2020 06:19:29 -0400 X-MC-Unique: te4cdZJ8MhaRjjpNLyRBsQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8918F425E8; Mon, 17 Aug 2020 10:19:27 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-195.ams2.redhat.com [10.36.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DDE07DFC0; Mon, 17 Aug 2020 10:19:26 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 251C29D8F; Mon, 17 Aug 2020 12:19:25 +0200 (CEST) Date: Mon, 17 Aug 2020 12:19:25 +0200 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, 1882851@bugs.launchpad.net, David Airlie , Chia-I Wu , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH] drm/virtio: fix unblank Message-ID: <20200817101925.ljpfgz336zxegsup@sirius.home.kraxel.org> References: <20200807105429.24208-1-kraxel@redhat.com> <20200807130956.GE2352366@phenom.ffwll.local> <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Aug 17, 2020 at 11:03:42AM +0200, Gerd Hoffmann wrote: > Hi, > > > > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > > > @@ -100,6 +100,7 @@ static void virtio_gpu_crtc_atomic_enable(struct drm_crtc *crtc, > > > struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); > > > > > > output->enabled = true; > > > + output->need_update = true; > > > > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > > > @@ -163,7 +163,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane, > > > plane->state->src_w != old_state->src_w || > > > plane->state->src_h != old_state->src_h || > > > plane->state->src_x != old_state->src_x || > > > - plane->state->src_y != old_state->src_y) { > > > + plane->state->src_y != old_state->src_y || > > > + output->need_update) { > > > > Uh instead of hand-rolling what's essentially a drm_crtc_needs_modeset > > check, why not use that one? atomic helpers try to keep the usual suspects > > for state transitions already handy, to avoid every driver rolling their > > own. Or do I miss something here? > > Well, the virtio-gpu virtual hardware can't do plane updates and crtc > updates independant from each other. So the crtc callbacks handle > disable only (we don't need a fb for that) and leave the enable to the > plane update. > > I suspect calling drm_atomic_crtc_needs_modeset() in plane update isn't > going to fly ... Digged a bit more, seems crtc_state->*_changed is cleared after modeset so the following plane update wouldn't see it. Which I think means there is no way around tracking that in need_update. output->enabled is probably not needed though, seems I can replace that by either output->crtc.state->enable or ->active. Not fully sure which one, probably ->active. take care, Gerd _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBED5C433DF for ; Mon, 17 Aug 2020 10:19:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F3062078E for ; Mon, 17 Aug 2020 10:19:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WXNqC8Bk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F3062078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF17B6E053; Mon, 17 Aug 2020 10:19:33 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CBF06E053 for ; Mon, 17 Aug 2020 10:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597659571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VGbJwI3itELdK2Hji+iycRZOmACsuMM37BEJjNDZq9g=; b=WXNqC8BkD1hU8+pAUAECJNd58GlEfYSrvbt8c4xqJ/RPLw+Op5AxxUnFJuXP3edUSMpTCk ctzg4M4erjhT5anmJbKPqMbEhoAmRh6Bqj0bikObno32KbVPj8v81EPzTUbhSJXmJPTT79 JqKeMW/3uu5Pj8G8OXC8lE0tm6kpQ1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-te4cdZJ8MhaRjjpNLyRBsQ-1; Mon, 17 Aug 2020 06:19:29 -0400 X-MC-Unique: te4cdZJ8MhaRjjpNLyRBsQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8918F425E8; Mon, 17 Aug 2020 10:19:27 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-195.ams2.redhat.com [10.36.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DDE07DFC0; Mon, 17 Aug 2020 10:19:26 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 251C29D8F; Mon, 17 Aug 2020 12:19:25 +0200 (CEST) Date: Mon, 17 Aug 2020 12:19:25 +0200 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, 1882851@bugs.launchpad.net, David Airlie , Chia-I Wu , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH] drm/virtio: fix unblank Message-ID: <20200817101925.ljpfgz336zxegsup@sirius.home.kraxel.org> References: <20200807105429.24208-1-kraxel@redhat.com> <20200807130956.GE2352366@phenom.ffwll.local> <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817090342.bemmtkvz4seayp2i@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 17, 2020 at 11:03:42AM +0200, Gerd Hoffmann wrote: > Hi, > > > > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > > > @@ -100,6 +100,7 @@ static void virtio_gpu_crtc_atomic_enable(struct drm_crtc *crtc, > > > struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); > > > > > > output->enabled = true; > > > + output->need_update = true; > > > > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > > > @@ -163,7 +163,8 @@ static void virtio_gpu_primary_plane_update(struct drm_plane *plane, > > > plane->state->src_w != old_state->src_w || > > > plane->state->src_h != old_state->src_h || > > > plane->state->src_x != old_state->src_x || > > > - plane->state->src_y != old_state->src_y) { > > > + plane->state->src_y != old_state->src_y || > > > + output->need_update) { > > > > Uh instead of hand-rolling what's essentially a drm_crtc_needs_modeset > > check, why not use that one? atomic helpers try to keep the usual suspects > > for state transitions already handy, to avoid every driver rolling their > > own. Or do I miss something here? > > Well, the virtio-gpu virtual hardware can't do plane updates and crtc > updates independant from each other. So the crtc callbacks handle > disable only (we don't need a fb for that) and leave the enable to the > plane update. > > I suspect calling drm_atomic_crtc_needs_modeset() in plane update isn't > going to fly ... Digged a bit more, seems crtc_state->*_changed is cleared after modeset so the following plane update wouldn't see it. Which I think means there is no way around tracking that in need_update. output->enabled is probably not needed though, seems I can replace that by either output->crtc.state->enable or ->active. Not fully sure which one, probably ->active. take care, Gerd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel