From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96A9C433E3 for ; Mon, 17 Aug 2020 11:54:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C47F920674 for ; Mon, 17 Aug 2020 11:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597665281; bh=NtSDV9pYFkFiji0DnKWayqlaXE3KNJaPLKjwikpsD1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TS/a0pv2Lr2A7caxFcPWQ/GPdcM1GqPenuDNoUN6h3PnGxqBKOT1prl1TY1FIJXO2 DSlu4O2HIkiMWbuFl4Y9FtSmVbkSuiro46jZ2x/cVfABr6nPO+bIJ0h9oePYvVgnk1 8gs/BV6MT59/otP/IRCc0vc65EfNBRcSwHuuyH0M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbgHQLyk (ORCPT ); Mon, 17 Aug 2020 07:54:40 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:37088 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbgHQLyk (ORCPT ); Mon, 17 Aug 2020 07:54:40 -0400 Received: by mail-ej1-f66.google.com with SMTP id qc22so17377705ejb.4; Mon, 17 Aug 2020 04:54:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gmv/LnTVhDrv4xWlObrgrgJVEX/mNaVJGKXV8qYtozI=; b=Ue3v5MDBEdMuiNsbc4OH91xK1LVNqSrguYNy9giH+LGh6ohII25WZ9zLP5ive77Itl iU3rV/DOvO4WjVbeztaj5S1mmegdXIG7zbE8LBkgINMj7Sixor5ESgN5+OacOQ6MW/0b rkOsc/Gdz9LaFlVGAI50D//UlaaO4ZGYpqk/zBUyFDoye2KBxdke7GHEWYe6QSmJIXLu l5sqvAQNAIfC1CH8idUup5gE9p/ZNuH9Vz0OCU0qIPUzKRZ98KPmlt/4yV5l+7Pd+ybj oh/6lsHOKTeh+UQoSwlgsyYYR8+a2+gDICOSoX7e5jxrZe0Hg2adjNMNiJD1BaCs7pY0 l+ig== X-Gm-Message-State: AOAM531qTCzODtjCkdt6ZGpWXym5c3W73HFA4LpmRFi0LyabdlqO7cxF 2Cd6vCWk0jJij1M0Cn/eXq8= X-Google-Smtp-Source: ABdhPJylUYlFzbESSX2S/SjTNBdk/1xQdv9oriQFghbtaaJ60FujFjyCBl8q6FkbYF8v9lJ6dAPjlQ== X-Received: by 2002:a17:906:3890:: with SMTP id q16mr14249884ejd.107.1597665278339; Mon, 17 Aug 2020 04:54:38 -0700 (PDT) Received: from kozik-lap ([194.230.155.242]) by smtp.googlemail.com with ESMTPSA id v14sm14175860ejb.63.2020.08.17.04.54.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 04:54:37 -0700 (PDT) Date: Mon, 17 Aug 2020 13:54:35 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Cc: oss-self-reviewed-patches@listhost.cambridge.arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kgene@kernel.org, b.zolnierkie@samsung.com Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for 'curr_rate' Message-ID: <20200817115435.GA2346@kozik-lap> References: <20200811101727.3976-1-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200811101727.3976-1-lukasz.luba@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 11, 2020 at 11:17:27AM +0100, Lukasz Luba wrote: > The 'curr_rate' is protected by local 'dmc->lock' in various places, but > not in a function exynos5_dmc_get_status(). The lock protects frequency > (and voltage) change process and the corresponding value stored in > 'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading > also in the exynos5_dmc_get_status(). > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Lukasz Luba > --- > drivers/memory/samsung/exynos5422-dmc.c | 3 +++ Thanks, applied. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F848C433DF for ; Mon, 17 Aug 2020 11:56:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21F7B204EA for ; Mon, 17 Aug 2020 11:56:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vG9YpUNV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21F7B204EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GCHQrK87sTWXIzKj4X3FhW0DgebamZyK0NnZtkLOoxE=; b=vG9YpUNV9bhwcMw0yAGL+vRWf r+lQmHMafq/KWIfpuOrMgLvdHY8QItPpICXOvHPy576UpkeUVRSrJtpG4k9yeS3stiTfxC4A321oM Bryipn4xC1cniwXxKddkFO1HxgLc8jG1OoMRWpmlOMYHE9mchjzA4KKmQFUPZie/Z6vdsNJIzIoTL m8Lbd52e1R5tTWMzV9eDOrSZ8tWS+B/DYn53jnH1q008ZYvUheOyNRvZ1dOin/WhtZ/cqqer3w36c 8niqJIvcI7t7kEZobgDaFuYW7aJfGhhVAaoLnaou0Bo+CWoX4duBzXTBVjx8rDwIiN88JwiySJyK0 nmL8Pl/Fg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7diu-00080P-6h; Mon, 17 Aug 2020 11:54:44 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7dir-0007zr-Ia for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 11:54:42 +0000 Received: by mail-ej1-f65.google.com with SMTP id o18so17377099eje.7 for ; Mon, 17 Aug 2020 04:54:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gmv/LnTVhDrv4xWlObrgrgJVEX/mNaVJGKXV8qYtozI=; b=dsHdB4CO1duV4c4hEG1JbB1XM7mmnfbAsEQOoXyZL8cXMCkKnh5HiOy2iOsmVSJwdJ MhiCDASm/J2QRdnUF6DSMzt+6PQThoO8gXrf07I8Si7f8IE1uPA4GfQWu2Hi8uIe1D64 j9d+Jr5/rVIG0/hi3pvpVr4yO2B72Y+UrAYIEE3Mf1VU06rvLfNQt5I+O1tzWSboOusm jtUO8R7DSQM+EpoHsdygqbX086hQMwO/FU9M0J+e4EzUZEzQKkC0pvCDnw6Hifmq55gU 14GOwJHBZH1Tm7ON6U6e5tN06cH7FP9Rex2r7FSCN2MsbCPkERwRySXW/mUHnmyGJl+i v0sw== X-Gm-Message-State: AOAM532cbL8FsbZ16HFJt0z2atqerMAipLjFOKRvgifEug8QzjBk2PmO GNdBufgPMpL9ITl8ISHd9qo= X-Google-Smtp-Source: ABdhPJylUYlFzbESSX2S/SjTNBdk/1xQdv9oriQFghbtaaJ60FujFjyCBl8q6FkbYF8v9lJ6dAPjlQ== X-Received: by 2002:a17:906:3890:: with SMTP id q16mr14249884ejd.107.1597665278339; Mon, 17 Aug 2020 04:54:38 -0700 (PDT) Received: from kozik-lap ([194.230.155.242]) by smtp.googlemail.com with ESMTPSA id v14sm14175860ejb.63.2020.08.17.04.54.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 04:54:37 -0700 (PDT) Date: Mon, 17 Aug 2020 13:54:35 +0200 From: Krzysztof Kozlowski To: Lukasz Luba Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for 'curr_rate' Message-ID: <20200817115435.GA2346@kozik-lap> References: <20200811101727.3976-1-lukasz.luba@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200811101727.3976-1-lukasz.luba@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_075441_643166_AEBAAB74 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, oss-self-reviewed-patches@listhost.cambridge.arm.com, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 11, 2020 at 11:17:27AM +0100, Lukasz Luba wrote: > The 'curr_rate' is protected by local 'dmc->lock' in various places, but > not in a function exynos5_dmc_get_status(). The lock protects frequency > (and voltage) change process and the corresponding value stored in > 'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading > also in the exynos5_dmc_get_status(). > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Lukasz Luba > --- > drivers/memory/samsung/exynos5422-dmc.c | 3 +++ Thanks, applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel