From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2A9CC433EA for ; Mon, 17 Aug 2020 16:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD003206FA for ; Mon, 17 Aug 2020 16:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597682833; bh=XGLUHC3M004uJQzADNk1uMu20Yuq/+igbT74y7M+Xf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nTv1XKwj5idoA8WCkS3fo8rEZHm0QhFaLaaY0VRu1/HCnOAblSfc+52FR2u2eMIkV Ms4s/GT2NR1nbroooN4bXKdUxGods8KeT8RvAoMjVBYdF0zsbvFA135bazCLEczF+U jj9u/fqoXh1sEkfuQs6Uik+2q8O90NlSOKrX4XUk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731378AbgHQQq6 (ORCPT ); Mon, 17 Aug 2020 12:46:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:47506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731023AbgHQQAf (ORCPT ); Mon, 17 Aug 2020 12:00:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D649020729; Mon, 17 Aug 2020 16:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597680035; bh=XGLUHC3M004uJQzADNk1uMu20Yuq/+igbT74y7M+Xf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hZBfzWeYO9gjrjmtZWeRcP5ACngXaLTg1aaEFYowLIE8JCm/bbFYfbEjawhA8izuN OcaqnxW+mzMNmp2hTpp+g61vJIzGhl+zKgK8BYmDETAW71KvstN5668qCVhaCaq3hm GJdfbQellgUTsZhhJJc0uoPDZozWLRuKhN/e+2Zw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liu Yong , Sasha Levin Subject: [PATCH 5.4 004/270] fs/io_uring.c: Fix uninitialized variable is referenced in io_submit_sqe Date: Mon, 17 Aug 2020 17:13:25 +0200 Message-Id: <20200817143756.029696893@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143755.807583758@linuxfoundation.org> References: <20200817143755.807583758@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liu Yong the commit ("opcode>") caused another vulnerability. After io_get_req(), the sqe_submit struct in req is not initialized, but the following code defaults that req->submit.opcode is available. Signed-off-by: Liu Yong Signed-off-by: Sasha Levin --- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/io_uring.c b/fs/io_uring.c index be3d595a607f4..c1aaee061dae5 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2559,6 +2559,7 @@ static void io_submit_sqe(struct io_ring_ctx *ctx, struct sqe_submit *s, goto err; } + memcpy(&req->submit, s, sizeof(*s)); ret = io_req_set_file(ctx, s, state, req); if (unlikely(ret)) { err_req: -- 2.25.1