From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B838C433DF for ; Mon, 17 Aug 2020 16:17:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CB85207FB for ; Mon, 17 Aug 2020 16:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LWIyVoxU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n3mYM0GB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CB85207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9j/2sS8PmHCExTw01zFt+GaW4Ivnq6S0WYmEdq+JDPU=; b=LWIyVoxUlAFH6ghJwGI1jpA4+ Y5/HmtGHreU6bwi9TzuuvOlVBk830E9+n8x4u41YMWMjwUS1ae7XSmDDtqzU++z1y/IjcoFxzgDWB +ULJOX+zZFKNCf4KUGdVWAJVcL5WtZ61zujwKy84oTORtucYitaE3x8l8KxepWVs8cqsEe9yR/nSI hMs/qL9ETNRy6CkyF+k9FeIPN2WKO0xIBmCVQDeM0jgOMqm0Cg7vp4Qzi0neb5jrjVpCwRu//kHNk iKAhw49fgfwA0yalM9TwOxwoRLRSP7s5bHPIBB3uX2VhLMoEelnN7mN6KPc3F0n/t7pId2yLgczyN 03VGmvjmg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7hnP-000678-Ub; Mon, 17 Aug 2020 16:15:39 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7hnM-00066H-Qc for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 16:15:38 +0000 Received: by mail-pl1-x643.google.com with SMTP id bh1so7753218plb.12 for ; Mon, 17 Aug 2020 09:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GRTPAyuvRQ0HXUDzIrtRlWw01kBKHFXmk+40MGHT3w0=; b=n3mYM0GBbORTBmsDp08MnJ15RRxjW30Gg78ErXRM9YJZ51uJhRyO31pmitw7cIdk9+ mHUit18faBUwQdX938DmI33hILhkbkYIwwPXtLBrYTIGFNracrw2NY5/5BWvCT3XGqXm 3Bvn+qoYh4CRr+6wmgM3QGrNWDqb/EsWHB4Dtor5pwcyHtsYHjCtwkASxhvKex1eUiL2 ZskdyocMjv0vZhwk7+7L8um8R3JubE+e9vC3qwWV7HCpJzYfy2gr5nLf/3DDCwqXrHXp CFYzuZG3NqPAD0jgzF0Ewa9hHrio549HFRnhqrlCxQGd3pXLYpnfn8VVhkJvgG1orwGF VgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GRTPAyuvRQ0HXUDzIrtRlWw01kBKHFXmk+40MGHT3w0=; b=lkeh7Wbqr8UlkxaWsMtNOvO9luii2zu5HGGm55BFjBnR1ycpytY3Z7tJBkX4d2d2SQ QKQReNJys3yfQxzcXyhUaSyIvv6XLS9IKW3ccQ256YkFlHYPsaBJPFdTsZUHpikp8nD8 ynu2Yz9CZHF8kzkHAtN7SHtf9+j4xiJhJcvQmtmicDyXNP6RvloAyJAYu8OjAqS7acPt O2QKBOFwM3WRtGe0RQjBHAfMMuLb5TK3qC/uMI4/XhNsqna689uTFSK/jNCuIHKWc5sM jptD/k1XDY3g9jATjT8M2ONtVGO7s/gXN+jZWO2g/nfWM/cCyCnwrpppZK4do1j5nDXf Wilg== X-Gm-Message-State: AOAM531488S9uRGuyQHNqF++EY/b5tSwPNVhP+p+ZZjiK72U2N/vMdeT F6RZ9KwP/rcuJ48DouxzPxrzZg== X-Google-Smtp-Source: ABdhPJyQxK7I4twjLYRLWVQIcI2kkOosMwMV2b0jVFxVmCvQ8fxIFdcrKvZ9cbvWrep1K1/KJGijVA== X-Received: by 2002:a17:90b:252:: with SMTP id fz18mr12992123pjb.48.1597680934399; Mon, 17 Aug 2020 09:15:34 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id b185sm20264236pfg.71.2020.08.17.09.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 09:15:33 -0700 (PDT) Date: Mon, 17 Aug 2020 10:15:31 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 17/24] coresight: cti: Fix remove sysfs link error Message-ID: <20200817161531.GB3614061@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-18-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-18-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_121537_029843_67BD112E X-CRM114-Status: GOOD ( 22.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:46PM +0800, Tingwei Zhang wrote: > From: Mike Leach > > CTI code to remove sysfs link to other devices on shutdown, incorrectly > tries to remove a single ended link when these are all double ended. This > implementation leaves elements in the link info structure undefined which > results in a crash in recent tests for driver module unload. > > This patch corrects the link removal code. > > Fixes: 73274abb6557 (coresight: cti: Add in sysfs links to other coresight devices) This should be: Fixes: 73274abb6557 ("coresight: cti: Add in sysfs links to other coresight devices") > Reported-by: Tingwei Zhang > Signed-off-by: Mike Leach > --- > drivers/hwtracing/coresight/coresight-cti.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c > index 1f470c47ba70..1c34db7d1b1b 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.c > +++ b/drivers/hwtracing/coresight/coresight-cti.c > @@ -511,12 +511,15 @@ static bool cti_add_sysfs_link(struct cti_drvdata *drvdata, > return !link_err; > } > > -static void cti_remove_sysfs_link(struct cti_trig_con *tc) > +static void cti_remove_sysfs_link(struct cti_drvdata *drvdata, > + struct cti_trig_con *tc) > { > struct coresight_sysfs_link link_info; > > + link_info.orig = drvdata->csdev; > link_info.orig_name = tc->con_dev_name; > link_info.target = tc->con_dev; > + link_info.target_name = dev_name(&drvdata->csdev->dev); > coresight_remove_sysfs_link(&link_info); > } > > @@ -606,7 +609,7 @@ void cti_remove_assoc_from_csdev(struct coresight_device *csdev) > ctidev = &ctidrv->ctidev; > list_for_each_entry(tc, &ctidev->trig_cons, node) { > if (tc->con_dev == csdev->ect_dev) { > - cti_remove_sysfs_link(tc); > + cti_remove_sysfs_link(ctidrv, tc); > tc->con_dev = NULL; > break; > } > @@ -658,7 +661,7 @@ static void cti_remove_conn_xrefs(struct cti_drvdata *drvdata) > if (tc->con_dev) { > coresight_set_assoc_ectdev_mutex(tc->con_dev, > NULL); > - cti_remove_sysfs_link(tc); > + cti_remove_sysfs_link(drvdata, tc); With the above: Reviewed-by: Mathieu Poirier > tc->con_dev = NULL; > } > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel