From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 207EDC433E4 for ; Mon, 17 Aug 2020 16:22:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB1922054F for ; Mon, 17 Aug 2020 16:22:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qJp3SmNL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WIOiFX8J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB1922054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yxbnaQg1B1F1jicjqq25DhdYyqsKqoTgvpBQfcB8JQQ=; b=qJp3SmNLlODRYHjAQCf6kJIwW cAUjWSp56ndj4sjtx/kD/PL/AebGWlNufiKGcP8AfMQflawJw566YrTDyKtznKXRZS0MM2SdKsw0i PvzG2zQXQXsisP9A2vAwwAZdw2ZOWG0WezEvHNak6FRRJ3kUSesqC0O5Wk8xXgF+9whsAIK9sIEZy 8suVwbQ/y51eMgRCyYjq9wNCF4MuA3JB/QVdtZDnbSdN7rrpKvvDRtjTYrt1AV1GFkdLkyMCNaYvq KxfruVDWJ5Zfsa3n9H/cBDJNTAti/dHfxSZfLr05s0MHRc0b9xpHwnmecNMQVBYHEEgYg/cBhit71 nhyM0abxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7hsi-0006fy-3w; Mon, 17 Aug 2020 16:21:08 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7hsf-0006fI-Gs for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 16:21:06 +0000 Received: by mail-pj1-x1043.google.com with SMTP id mt12so8061117pjb.4 for ; Mon, 17 Aug 2020 09:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xq9hxzqjhGm3yBb+I/iCG6nA6CDmYmuL7+U5bu/8NAw=; b=WIOiFX8JKkEgbNdZDGcNhvu1weons0vvuxgPasMEfk1CsTxXQGkGR/1V4anp7qV//s Xw6b3n8SCUlAv0BCS27c5EDYNf3dcgJm5sNBi9tpMqiDLxgVWu/BvZZDWTv/2llpN6na 9JtGF43ox+tgnEVphs7bBjqfpuFwS508dCLDOHR+G2oQQWhf7LFQ2x6bwvK6Llcw+2W5 I52h9EEQaG0k7r0afTsMSkr7/9buJH09+ZRsaWa0+jaPYxHM4ySFmiquWm6U0qvgOPuC +R3cPLQX0KlYw4LMJanEY01OUXYf14zVlA4HqW/jlHwWt0Dzs8P8TP35TNZcv/1aplUu fF6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xq9hxzqjhGm3yBb+I/iCG6nA6CDmYmuL7+U5bu/8NAw=; b=ZfXAishszDTIXAEyobBVRQKvAxbqEbnLGqLPGtYogdSMBn4I63KCu0ch9FEJuYl157 o4vzSgrB14o2xyp/xOA/Djr9/tmNOQW2PbZfpO46ytd10t+MGDSGY5GSt0sPzhAnYNQr TFyHDHRhNl4FmpGFyVDiSt+E2aR2n9eExxaQ2B64v80QaR8UroqJwvTjcZOG5kLHskok wIbAp0F3VH6CCC3z4KpoRYYqUzZl7aJS5SCXAYQYi+JLv0yHvhkYy3lx8JZMQw71mtQf nzugqdIqeaPwtWqGZwULPwlYOpADvMesIJaLBNj62f0ka5jOkGMAaqn1rWZKwlUzMcJ+ Q0EA== X-Gm-Message-State: AOAM533haiPwP3RuUUTxHfPr0X+QLhLG4kP2WXR/pNo1xhhxwicMD/TM AjI+tXRJhdSJTTpNYF9T+QxXlw== X-Google-Smtp-Source: ABdhPJyf0ysYBxD0+ap7KkEPIX5aqP1MgOfzN3kmT6hJFBex3KXT6nFJdNQS/hJRJFz3qdtlG260MA== X-Received: by 2002:a17:90a:c682:: with SMTP id n2mr13012914pjt.72.1597681262905; Mon, 17 Aug 2020 09:21:02 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id x7sm20836247pfc.209.2020.08.17.09.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 09:21:02 -0700 (PDT) Date: Mon, 17 Aug 2020 10:21:00 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 18/24] coresight: cti: Fix bug clearing sysfs links on callback Message-ID: <20200817162100.GC3614061@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-19-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-19-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_122105_702677_3FACD28E X-CRM114-Status: GOOD ( 25.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:47PM +0800, Tingwei Zhang wrote: > From: Mike Leach > > During module unload, a coresight driver module will call back into > the CTI driver to remove any links between the two devices. > > The current code has 2 issues:- > 1) in the CTI driver the matching code is matching to the wrong device > so misses all the links. > 2) The callback is called too late in the unload process resulting in a > crash. > > This fixes both the issues. This patch may no longer be required if my recommendation from patch 16 is followed. > > Fixes: 177af8285b59 (coresight: cti: Enable CTI associated with devices) Same comment as in my previous patch, we need a set of double quotes for the title. > Reported-by: Tingwei Zhang > Signed-off-by: Mike Leach > Signed-off-by: Tingwei Zhang > Acked-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-cti.c | 2 +- > drivers/hwtracing/coresight/coresight.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c > index 1c34db7d1b1b..6bb06c5715db 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.c > +++ b/drivers/hwtracing/coresight/coresight-cti.c > @@ -608,7 +608,7 @@ void cti_remove_assoc_from_csdev(struct coresight_device *csdev) > ctidrv = csdev_to_cti_drvdata(csdev->ect_dev); > ctidev = &ctidrv->ctidev; > list_for_each_entry(tc, &ctidev->trig_cons, node) { > - if (tc->con_dev == csdev->ect_dev) { > + if (tc->con_dev == csdev) { > cti_remove_sysfs_link(ctidrv, tc); > tc->con_dev = NULL; > break; > diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c > index 31b9ec8d3b9c..d066411aa794 100644 > --- a/drivers/hwtracing/coresight/coresight.c > +++ b/drivers/hwtracing/coresight/coresight.c > @@ -1256,8 +1256,6 @@ static void coresight_device_release(struct device *dev) > { > struct coresight_device *csdev = to_coresight_device(dev); > > - if (cti_assoc_ops && cti_assoc_ops->remove) > - cti_assoc_ops->remove(csdev); > fwnode_handle_put(csdev->dev.fwnode); > kfree(csdev->refcnt); > kfree(csdev); > @@ -1592,6 +1590,8 @@ void coresight_unregister(struct coresight_device *csdev) > { > etm_perf_del_symlink_sink(csdev); > /* Remove references of that device in the topology */ > + if (cti_assoc_ops && cti_assoc_ops->remove) > + cti_assoc_ops->remove(csdev); > coresight_remove_conns(csdev); > coresight_clear_default_sink(csdev); > coresight_release_platform_data(csdev, csdev->pdata); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel