From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65115C433DF for ; Mon, 17 Aug 2020 17:15:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34F36206FA for ; Mon, 17 Aug 2020 17:15:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1lbEmPuR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DSu8wGqA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34F36206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M16sbUiOfiQdp8O6XxUfLpmNveH4qR++DD+fC7tAyeE=; b=1lbEmPuRAffcvbpHaNd7xHRJo rwhNxIBuSVJdCydNh/Ikl/yeHafe+CtjP8zfpCXJ3Frwx2zGA+JRdAh6vgvcL2TH/DQL2whhUiEAn OdRCr61BgFOZzVeTRvQn0VO4Jqzz8KT50geLqS6vDpuPdWyks4CiMWhVtsPzdQ/EdnJtN55oOPGVv UZJQOxal5Rqf4Xkh/WAi0UAAdLjpn9NBw+ktFoxn3B5jVj7kYyVBPeVSqXlc4OuKtH2J5zSRRqjzb h6Xgwwvcd81Ld+K9THzzrLlzG8MCsb2ZmshBILZ6hcEpIejCap7zfECcO+44VlcjnxMKc+Qv7T3bK OQc/3ipZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7ihp-0001K3-1z; Mon, 17 Aug 2020 17:13:57 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7ihl-0001Il-Ed for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 17:13:55 +0000 Received: by mail-pj1-x1044.google.com with SMTP id mw10so7974841pjb.2 for ; Mon, 17 Aug 2020 10:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tzk5s3/dNKL8Ny5eUmkcLCkmZo/xjsaQ4P7ELQ1hYeo=; b=DSu8wGqAqAx6L/9dZPyayolJ9HitWT6wl8kKkOhqbMStZqWelwIEGBU9KZUqUGnKGS HkkYGchoeMCnW6IJGEtkXPOGPrRsqG7wHN/qdiU9zQdeDtJ3NgnvvrUpNDzftqJwOF8x RkB+Y9PG1YYEvE2r2VmOU7S4KxV+0ZsfeFL2Yo5tMXpuYKJ+BwiPLG3gPq0UX9MCeK35 sii5rntAj3T1lIHrobf5v6UnOVoAyvvDp5CbBIAJj4+crXrOgMgHcEtvn/FQlOjNdKPQ k7c9tUC38DXkGigdWQFarJdpPY/kqjkucUz+lUKXx578R4rBmAz0PsSfDNZXBkdlqHO2 e7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tzk5s3/dNKL8Ny5eUmkcLCkmZo/xjsaQ4P7ELQ1hYeo=; b=lkfl9fyBV02ypiBhsZVYEoaqyPPlp5F2UbYjJ3bHu98VuGTSBPabpob/nfXp3eQwY9 qKKm2/PPzHipQ1nf67dJTq0cnLPADhD5Tp4ezt9+OufKN8y3kwZI2QdrPOzU/r8TUvy8 pxN/zjo/4ToBs7fTQdFaJbOLd8itNsK4RrnwGMXf0Id6Ii7ztj4kWAKNhaMl8VFufh61 5+Mev0r/VVMw21bffMQXQFa+sm5/nl8vEMs43Beg9/2CeHeeHmMjTd+jO2SH2pfB0K/3 BSbYlxgUIaa38HJlvb9tZQSfhizU34GFYJ8xAkKmJnXnG2AV6GqCJGvxkFYpm0BmyhmF X4jA== X-Gm-Message-State: AOAM530SSJKXm411ZZ9/WLY3VpET6Ymb1vEy8eWrFU/ek+y5huE0UZ6Z n/vZoLmaaa2yqwJHUDThP/HT/g== X-Google-Smtp-Source: ABdhPJwyV7cGLPH80kxcrSk5mrd03eZHthyaWfarij4xjzz3eQpE/lZ6L0aEFZobTu33Atqv+95Y7g== X-Received: by 2002:a17:902:9e04:: with SMTP id d4mr11550332plq.296.1597684431493; Mon, 17 Aug 2020 10:13:51 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id c17sm20264807pfp.214.2020.08.17.10.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 10:13:50 -0700 (PDT) Date: Mon, 17 Aug 2020 11:13:48 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 21/24] coresight: cti: allow cti to be built as a module Message-ID: <20200817171348.GE3614061@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-22-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-22-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_131353_819608_CE5DD9D1 X-CRM114-Status: GOOD ( 31.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:50PM +0800, Tingwei Zhang wrote: > Allow to build coresight-cti as a module, for ease of development. > > - Kconfig becomes a tristate, to allow =m > - append -core to source file name to allow module to > be called coresight-cti by the Makefile > - add an cti_remove function, for module unload > - move cti_remove_conn_xrefs to cti_remove > - add a MODULE_DEVICE_TABLE for autoloading on boot > > Signed-off-by: Tingwei Zhang > Tested-by: Mike Leach Mike, Please add a "Reviewed-by" tag once you have reviewed this patch. > --- > drivers/hwtracing/coresight/Kconfig | 5 ++++- > drivers/hwtracing/coresight/Makefile | 4 ++-- > .../{coresight-cti.c => coresight-cti-core.c} | 19 ++++++++++++++++++- > .../hwtracing/coresight/coresight-platform.c | 1 + > drivers/hwtracing/coresight/coresight.c | 1 + > 5 files changed, 26 insertions(+), 4 deletions(-) > rename drivers/hwtracing/coresight/{coresight-cti.c => coresight-cti-core.c} (98%) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index f31778dd0b5d..b04aae2ceecc 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -136,7 +136,7 @@ config CORESIGHT_CPU_DEBUG > module will be called coresight-cpu-debug. > > config CORESIGHT_CTI > - bool "CoreSight Cross Trigger Interface (CTI) driver" > + tristate "CoreSight Cross Trigger Interface (CTI) driver" > depends on ARM || ARM64 > help > This driver provides support for CoreSight CTI and CTM components. > @@ -147,6 +147,9 @@ config CORESIGHT_CTI > halt compared to disabling sources and sinks normally in driver > software. > > + To compile this driver as a module, choose M here: the > + module will be called coresight-cti. > + > config CORESIGHT_CTI_INTEGRATION_REGS > bool "Access CTI CoreSight Integration Registers" > depends on CORESIGHT_CTI > diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile > index f2a568b969c4..0359d5a1588f 100644 > --- a/drivers/hwtracing/coresight/Makefile > +++ b/drivers/hwtracing/coresight/Makefile > @@ -19,6 +19,6 @@ coresight-etm4x-y := coresight-etm4x-core.o coresight-etm4x-sysfs.o > obj-$(CONFIG_CORESIGHT_STM) += coresight-stm.o > obj-$(CONFIG_CORESIGHT_CPU_DEBUG) += coresight-cpu-debug.o > obj-$(CONFIG_CORESIGHT_CATU) += coresight-catu.o > -obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o \ > - coresight-cti-platform.o \ > +obj-$(CONFIG_CORESIGHT_CTI) += coresight-cti.o > +coresight-cti-y := coresight-cti-core.o coresight-cti-platform.o \ > coresight-cti-sysfs.o Please align "coresight-cti-sysfs.o" with "coresight-cti-core.o". The same should be done for the etm3x driver. > diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti-core.c > similarity index 98% > rename from drivers/hwtracing/coresight/coresight-cti.c > rename to drivers/hwtracing/coresight/coresight-cti-core.c > index 6bb06c5715db..ca31da6cf1c0 100644 > --- a/drivers/hwtracing/coresight/coresight-cti.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -838,7 +838,6 @@ static void cti_device_release(struct device *dev) > struct cti_drvdata *ect_item, *ect_tmp; > > mutex_lock(&ect_mutex); > - cti_remove_conn_xrefs(drvdata); > cti_pm_release(drvdata); > > /* remove from the list */ > @@ -853,6 +852,18 @@ static void cti_device_release(struct device *dev) > if (drvdata->csdev_release) > drvdata->csdev_release(dev); > } > +static int __exit cti_remove(struct amba_device *adev) > +{ > + struct cti_drvdata *drvdata = dev_get_drvdata(&adev->dev); > + > + mutex_lock(&ect_mutex); > + cti_remove_conn_xrefs(drvdata); > + mutex_unlock(&ect_mutex); The changelog point out this change but now _why_ it is done - please revise. > + > + coresight_unregister(drvdata->csdev); > + > + return 0; > +} > > static int cti_probe(struct amba_device *adev, const struct amba_id *id) > { > @@ -972,6 +983,7 @@ static const struct amba_id cti_ids[] = { > CS_AMBA_UCI_ID(0x000bb9ed, uci_id_cti), /* Coresight CTI (SoC 600) */ > { 0, 0}, > }; > +MODULE_DEVICE_TABLE(amba, cti_ids); > > static struct amba_driver cti_driver = { > .drv = { > @@ -980,6 +992,7 @@ static struct amba_driver cti_driver = { > .suppress_bind_attrs = true, > }, > .probe = cti_probe, > + .remove = cti_remove, > .id_table = cti_ids, > }; > > @@ -1002,3 +1015,7 @@ static void __exit cti_exit(void) > > module_init(cti_init); > module_exit(cti_exit); > + > +MODULE_AUTHOR("Mike Leach "); > +MODULE_DESCRIPTION("Arm CoreSight CTI Driver"); > +MODULE_LICENSE("GPL v2"); > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index bfd44231d7ad..635d55c1d580 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -75,6 +75,7 @@ coresight_find_csdev_by_fwnode(struct fwnode_handle *r_fwnode) > } > return csdev; > } > +EXPORT_SYMBOL_GPL(coresight_find_csdev_by_fwnode); > > #ifdef CONFIG_OF > static inline bool of_coresight_legacy_ep_is_input(struct device_node *ep) > diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c > index 8dcd73ea33b4..f9566d667261 100644 > --- a/drivers/hwtracing/coresight/coresight.c > +++ b/drivers/hwtracing/coresight/coresight.c > @@ -289,6 +289,7 @@ void coresight_set_assoc_ectdev_mutex(struct coresight_device *csdev, > csdev->ect_dev = ect_csdev; > mutex_unlock(&coresight_mutex); > } > +EXPORT_SYMBOL_GPL(coresight_set_assoc_ectdev_mutex); > > static int coresight_enable_sink(struct coresight_device *csdev, > u32 mode, void *data) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel