From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E97B5C433E3 for ; Mon, 17 Aug 2020 17:41:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE94720716 for ; Mon, 17 Aug 2020 17:41:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tW9jl9p1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cV2JiPEE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE94720716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LyXrdm8GwHLuf1yiLPsi0bsHAgRDfbVH3SzbObX9Iuw=; b=tW9jl9p1pRpyagsHDdUw0IFD6 1oFWR4f6bfjwFid3x4wzDFLgrSuarwEbvChMs530cW8d3h7czPiD0Zvtl49M+wY837Hazf2nEbZvf 3h7E3GipOR5hfxhVRZMnX6/RHa8/ZP/4VyycJbjF6bvGWfyhPEluZ7XuzKe66V2v5Olxmg3uep4i/ IGrSW1N5pD8D+a37zyCi+XJGnqo+5Mw8MZ7ecQv/tVR+oWICFAWbzt74I0WprxnEu9ICTIOIregr6 sHuCHFPaLcJ+eXtOYdJMKcuONzSjdy6PHtg6M1V3/22qYWCjtJ+okFY2fJ7AcIDMbowaSL1JpA7RC pbKkZnDhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7j6m-0007sU-4N; Mon, 17 Aug 2020 17:39:44 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7j6j-0007rc-Aw for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 17:39:42 +0000 Received: by mail-pj1-x1042.google.com with SMTP id c10so8196680pjn.1 for ; Mon, 17 Aug 2020 10:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ae6naw4dL8huuFCbiT88swJz3aKjksFi8hnZwxuUWIw=; b=cV2JiPEEKedtnXJYOXAxY2hK10L+bmPdVmmG1boEjmVdmLHETCWQuw+ZeE5s4C+RAn mNb/ruT94pcIquiEod8NyieVHaB6IV2NrwERa5T73AY6+5qYDNjPqFcAMBmYfD7kzVPX w2gUyJtLBAChnG9ZTSZdTSeeqkgcEznNG22qv8h8EvZAiSLtvSjJodUJ1Q4MKKAw0x/1 Jv8j9HDrpTn5PcKJ8chJorJlNaP5OkpynVP1PNwgS6tACz87OjtxDVrJg0HiVnLQ+zfT fSOOmRVTwBWTYbccFkth16UqXXszlRixX67H+sT3qfJKiqk4KEkEXDnngj/hGFfN/dNx PQJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ae6naw4dL8huuFCbiT88swJz3aKjksFi8hnZwxuUWIw=; b=g7P9Xe91Y6ssR8j5ZH6DrvSLiiDW5VoXmN0HlhYVloDk5+uR3tPbPsZIxXVgNm0/R2 avcti2vHbWxwft8ab2Xr6nbUNiiLd53mpd5+Kb2H28f1eU3Q7AW3kV/SQoAfrs3pV9Uz D7W58UjrNr710TKcWetPSMEYwdvzNTrLGArvSWhneBY2G4RkoZgOvUzPcZ7SvMveNrKr PnfPTJGHOqkA4Ntxwsg+fBpQvsvz615S4TOq5GHK7iSxrqduOvgq/RANcEbHRI6fa6SQ pw6hwKhk/ZxM/jSKGBBk3EVrUOhpSaXXSHudFQhOwenfIPuTyfzm1Fr9RW0j2OkYhYt0 KXWg== X-Gm-Message-State: AOAM532sTFlakwGKyH/AlQastsjfvfomZKkBj2fGYSJKE5VJe5BDyUwr fPTuKg0tvsdgE0HUi1+6ZQl9kw== X-Google-Smtp-Source: ABdhPJw9Eq+n2+YQlBXMH3wOksltWZ2sr9AnV5onO2VOgYPbaWKUn5lOt7MoLLnxlwsZRTURuoLBWQ== X-Received: by 2002:a17:90a:d986:: with SMTP id d6mr12624830pjv.134.1597685978977; Mon, 17 Aug 2020 10:39:38 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id u4sm12816891pgo.53.2020.08.17.10.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 10:39:38 -0700 (PDT) Date: Mon, 17 Aug 2020 11:39:36 -0600 From: Mathieu Poirier To: Tingwei Zhang Subject: Re: [PATCH v8 23/24] coresight: catu: allow catu drivers to be built as modules Message-ID: <20200817173936.GF3614061@xps15> References: <20200807111153.7784-1-tingwei@codeaurora.org> <20200807111153.7784-24-tingwei@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200807111153.7784-24-tingwei@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_133941_409853_6F72F200 X-CRM114-Status: GOOD ( 25.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 07, 2020 at 07:11:52PM +0800, Tingwei Zhang wrote: > Allow to build coresight-catu as modules, for ease of development. > - Kconfig becomes a tristate, to allow =m > - add catu_remove functions, for module unload > - add a MODULE_DEVICE_TABLE for autoloading on boot > > Signed-off-by: Tingwei Zhang > Reviewed-by: Mike Leach > Reviewed-by: Suzuki K Poulose For patches 22 and 23: Reviewed-by: Mathieu Poirier > --- > drivers/hwtracing/coresight/Kconfig | 5 ++++- > drivers/hwtracing/coresight/coresight-catu.c | 15 +++++++++++++++ > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index b04aae2ceecc..dfe407cde262 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -42,7 +42,7 @@ config CORESIGHT_LINK_AND_SINK_TMC > module will be called coresight-tmc. > > config CORESIGHT_CATU > - bool "Coresight Address Translation Unit (CATU) driver" > + tristate "Coresight Address Translation Unit (CATU) driver" > depends on CORESIGHT_LINK_AND_SINK_TMC > help > Enable support for the Coresight Address Translation Unit (CATU). > @@ -52,6 +52,9 @@ config CORESIGHT_CATU > by looking up the provided table. CATU can also be used in pass-through > mode where the address is not translated. > > + To compile this driver as a module, choose M here: the > + module will be called coresight-catu. > + > config CORESIGHT_SINK_TPIU > tristate "Coresight generic TPIU driver" > depends on CORESIGHT_LINKS_AND_SINKS > diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c > index 47696a7d24a7..99430f6cf5a5 100644 > --- a/drivers/hwtracing/coresight/coresight-catu.c > +++ b/drivers/hwtracing/coresight/coresight-catu.c > @@ -567,11 +567,21 @@ static int catu_probe(struct amba_device *adev, const struct amba_id *id) > return ret; > } > > +static int __exit catu_remove(struct amba_device *adev) > +{ > + struct catu_drvdata *drvdata = dev_get_drvdata(&adev->dev); > + > + coresight_unregister(drvdata->csdev); > + return 0; > +} > + > static struct amba_id catu_ids[] = { > CS_AMBA_ID(0x000bb9ee), > {}, > }; > > +MODULE_DEVICE_TABLE(amba, catu_ids); > + > static struct amba_driver catu_driver = { > .drv = { > .name = "coresight-catu", > @@ -579,6 +589,7 @@ static struct amba_driver catu_driver = { > .suppress_bind_attrs = true, > }, > .probe = catu_probe, > + .remove = catu_remove, > .id_table = catu_ids, > }; > > @@ -601,3 +612,7 @@ static void __exit catu_exit(void) > > module_init(catu_init); > module_exit(catu_exit); > + > +MODULE_AUTHOR("Suzuki K Poulose "); > +MODULE_DESCRIPTION("Arm CoreSight Address Translation Unit (CATU) Driver"); > +MODULE_LICENSE("GPL v2"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel