From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: qemu-ppc@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>,
"Cornelia Huck" <cohuck@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thiago Jung Bauermann" <bauerman@linux.ibm.com>
Subject: [PATCH v4 6/8] sparc/sun4m: Remove main_cpu_reset()
Date: Tue, 18 Aug 2020 00:33:21 -0300 [thread overview]
Message-ID: <20200818033323.336912-7-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20200818033323.336912-1-bauerman@linux.ibm.com>
We rely on cpu_common_reset() to set cs->halted to 0, so main_cpu_reset()
is pointless.
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
---
hw/sparc/sun4m.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/hw/sparc/sun4m.c b/hw/sparc/sun4m.c
index 9be930415f..f1d92df781 100644
--- a/hw/sparc/sun4m.c
+++ b/hw/sparc/sun4m.c
@@ -218,15 +218,6 @@ static void dummy_cpu_set_irq(void *opaque, int irq, int level)
{
}
-static void main_cpu_reset(void *opaque)
-{
- SPARCCPU *cpu = opaque;
- CPUState *cs = CPU(cpu);
-
- cpu_reset(cs);
- cs->halted = 0;
-}
-
static void secondary_cpu_reset(void *opaque)
{
SPARCCPU *cpu = opaque;
@@ -827,9 +818,7 @@ static void cpu_devinit(const char *cpu_type, unsigned int id,
env = &cpu->env;
cpu_sparc_set_id(env, id);
- if (id == 0) {
- qemu_register_reset(main_cpu_reset, cpu);
- } else {
+ if (id != 0) {
qemu_register_reset(secondary_cpu_reset, cpu);
cs = CPU(cpu);
cs->halted = 1;
next prev parent reply other threads:[~2020-08-18 3:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 3:33 [PATCH v4 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-08-18 3:33 ` [PATCH v4 1/8] target/arm: Move start-powered-off property to generic CPUState Thiago Jung Bauermann
2020-08-18 3:33 ` [PATCH v4 2/8] target/arm: Move setting of CPU halted state to generic code Thiago Jung Bauermann
2020-08-18 3:33 ` [PATCH v4 3/8] ppc/spapr: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-08-18 3:33 ` [PATCH v4 4/8] ppc/e500: " Thiago Jung Bauermann
2020-08-18 7:22 ` Philippe Mathieu-Daudé
2020-08-18 7:28 ` Philippe Mathieu-Daudé
2020-08-18 23:06 ` Thiago Jung Bauermann
2020-08-18 23:14 ` Thiago Jung Bauermann
2020-08-18 10:26 ` Igor Mammedov
2020-08-18 11:02 ` Igor Mammedov
2020-08-18 22:40 ` Thiago Jung Bauermann
2020-08-18 3:33 ` [PATCH v4 5/8] mips/cps: " Thiago Jung Bauermann
2020-08-18 7:26 ` Philippe Mathieu-Daudé
2020-08-18 11:03 ` Philippe Mathieu-Daudé
2020-08-18 11:06 ` Philippe Mathieu-Daudé
2020-08-19 0:12 ` Thiago Jung Bauermann
2020-08-18 3:33 ` Thiago Jung Bauermann [this message]
2020-08-18 3:33 ` [PATCH v4 7/8] sparc/sun4m: " Thiago Jung Bauermann
2020-08-18 7:27 ` Philippe Mathieu-Daudé
2020-08-18 3:33 ` [PATCH v4 8/8] target/s390x: " Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818033323.336912-7-bauerman@linux.ibm.com \
--to=bauerman@linux.ibm.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.