From: kernel test robot <lkp@intel.com> To: "Eric W. Biederman" <ebiederm@xmission.com>, linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org, criu@openvz.org, bpf@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>, Christian Brauner <christian.brauner@ubuntu.com>, Oleg Nesterov <oleg@redhat.com>, Cyrill Gorcunov <gorcunov@gmail.com>, Jann Horn <jann@thejh.net>, Kees Cook <keescook@chromium.org> Subject: Re: [PATCH 11/17] bpf/task_iter: In task_file_seq_get_next use fnext_task Date: Tue, 18 Aug 2020 13:39:44 +0800 [thread overview] Message-ID: <202008181316.x96Qp7qo%lkp@intel.com> (raw) In-Reply-To: <20200817220425.9389-11-ebiederm@xmission.com> [-- Attachment #1: Type: text/plain, Size: 2935 bytes --] Hi "Eric, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf/master] [also build test WARNING on linus/master v5.9-rc1 next-20200817] [cannot apply to bpf-next/master linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Eric-W-Biederman/exec-Move-unshare_files-to-fix-posix-file-locking-during-exec/20200818-061552 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: i386-randconfig-m021-20200818 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> smatch warnings: kernel/bpf/task_iter.c:162 task_file_seq_get_next() warn: ignoring unreachable code. # https://github.com/0day-ci/linux/commit/66f80aa453b17f8932b42e18265dba5fdb32490e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Eric-W-Biederman/exec-Move-unshare_files-to-fix-posix-file-locking-during-exec/20200818-061552 git checkout 66f80aa453b17f8932b42e18265dba5fdb32490e vim +162 kernel/bpf/task_iter.c 128 129 static struct file * 130 task_file_seq_get_next(struct bpf_iter_seq_task_file_info *info, 131 struct task_struct **task) 132 { 133 struct pid_namespace *ns = info->common.ns; 134 u32 curr_tid = info->tid; 135 struct task_struct *curr_task; 136 unsigned int curr_fd = info->fd; 137 138 /* If this function returns a non-NULL file object, 139 * it held a reference to the task/file. 140 * Otherwise, it does not hold any reference. 141 */ 142 again: 143 if (*task) { 144 curr_task = *task; 145 curr_fd = info->fd; 146 } else { 147 curr_task = task_seq_get_next(ns, &curr_tid); 148 if (!curr_task) 149 return NULL; 150 151 /* set *task and info->tid */ 152 *task = curr_task; 153 if (curr_tid == info->tid) { 154 curr_fd = info->fd; 155 } else { 156 info->tid = curr_tid; 157 curr_fd = 0; 158 } 159 } 160 161 rcu_read_lock(); > 162 for (;; curr_fd++) { 163 struct file *f; 164 165 f = fnext_task(curr_task, &curr_fd); 166 if (!f) 167 break; 168 169 /* set info->fd */ 170 info->fd = curr_fd; 171 get_file(f); 172 rcu_read_unlock(); 173 return f; 174 } 175 176 /* the current task is done, go to the next task */ 177 rcu_read_unlock(); 178 put_task_struct(curr_task); 179 *task = NULL; 180 info->fd = 0; 181 curr_tid = ++(info->tid); 182 goto again; 183 } 184 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 33440 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 11/17] bpf/task_iter: In task_file_seq_get_next use fnext_task Date: Tue, 18 Aug 2020 13:39:44 +0800 [thread overview] Message-ID: <202008181316.x96Qp7qo%lkp@intel.com> (raw) In-Reply-To: <20200817220425.9389-11-ebiederm@xmission.com> [-- Attachment #1: Type: text/plain, Size: 3026 bytes --] Hi "Eric, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf/master] [also build test WARNING on linus/master v5.9-rc1 next-20200817] [cannot apply to bpf-next/master linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Eric-W-Biederman/exec-Move-unshare_files-to-fix-posix-file-locking-during-exec/20200818-061552 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: i386-randconfig-m021-20200818 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> smatch warnings: kernel/bpf/task_iter.c:162 task_file_seq_get_next() warn: ignoring unreachable code. # https://github.com/0day-ci/linux/commit/66f80aa453b17f8932b42e18265dba5fdb32490e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Eric-W-Biederman/exec-Move-unshare_files-to-fix-posix-file-locking-during-exec/20200818-061552 git checkout 66f80aa453b17f8932b42e18265dba5fdb32490e vim +162 kernel/bpf/task_iter.c 128 129 static struct file * 130 task_file_seq_get_next(struct bpf_iter_seq_task_file_info *info, 131 struct task_struct **task) 132 { 133 struct pid_namespace *ns = info->common.ns; 134 u32 curr_tid = info->tid; 135 struct task_struct *curr_task; 136 unsigned int curr_fd = info->fd; 137 138 /* If this function returns a non-NULL file object, 139 * it held a reference to the task/file. 140 * Otherwise, it does not hold any reference. 141 */ 142 again: 143 if (*task) { 144 curr_task = *task; 145 curr_fd = info->fd; 146 } else { 147 curr_task = task_seq_get_next(ns, &curr_tid); 148 if (!curr_task) 149 return NULL; 150 151 /* set *task and info->tid */ 152 *task = curr_task; 153 if (curr_tid == info->tid) { 154 curr_fd = info->fd; 155 } else { 156 info->tid = curr_tid; 157 curr_fd = 0; 158 } 159 } 160 161 rcu_read_lock(); > 162 for (;; curr_fd++) { 163 struct file *f; 164 165 f = fnext_task(curr_task, &curr_fd); 166 if (!f) 167 break; 168 169 /* set info->fd */ 170 info->fd = curr_fd; 171 get_file(f); 172 rcu_read_unlock(); 173 return f; 174 } 175 176 /* the current task is done, go to the next task */ 177 rcu_read_unlock(); 178 put_task_struct(curr_task); 179 *task = NULL; 180 info->fd = 0; 181 curr_tid = ++(info->tid); 182 goto again; 183 } 184 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 33440 bytes --]
next prev parent reply other threads:[~2020-08-18 5:51 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 22:03 exec: Move unshare_files and guarantee files_struct.count is correct Eric W. Biederman 2020-08-17 22:04 ` [PATCH 01/17] exec: Move unshare_files to fix posix file locking during exec Eric W. Biederman 2020-08-18 10:04 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 02/17] exec: Simplify unshare_files Eric W. Biederman 2020-08-18 10:08 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 03/17] exec: Remove reset_files_struct Eric W. Biederman 2020-08-18 10:09 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 04/17] kcmp: In kcmp_epoll_target use fget_task Eric W. Biederman 2020-08-20 21:45 ` Cyrill Gorcunov 2020-08-17 22:04 ` [PATCH 05/17] bpf: In bpf_task_fd_query " Eric W. Biederman 2020-08-17 22:04 ` [PATCH 06/17] file: Implement fcheck_task Eric W. Biederman 2020-08-18 10:37 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 07/17] proc/fd: In tid_fd_mode use fcheck_task Eric W. Biederman 2020-08-18 10:36 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 08/17] proc/fd: In proc_fd_link " Eric W. Biederman 2020-08-18 10:36 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 09/17] file: Implement fnext_task Eric W. Biederman 2020-08-17 23:54 ` Linus Torvalds [not found] ` <875z9g7oln.fsf@x220.int.ebiederm.org> 2020-08-18 1:17 ` Linus Torvalds 2020-08-18 11:05 ` Christian Brauner [not found] ` <87pn7m22kn.fsf@x220.int.ebiederm.org> 2020-08-19 15:54 ` Alexei Starovoitov [not found] ` <871rk0t45v.fsf@x220.int.ebiederm.org> 2020-08-21 16:17 ` Alexei Starovoitov 2020-08-19 18:32 ` Linus Torvalds 2020-08-20 21:50 ` Cyrill Gorcunov 2020-08-17 22:04 ` [PATCH 10/17] proc/fd: In proc_readfd_common use fnext_task Eric W. Biederman 2020-08-18 2:22 ` Al Viro [not found] ` <87sgck4o23.fsf@x220.int.ebiederm.org> 2020-08-18 4:59 ` Alexei Starovoitov 2020-08-17 22:04 ` [PATCH 11/17] bpf/task_iter: In task_file_seq_get_next " Eric W. Biederman 2020-08-18 5:39 ` kernel test robot [this message] 2020-08-18 5:39 ` kernel test robot 2020-08-18 12:54 ` Eric W. Biederman 2020-08-18 12:54 ` Eric W. Biederman 2020-08-17 22:04 ` [PATCH 12/17] proc/fd: In fdinfo seq_show don't use get_files_struct Eric W. Biederman 2020-08-18 0:08 ` Linus Torvalds [not found] ` <87v9hg69ph.fsf@x220.int.ebiederm.org> 2020-08-18 1:21 ` Linus Torvalds 2020-08-18 10:43 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 13/17] file: Remove get_files_struct Eric W. Biederman 2020-08-18 10:39 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 14/17] file: Merge __fd_install into fd_install Eric W. Biederman 2020-08-18 10:15 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 15/17] file: In f_dupfd read RLIMIT_NOFILE once Eric W. Biederman 2020-08-18 10:12 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 16/17] file: Merge __alloc_fd into alloc_fd Eric W. Biederman 2020-08-18 10:17 ` Christian Brauner 2020-08-17 22:04 ` [PATCH 17/17] file: Rename __close_fd to close_fd and remove the files parameter Eric W. Biederman 2020-08-18 10:19 ` Christian Brauner 2020-08-18 11:20 ` Christoph Hellwig 2020-08-18 12:48 ` Eric W. Biederman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202008181316.x96Qp7qo%lkp@intel.com \ --to=lkp@intel.com \ --cc=bpf@vger.kernel.org \ --cc=christian.brauner@ubuntu.com \ --cc=criu@openvz.org \ --cc=ebiederm@xmission.com \ --cc=gorcunov@gmail.com \ --cc=jann@thejh.net \ --cc=kbuild-all@lists.01.org \ --cc=keescook@chromium.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=oleg@redhat.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.