From: Tong Zhang <ztong0001@gmail.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, linux-serial@vger.kernel.org
Cc: ztong0001@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH v3] tty: serial: earlycon dependency
Date: Tue, 18 Aug 2020 12:25:57 -0400 [thread overview]
Message-ID: <20200818162556.6621-1-ztong0001@gmail.com> (raw)
In-Reply-To: <20200818111954.GA283417@kroah.com>
parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
should automatically select SERIAL_CORE, otherwise will result in symbol
not found error during linking if SERIAL_CORE is not configured as builtin.
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
Fixes: 9aac5887595b ("tty/serial: add generic serial earlycon")
v2: I made an attempt to fix the commit log
v3: I made another attempt to fix the commit log and I also changed
select to depends according to Jiri's comment
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 8a0352eb337c..6aed721e9287 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -8,6 +8,7 @@ menu "Serial drivers"
config SERIAL_EARLYCON
bool
+ depends SERIAL_CORE
help
Support for early consoles with the earlycon parameter. This enables
the console before standard serial driver is probed. The console is
--
2.25.1
next prev parent reply other threads:[~2020-08-18 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 16:50 [PATCH] tty: serial: fix earlycon dependency Tong Zhang
2020-08-17 17:00 ` Greg KH
2020-08-17 17:25 ` Tong Zhang
2020-08-17 18:54 ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
2020-08-18 5:42 ` Jiri Slaby
2020-08-18 11:19 ` Greg KH
2020-08-18 16:25 ` Tong Zhang [this message]
2020-08-18 18:54 ` [PATCH v4] " Tong Zhang
2020-08-28 8:20 ` Greg KH
2020-08-28 12:39 ` [PATCH v5] " Tong Zhang
2020-08-28 12:41 ` [PATCH v4] " Tong Zhang
2020-08-18 16:27 ` [PATCH v2] Fixes: " Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818162556.6621-1-ztong0001@gmail.com \
--to=ztong0001@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.