From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271C6C433DF for ; Tue, 18 Aug 2020 17:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B69220658 for ; Tue, 18 Aug 2020 17:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728750AbgHRRUn (ORCPT ); Tue, 18 Aug 2020 13:20:43 -0400 Received: from mga07.intel.com ([134.134.136.100]:25860 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728626AbgHRRTf (ORCPT ); Tue, 18 Aug 2020 13:19:35 -0400 IronPort-SDR: bV0i7oYOkdMvwPUo4qFYS8Yu4N3Ceubo7wT6M8FRb+99/Av/JoPCyvajyMFHd+zY+KVRUSDCJb 7dWxgryl5rzQ== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="219269706" X-IronPort-AV: E=Sophos;i="5.76,328,1592895600"; d="scan'208";a="219269706" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 10:19:34 -0700 IronPort-SDR: 8J7Aa2Nrc0djSFRqGqEZJRldDbxlKUWMlH5U8Ia5SimZ5W1JVVcwwb5MQq2YgtnVSetNB5ey4T azlfOYcZWT2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,328,1592895600"; d="scan'208";a="326798922" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 18 Aug 2020 10:19:31 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k858I-009hcq-Fw; Tue, 18 Aug 2020 20:10:46 +0300 Date: Tue, 18 Aug 2020 20:10:46 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , Greg Kroah-Hartman , Guenter Roeck , linux-iio , Linux ARM , Linux Kernel Mailing List , Bartosz Golaszewski Subject: Re: [PATCH v7 1/3] devres: provide devm_krealloc() Message-ID: <20200818171046.GU1891694@smile.fi.intel.com> References: <20200817170535.17041-1-brgl@bgdev.pl> <20200817170535.17041-2-brgl@bgdev.pl> <20200817173908.GS1891694@smile.fi.intel.com> <20200818082500.GB1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 06:27:12PM +0200, Bartosz Golaszewski wrote: > On Tue, Aug 18, 2020 at 10:40 AM Andy Shevchenko > wrote: > > > > On Mon, Aug 17, 2020 at 10:02:05PM +0200, Bartosz Golaszewski wrote: > > > On Mon, Aug 17, 2020 at 7:43 PM Andy Shevchenko > > > wrote: > > > > On Mon, Aug 17, 2020 at 07:05:33PM +0200, Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > ... > > > > > > > +static struct devres *to_devres(void *data) > > > > > +{ > > > > > + return (struct devres *)((u8 *)data - ALIGN(sizeof(struct devres), > > > > > + ARCH_KMALLOC_MINALIGN)); > > > > > > > > Do you really need both explicit castings? > > > > > > > > > > Yeah, we can probably drop the (struct devres *) here. > > > > void * -> u8 * here is also not needed, it is considered byte access IIRC. > > > > Actually it turns out that while we don't need the (void *) -> (u8 *) > casting, we must cast to (struct devres *) or the following error is > produced: > > drivers/base/devres.c: In function ‘to_devres’: > drivers/base/devres.c:41:21: error: returning ‘u8 *’ {aka ‘unsigned > char *’} from a function with incompatible return type ‘struct devres > *’ [-Werror=incompatible-pointer-types] > return ((u8 *)data - ALIGN(sizeof(struct devres), > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ARCH_KMALLOC_MINALIGN)); > ~~~~~~~~~~~~~~~~~~~~~~~ Of course, you have to drop u8 * casting as well. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA007C433DF for ; Tue, 18 Aug 2020 17:21:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86F4220658 for ; Tue, 18 Aug 2020 17:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dAc/ysVQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86F4220658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UuVUq1DdL3yuq2ZQrP4BkJIlAJOdHZR18ybLTlwb3Ms=; b=dAc/ysVQCBNLGoUjBg/aMyFGc 5sYRylidd/3Ve0GMD1I7O16E7ALMro+fveacjIx8vflkXZQ5MzRS2LfrpVstyLjlILMabRtihcMKO AmZiGyGZKcw3CNKS738OQSLdHwOSNkBG8vzYdegVFxE11Rj8XjGEtyXo8DeHeBJeW+PmVzPsK1DJi 46x9tA5/H02qUTqaZ6KMeejTE1VzMtWbazPrCSyGo1aFShXC1+EEBhtBGLBGPmNNakZow1UyHDG2g KmpE64z2qeWNfYzNcPHGvai7CZ4xVBc/JGP4LhKeG0Bk2XGLyvg7axFIt/iyA9Smd7SzRK7UYQ3JG NG3DjyYJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k85Gt-0007DM-CD; Tue, 18 Aug 2020 17:19:39 +0000 Received: from mga11.intel.com ([192.55.52.93]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k85Gq-0007C4-Hs for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 17:19:37 +0000 IronPort-SDR: Nq8V9uk5DVNYJZrY9sU9f1Db1WO/Uh6xDkCD9e545fOQWyaoZbKO72wqJD6B9QITQJlMaqRttO p+fRS9221XxA== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="152586528" X-IronPort-AV: E=Sophos;i="5.76,328,1592895600"; d="scan'208";a="152586528" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2020 10:19:34 -0700 IronPort-SDR: 8J7Aa2Nrc0djSFRqGqEZJRldDbxlKUWMlH5U8Ia5SimZ5W1JVVcwwb5MQq2YgtnVSetNB5ey4T azlfOYcZWT2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,328,1592895600"; d="scan'208";a="326798922" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 18 Aug 2020 10:19:31 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k858I-009hcq-Fw; Tue, 18 Aug 2020 20:10:46 +0300 Date: Tue, 18 Aug 2020 20:10:46 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Subject: Re: [PATCH v7 1/3] devres: provide devm_krealloc() Message-ID: <20200818171046.GU1891694@smile.fi.intel.com> References: <20200817170535.17041-1-brgl@bgdev.pl> <20200817170535.17041-2-brgl@bgdev.pl> <20200817173908.GS1891694@smile.fi.intel.com> <20200818082500.GB1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_131936_730049_24BE398A X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Lars-Peter Clausen , linux-iio , Greg Kroah-Hartman , Michal Simek , Linux Kernel Mailing List , Bartosz Golaszewski , Guenter Roeck , Peter Meerwald-Stadler , Hartmut Knaack , Jonathan Cameron Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgMTgsIDIwMjAgYXQgMDY6Mjc6MTJQTSArMDIwMCwgQmFydG9zeiBHb2xhc3pl d3NraSB3cm90ZToKPiBPbiBUdWUsIEF1ZyAxOCwgMjAyMCBhdCAxMDo0MCBBTSBBbmR5IFNoZXZj aGVua28KPiA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4g PiBPbiBNb24sIEF1ZyAxNywgMjAyMCBhdCAxMDowMjowNVBNICswMjAwLCBCYXJ0b3N6IEdvbGFz emV3c2tpIHdyb3RlOgo+ID4gPiBPbiBNb24sIEF1ZyAxNywgMjAyMCBhdCA3OjQzIFBNIEFuZHkg U2hldmNoZW5rbwo+ID4gPiA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPiB3cm90 ZToKPiA+ID4gPiBPbiBNb24sIEF1ZyAxNywgMjAyMCBhdCAwNzowNTozM1BNICswMjAwLCBCYXJ0 b3N6IEdvbGFzemV3c2tpIHdyb3RlOgo+ID4gPiA+ID4gRnJvbTogQmFydG9zeiBHb2xhc3pld3Nr aSA8YmdvbGFzemV3c2tpQGJheWxpYnJlLmNvbT4KPiA+Cj4gPiAuLi4KPiA+Cj4gPiA+ID4gPiAr c3RhdGljIHN0cnVjdCBkZXZyZXMgKnRvX2RldnJlcyh2b2lkICpkYXRhKQo+ID4gPiA+ID4gK3sK PiA+ID4gPiA+ICsgICAgIHJldHVybiAoc3RydWN0IGRldnJlcyAqKSgodTggKilkYXRhIC0gQUxJ R04oc2l6ZW9mKHN0cnVjdCBkZXZyZXMpLAo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBUkNIX0tNQUxMT0NfTUlOQUxJR04pKTsKPiA+ ID4gPgo+ID4gPiA+IERvIHlvdSByZWFsbHkgbmVlZCBib3RoIGV4cGxpY2l0IGNhc3RpbmdzPwo+ ID4gPiA+Cj4gPiA+Cj4gPiA+IFllYWgsIHdlIGNhbiBwcm9iYWJseSBkcm9wIHRoZSAoc3RydWN0 IGRldnJlcyAqKSBoZXJlLgo+ID4KPiA+IHZvaWQgKiAtPiB1OCAqIGhlcmUgaXMgYWxzbyBub3Qg bmVlZGVkLCBpdCBpcyBjb25zaWRlcmVkIGJ5dGUgYWNjZXNzIElJUkMuCj4gPgo+IAo+IEFjdHVh bGx5IGl0IHR1cm5zIG91dCB0aGF0IHdoaWxlIHdlIGRvbid0IG5lZWQgdGhlICh2b2lkICopIC0+ ICh1OCAqKQo+IGNhc3RpbmcsIHdlIG11c3QgY2FzdCB0byAoc3RydWN0IGRldnJlcyAqKSBvciB0 aGUgZm9sbG93aW5nIGVycm9yIGlzCj4gcHJvZHVjZWQ6Cj4gCj4gZHJpdmVycy9iYXNlL2RldnJl cy5jOiBJbiBmdW5jdGlvbiDigJh0b19kZXZyZXPigJk6Cj4gZHJpdmVycy9iYXNlL2RldnJlcy5j OjQxOjIxOiBlcnJvcjogcmV0dXJuaW5nIOKAmHU4ICrigJkge2FrYSDigJh1bnNpZ25lZAo+IGNo YXIgKuKAmX0gZnJvbSBhIGZ1bmN0aW9uIHdpdGggaW5jb21wYXRpYmxlIHJldHVybiB0eXBlIOKA mHN0cnVjdCBkZXZyZXMKPiAq4oCZIFstV2Vycm9yPWluY29tcGF0aWJsZS1wb2ludGVyLXR5cGVz XQo+ICAgcmV0dXJuICgodTggKilkYXRhIC0gQUxJR04oc2l6ZW9mKHN0cnVjdCBkZXZyZXMpLAo+ ICAgICAgICAgIH5+fn5+fn5+fn5+fl5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+ICAg ICAgICAgQVJDSF9LTUFMTE9DX01JTkFMSUdOKSk7Cj4gICAgICAgICB+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fgoKT2YgY291cnNlLCB5b3UgaGF2ZSB0byBkcm9wIHU4ICogY2FzdGluZyBhcyB3ZWxs LgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28KCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=