Re: [RFC PATCH v4 1/3] xfs: get rid of unused pagi_unlinked_hash

From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Gao Xiang <hsiangkao@redhat.com>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
	Brian Foster <bfoster@redhat.com>
Subject: Re: [RFC PATCH v4 1/3] xfs: get rid of unused pagi_unlinked_hash
Date: Tue, 18 Aug 2020 17:54:03 -0700 (PDT)	[thread overview]
Message-ID: <20200819005403.GB6096@magnolia> (raw)
In-Reply-To: <20200818133015.25398-2-hsiangkao@redhat.com>

On Tue, Aug 18, 2020 at 09:30:13PM +0800, Gao Xiang wrote:
> pagi_unlinked_hash is unused since no backref infrastructure now.
> (it's better to fold it into original patchset.)
> 
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>

Yes, this should be folded into the other patch that gets rid of the
rest of the rhash code.  Dave?

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_mount.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index c35a6c463529..98109801a995 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -372,13 +372,6 @@ typedef struct xfs_perag {
>  
>  	/* reference count */
>  	uint8_t			pagf_refcount_level;
> -
> -	/*
> -	 * Unlinked inode information.  This incore information reflects
> -	 * data stored in the AGI, so callers must hold the AGI buffer lock
> -	 * or have some other means to control concurrency.
> -	 */
> -	struct rhashtable	pagi_unlinked_hash;
>  } xfs_perag_t;
>  
>  static inline struct xfs_ag_resv *
> -- 
> 2.18.1
> 