All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: Fix missing function declaration
@ 2020-08-19  8:00 Leon Romanovsky
  2020-08-19  8:46 ` Anshuman Khandual
  0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2020-08-19  8:00 UTC (permalink / raw)
  To: Andrew Morton, Jinbum Park, Kees Cook
  Cc: Leon Romanovsky, linux-mm, linux-kernel

From: Leon Romanovsky <leonro@nvidia.com>

The compilation with CONFIG_DEBUG_RODATA_TEST set produces the following
warning due to the missing include.

 mm/rodata_test.c:15:6: warning: no previous prototype for 'rodata_test' [-Wmissing-prototypes]
    15 | void rodata_test(void)
      |      ^~~~~~~~~~~

Fixes: 2959a5f726f6 ("mm: add arch-independent testcases for RODATA")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 mm/rodata_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/rodata_test.c b/mm/rodata_test.c
index 2a99df7beeb3..2613371945b7 100644
--- a/mm/rodata_test.c
+++ b/mm/rodata_test.c
@@ -7,6 +7,7 @@
  */
 #define pr_fmt(fmt) "rodata_test: " fmt

+#include <linux/rodata_test.h>
 #include <linux/uaccess.h>
 #include <asm/sections.h>

--
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: Fix missing function declaration
  2020-08-19  8:00 [PATCH] mm: Fix missing function declaration Leon Romanovsky
@ 2020-08-19  8:46 ` Anshuman Khandual
  2020-08-19  9:39   ` Leon Romanovsky
  0 siblings, 1 reply; 3+ messages in thread
From: Anshuman Khandual @ 2020-08-19  8:46 UTC (permalink / raw)
  To: Leon Romanovsky, Andrew Morton, Jinbum Park, Kees Cook
  Cc: Leon Romanovsky, linux-mm, linux-kernel



On 08/19/2020 01:30 PM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> The compilation with CONFIG_DEBUG_RODATA_TEST set produces the following
> warning due to the missing include.
> 
>  mm/rodata_test.c:15:6: warning: no previous prototype for 'rodata_test' [-Wmissing-prototypes]
>     15 | void rodata_test(void)
>       |      ^~~~~~~~~~~
> 
> Fixes: 2959a5f726f6 ("mm: add arch-independent testcases for RODATA")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

This build failure appears only with W=1 and gets fixed with this.

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

> ---
>  mm/rodata_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/rodata_test.c b/mm/rodata_test.c
> index 2a99df7beeb3..2613371945b7 100644
> --- a/mm/rodata_test.c
> +++ b/mm/rodata_test.c
> @@ -7,6 +7,7 @@
>   */
>  #define pr_fmt(fmt) "rodata_test: " fmt
> 
> +#include <linux/rodata_test.h>
>  #include <linux/uaccess.h>
>  #include <asm/sections.h>
> 
> --
> 2.26.2
> 
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: Fix missing function declaration
  2020-08-19  8:46 ` Anshuman Khandual
@ 2020-08-19  9:39   ` Leon Romanovsky
  0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2020-08-19  9:39 UTC (permalink / raw)
  To: Anshuman Khandual
  Cc: Andrew Morton, Jinbum Park, Kees Cook, linux-mm, linux-kernel

On Wed, Aug 19, 2020 at 02:16:39PM +0530, Anshuman Khandual wrote:
>
>
> On 08/19/2020 01:30 PM, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > The compilation with CONFIG_DEBUG_RODATA_TEST set produces the following
> > warning due to the missing include.
> >
> >  mm/rodata_test.c:15:6: warning: no previous prototype for 'rodata_test' [-Wmissing-prototypes]
> >     15 | void rodata_test(void)
> >       |      ^~~~~~~~~~~
> >
> > Fixes: 2959a5f726f6 ("mm: add arch-independent testcases for RODATA")
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> This build failure appears only with W=1 and gets fixed with this.

It is our default compilation level for Mellanox RDMA submissions.

>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

Thanks

>
> > ---
> >  mm/rodata_test.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/mm/rodata_test.c b/mm/rodata_test.c
> > index 2a99df7beeb3..2613371945b7 100644
> > --- a/mm/rodata_test.c
> > +++ b/mm/rodata_test.c
> > @@ -7,6 +7,7 @@
> >   */
> >  #define pr_fmt(fmt) "rodata_test: " fmt
> >
> > +#include <linux/rodata_test.h>
> >  #include <linux/uaccess.h>
> >  #include <asm/sections.h>
> >
> > --
> > 2.26.2
> >
> >
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-19  9:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19  8:00 [PATCH] mm: Fix missing function declaration Leon Romanovsky
2020-08-19  8:46 ` Anshuman Khandual
2020-08-19  9:39   ` Leon Romanovsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.