All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Wunderlich <linux@fw-web.de>
To: u-boot@lists.denx.de
Subject: [PATCH v2 03/11] phy: mtk-tphy: make shared reg optional for v1
Date: Wed, 19 Aug 2020 10:02:17 +0200	[thread overview]
Message-ID: <20200819080225.4267-4-linux@fw-web.de> (raw)
In-Reply-To: <20200819080225.4267-1-linux@fw-web.de>

From: Frank Wunderlich <frank-w@public-files.de>

make the shared reg optional when version is v1 for sata

Suggested-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 drivers/phy/phy-mtk-tphy.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/phy-mtk-tphy.c b/drivers/phy/phy-mtk-tphy.c
index 326227a30d..3d7b9cd2b1 100644
--- a/drivers/phy/phy-mtk-tphy.c
+++ b/drivers/phy/phy-mtk-tphy.c
@@ -698,11 +698,10 @@ static int mtk_tphy_probe(struct udevice *dev)
 	tphy->dev = dev;
 	tphy->version = dev_get_driver_data(dev);
 
-	/* v1 has shared banks */
+	/* v1 has shared banks for usb/pcie mode, */
+	/* but not for sata mode */
 	if (tphy->version == MTK_TPHY_V1) {
 		tphy->sif_base = dev_read_addr_ptr(dev);
-		if (!tphy->sif_base)
-			return -ENOENT;
 	}
 
 	dev_for_each_subnode(subnode, dev) {
-- 
2.25.1

  parent reply	other threads:[~2020-08-19  8:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  8:02 [PATCH v2 00/11] Add MTK AHCI driver, BPI-R64 dts and USB-Nodes for mt7622/mt7623 Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 01/11] arm: dts: mt7622: add SATA reset constants Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 02/11] phy: mtk-tphy: add PHY_TYPE_SATA Frank Wunderlich
2020-08-19  8:02 ` Frank Wunderlich [this message]
2020-08-19  8:27   ` [PATCH v2 03/11] phy: mtk-tphy: make shared reg optional for v1 Chunfeng Yun
2020-08-19  8:02 ` [PATCH v2 04/11] reset: add basic reset controller for pciesys Frank Wunderlich
2020-08-19  8:33   ` Sam Shih
2020-08-19 11:04     ` Aw: " Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 05/11] ahci: mediatek: add ahci driver Frank Wunderlich
2020-08-19  8:38   ` Sam Shih
2020-08-19 11:11     ` Aw: " Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 06/11] clk: mt7622: add needed clocks for ssusb-node Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 07/11] arm: dts: add watchdog-reboot node for mt7622 Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 08/11] arm: dts: add dts for Bananapi-R64 Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 09/11] arm: dts: mt7622: add sata- and asm_sel nodes Frank Wunderlich
2020-08-19  8:54   ` Chunfeng Yun
2020-08-19 10:58     ` Aw: " Frank Wunderlich
2020-08-20  1:24       ` Chunfeng Yun
2020-08-19  8:02 ` [PATCH v2 10/11] arm: dts: mt7622: add USB nodes Frank Wunderlich
2020-08-19  8:02 ` [PATCH v2 11/11] arm: dts: mt7623: " Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819080225.4267-4-linux@fw-web.de \
    --to=linux@fw-web.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.