All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jinbum Park <jinb.park7@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Fix missing function declaration
Date: Wed, 19 Aug 2020 12:39:17 +0300	[thread overview]
Message-ID: <20200819093917.GS7555@unreal> (raw)
In-Reply-To: <65caa520-c7de-2703-f528-b2b1714ade65@arm.com>

On Wed, Aug 19, 2020 at 02:16:39PM +0530, Anshuman Khandual wrote:
>
>
> On 08/19/2020 01:30 PM, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > The compilation with CONFIG_DEBUG_RODATA_TEST set produces the following
> > warning due to the missing include.
> >
> >  mm/rodata_test.c:15:6: warning: no previous prototype for 'rodata_test' [-Wmissing-prototypes]
> >     15 | void rodata_test(void)
> >       |      ^~~~~~~~~~~
> >
> > Fixes: 2959a5f726f6 ("mm: add arch-independent testcases for RODATA")
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>
> This build failure appears only with W=1 and gets fixed with this.

It is our default compilation level for Mellanox RDMA submissions.

>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

Thanks

>
> > ---
> >  mm/rodata_test.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/mm/rodata_test.c b/mm/rodata_test.c
> > index 2a99df7beeb3..2613371945b7 100644
> > --- a/mm/rodata_test.c
> > +++ b/mm/rodata_test.c
> > @@ -7,6 +7,7 @@
> >   */
> >  #define pr_fmt(fmt) "rodata_test: " fmt
> >
> > +#include <linux/rodata_test.h>
> >  #include <linux/uaccess.h>
> >  #include <asm/sections.h>
> >
> > --
> > 2.26.2
> >
> >
> >

      reply	other threads:[~2020-08-19  9:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  8:00 Leon Romanovsky
2020-08-19  8:46 ` Anshuman Khandual
2020-08-19  9:39   ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819093917.GS7555@unreal \
    --to=leon@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=jinb.park7@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH] mm: Fix missing function declaration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.