All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: srk@48.io, Andrzej Hajda <a.hajda@samsung.com>,
	devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Sean Cross <xobs@kosagi.com>, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support
Date: Wed, 19 Aug 2020 15:03:13 +0200	[thread overview]
Message-ID: <20200819130313.GA152043@furthur.local> (raw)
In-Reply-To: <20200511074708.GA2759@ravnborg.org>

On Mon, May 11, 2020 at 09:47:08AM +0200, Sam Ravnborg wrote:
> Hi Richard.
> 
> On Sat, May 09, 2020 at 01:18:34PM +0200, srk@48.io wrote:
> > From: Sean Cross <xobs@kosagi.com>
> > 
> > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> > integrated backlight, and connects via eDP.
> > 
> > It is used in the Kosagi Novena.
> 
> Thanks for the patch.
> 
> 
> > 
> > Signed-off-by: Sean Cross <xobs@kosagi.com>
> > Signed-off-by: Richard Marko <srk@48.io>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > To: dri-devel@lists.freedesktop.org
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3ad828eaefe1..c8a93771d398 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = {
> >  	},
> >  };
> >  
> > +static const struct drm_display_mode innolux_n133hse_ea1_mode = {
> > +	.clock = 138500,
> > +	.hdisplay = 1920,
> > +	.hsync_start = 1920 + 46,
> > +	.hsync_end = 1920 + 46 + 30,
> > +	.htotal = 1920 + 46 + 30 + 84,
> > +	.vdisplay = 1080,
> > +	.vsync_start = 1080 + 2,
> > +	.vsync_end = 1080 + 2 + 4,
> > +	.vtotal = 1080 + 2 + 4 + 26,
> > +	.vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc innolux_n133hse_ea1 = {
> > +	.modes = &innolux_n133hse_ea1_mode,
> > +	.num_modes = 1,
> > +	.bpc = 8,
> > +	.size = {
> > +		.width = 293,
> > +		.height = 165,
> > +	},
> > +	.connector_type = DRM_MODE_CONNECTOR_eDP,
> Please include .bus_format and .bus_flags info too.
> 
> We are relying more and more on this type of info so we need it to be
> present.

I am wondering which of the flags make sense for eDP and how the bus
format should be described?

Some eDP panels seems [1] to specify DRM_BUS_FLAG_DATA_MSB_TO_LSB and 
DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, but I am not sure what sense they make
for packet data with embedded clock that eDP uses? (Unless, of course,
my understanding of eDP is entirely missing the point.)

This panel uses RGB888 data over two differential pairs. Would
format = MEDIA_BUS_FMT_RGB888_1X24 be appropriate?

[1] N133HSE-EA1 Datasheet
    http://www.vslcd.com/specification/N133HSE-EA1.pdf

> 	Sam

Thank you,
Lubo

WARNING: multiple messages have this Message-ID (diff)
From: Lubomir Rintel <lkundrak@v3.sk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	srk@48.io, Jonas Karlman <jonas@kwiboo.se>,
	David Airlie <airlied@linux.ie>,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Andrzej Hajda <a.hajda@samsung.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	Sean Cross <xobs@kosagi.com>, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support
Date: Wed, 19 Aug 2020 15:03:13 +0200	[thread overview]
Message-ID: <20200819130313.GA152043@furthur.local> (raw)
In-Reply-To: <20200511074708.GA2759@ravnborg.org>

On Mon, May 11, 2020 at 09:47:08AM +0200, Sam Ravnborg wrote:
> Hi Richard.
> 
> On Sat, May 09, 2020 at 01:18:34PM +0200, srk@48.io wrote:
> > From: Sean Cross <xobs@kosagi.com>
> > 
> > The Innolux N133HSE panel is a 13.3" 1920x1080 panel that contains an
> > integrated backlight, and connects via eDP.
> > 
> > It is used in the Kosagi Novena.
> 
> Thanks for the patch.
> 
> 
> > 
> > Signed-off-by: Sean Cross <xobs@kosagi.com>
> > Signed-off-by: Richard Marko <srk@48.io>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > To: dri-devel@lists.freedesktop.org
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3ad828eaefe1..c8a93771d398 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1906,6 +1906,30 @@ static const struct panel_desc innolux_n116bge = {
> >  	},
> >  };
> >  
> > +static const struct drm_display_mode innolux_n133hse_ea1_mode = {
> > +	.clock = 138500,
> > +	.hdisplay = 1920,
> > +	.hsync_start = 1920 + 46,
> > +	.hsync_end = 1920 + 46 + 30,
> > +	.htotal = 1920 + 46 + 30 + 84,
> > +	.vdisplay = 1080,
> > +	.vsync_start = 1080 + 2,
> > +	.vsync_end = 1080 + 2 + 4,
> > +	.vtotal = 1080 + 2 + 4 + 26,
> > +	.vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc innolux_n133hse_ea1 = {
> > +	.modes = &innolux_n133hse_ea1_mode,
> > +	.num_modes = 1,
> > +	.bpc = 8,
> > +	.size = {
> > +		.width = 293,
> > +		.height = 165,
> > +	},
> > +	.connector_type = DRM_MODE_CONNECTOR_eDP,
> Please include .bus_format and .bus_flags info too.
> 
> We are relying more and more on this type of info so we need it to be
> present.

I am wondering which of the flags make sense for eDP and how the bus
format should be described?

Some eDP panels seems [1] to specify DRM_BUS_FLAG_DATA_MSB_TO_LSB and 
DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE, but I am not sure what sense they make
for packet data with embedded clock that eDP uses? (Unless, of course,
my understanding of eDP is entirely missing the point.)

This panel uses RGB888 data over two differential pairs. Would
format = MEDIA_BUS_FMT_RGB888_1X24 be appropriate?

[1] N133HSE-EA1 Datasheet
    http://www.vslcd.com/specification/N133HSE-EA1.pdf

> 	Sam

Thank you,
Lubo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-08-19 13:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 11:18 [PATCH 0/2] Novena laptop panel srk
2020-05-09 11:18 ` srk
2020-05-09 11:18 ` [PATCH 1/2] dt-bindings: n133hse-ea1: Add Innolux N133HSE panel srk
2020-05-09 11:18   ` srk
2020-05-18 18:28   ` Rob Herring
2020-05-18 18:28     ` Rob Herring
2020-05-09 11:18 ` [PATCH 2/2] drm/panel: simple: Add Innolux N133HSE panel support srk
2020-05-09 11:18   ` srk
2020-05-11  7:47   ` Sam Ravnborg
2020-05-11  7:47     ` Sam Ravnborg
2020-08-19 13:03     ` Lubomir Rintel [this message]
2020-08-19 13:03       ` Lubomir Rintel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819130313.GA152043@furthur.local \
    --to=lkundrak@v3.sk \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@nxp.com \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=shawnguo@kernel.org \
    --cc=srk@48.io \
    --cc=thierry.reding@gmail.com \
    --cc=xobs@kosagi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.