From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8F7C433E4 for ; Wed, 19 Aug 2020 18:17:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11F0320786 for ; Wed, 19 Aug 2020 18:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597861065; bh=5rWJIIL0ujQDBbjyct2vN3s5EEust1hHNeQB7JSOz7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ipCO7j5SrvaOK/ju/ZmrMSbo+22xRPcF3NbULGCGUacwHYfEFevb7Gagd3gZGlt0s 2gxDlFKgLwPA3RYu/DtCT9y8r1xSFekt5cjfYdmfj+VtqHSQpiSshbjlPvaomfQ5CS OtIFmHba7v0jg4KOzCdA44PW/ieLjEql4EiN/IZA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726745AbgHSSRo (ORCPT ); Wed, 19 Aug 2020 14:17:44 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:34268 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgHSSRn (ORCPT ); Wed, 19 Aug 2020 14:17:43 -0400 Received: by mail-ej1-f68.google.com with SMTP id o23so27458564ejr.1; Wed, 19 Aug 2020 11:17:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yl0aiKpy9oU+yX24bKO0Wi0FwOjbsT5HEwJCqJSSr0E=; b=ZioiGYFi+VQXtE2WYt0NrrHBVlMvkFgXwe6a3LgTKenelZIGR/32Vz6VpMctpPIZZf 2mgLd5ka8V2m17ticNnkSDNfXt9/MA0Za4hhnDhHSxOubIh4L6z9CjLGwR5MTB2Nl0/S 4YNA0VSykpsze0Qqu/CQjbm2sm+OtBbIWsO9lERkKDNbloSZd53NfH7wxi24VxdopjOR gbv98nAEfZtWr1i3y6BB8wQHEAL/GTAc4U4YtM2AOfQsoldZW/9Rb1xHt+8RcxCZBjew 6vnta2xVgqXJBtyjZe2KqQuc/Y0AIwzF6XtAk/hj93CHFk+tFMK610oKias0LTfBmdkc fZgg== X-Gm-Message-State: AOAM532BU3fiwFxbk1I8UbH7deRG0RUKZxMYRIYqyFJZutqQnGfbcPYH 9ADMVyszP8mivT/T7WvLpow= X-Google-Smtp-Source: ABdhPJwPrp0tgwpB1iLAmKOegFv4OOS/OWlgOOvq+s6N718YJm5HdBzWfJk3O7jPqez5lMwHUAJGLw== X-Received: by 2002:a17:907:20f5:: with SMTP id rh21mr26001104ejb.194.1597861061058; Wed, 19 Aug 2020 11:17:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id b20sm18281130eds.7.2020.08.19.11.17.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 11:17:40 -0700 (PDT) Date: Wed, 19 Aug 2020 20:17:36 +0200 From: Krzysztof Kozlowski To: Russell King , Kukjin Kim , Simtec Linux Team , Maxime Coquelin , Alexandre Torgue , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-clk@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH v2 07/13] ARM: s3c64xx: switch to generic watchdog driver reset Message-ID: <20200819181736.GB21298@kozik-lap> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-8-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200804192654.12783-8-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Tue, Aug 04, 2020 at 09:26:48PM +0200, Krzysztof Kozlowski wrote: > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > code"), the platform watchdog reset code can be removed in favor of > a generic watchdog driver which already handles reset. > > This allows removal of a bunch of machine code and fixes also W=1 > compile warnings: > > arch/arm/plat-samsung/watchdog-reset.c:29:6: warning: no previous prototype for 'samsung_wdt_reset' [-Wmissing-prototypes] > 29 | void samsung_wdt_reset(void) > arch/arm/plat-samsung/watchdog-reset.c:69:13: warning: no previous prototype for 'samsung_wdt_reset_of_init' [-Wmissing-prototypes] > 69 | void __init samsung_wdt_reset_of_init(void) > arch/arm/plat-samsung/watchdog-reset.c:89:13: warning: no previous prototype for 'samsung_wdt_reset_init' [-Wmissing-prototypes] > 89 | void __init samsung_wdt_reset_init(void __iomem *base) > > The generic watchdog-based system reset is not exactly the same as > before. The previous method had a fallback to soft_restart() which now > is gone. > > The commit also removes a FIXME note about calling s3c64xx_clk_init() > inside s3c64xx_init_irq(). No one fixed this since long time and the > note is not meaningful anymore because watchdog part is removed. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Tomasz Figa Applied. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AB83C433E1 for ; Wed, 19 Aug 2020 18:18:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57D2C20758 for ; Wed, 19 Aug 2020 18:18:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v/gDb8VR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57D2C20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RPkC2Qj/J7XxZSLAs6ZHeDI8lYQ/jDdsx6ipWQwYbH4=; b=v/gDb8VRYuRG/3gYkYXYxSSeb HUHvFxgoVWxv/SXqvQ4PveQUqxiKcY84TRkepCd4X05bsk/0TaCZWzxcP/I5WktJ9MGiqG2VqFDFo BaI/eSTPAMbDc5q5Po71wYQBiLDhnAoFspWl01iIoV8J+VgdplSBzPJSMZ+s0uA4+UF9J/xe3rDLC duTi1luz1/4NcgZcS62/B6sOnom3mYTvuabk+rgHx19sobB6llwQjamHEDtSDjONtxBbKhfFCnZsZ nfNyS/PgckoZOIissJ86m0GHOhcWkGAGyE8lkRJxOalCLjgfF0maJn31HYFpcNmOuZRE20AKvh+tT NvD1DW8OA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8See-0001M6-5d; Wed, 19 Aug 2020 18:17:44 +0000 Received: from mail-ej1-f66.google.com ([209.85.218.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8Sec-0001LM-DL for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 18:17:43 +0000 Received: by mail-ej1-f66.google.com with SMTP id c16so27407264ejx.12 for ; Wed, 19 Aug 2020 11:17:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yl0aiKpy9oU+yX24bKO0Wi0FwOjbsT5HEwJCqJSSr0E=; b=Sg0ADZXuBWtHSU8ClNDrdV52IEritt4+OtuA/+Rlxm4DM6VkWKpYSgQaJIx+UMl5pt +s64uhCwYVMoj2aPY+tqIR1lyW1HUQ50N+l2v7MrTBc4QLjfSEwJ1Cums/rWcF7t2H4j p1QhR+GJps0k4+HU2UwhefDe9qn0JlPqBeeIJ0DoZpJvMk6v0EZRASc0fefCa+X7lDi/ bdeeEFBfUPErv1q33bJfVxXulRNRId7NYDPwkRKMGl6v5IyXRQPnRrxTNbKxXSobJyKD IEddA2iLXvtCbyELYB4/PAJArWlN/cwmRTQ1SxInBf1sH0DiDNvCEhPOb5Vx9su0BQcN L/ig== X-Gm-Message-State: AOAM533lIkDMBqnCywJXgSfrft+qjRAUxSs37P/M3JFwU5WsJnETddMR FFgVkd4b4VPKHsrsZWWciw8= X-Google-Smtp-Source: ABdhPJwPrp0tgwpB1iLAmKOegFv4OOS/OWlgOOvq+s6N718YJm5HdBzWfJk3O7jPqez5lMwHUAJGLw== X-Received: by 2002:a17:907:20f5:: with SMTP id rh21mr26001104ejb.194.1597861061058; Wed, 19 Aug 2020 11:17:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id b20sm18281130eds.7.2020.08.19.11.17.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 11:17:40 -0700 (PDT) Date: Wed, 19 Aug 2020 20:17:36 +0200 From: Krzysztof Kozlowski To: Russell King , Kukjin Kim , Simtec Linux Team , Maxime Coquelin , Alexandre Torgue , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Guenter Roeck , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-clk@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 07/13] ARM: s3c64xx: switch to generic watchdog driver reset Message-ID: <20200819181736.GB21298@kozik-lap> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-8-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200804192654.12783-8-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_141742_485094_372CDACC X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sylwester Nawrocki , Lihua Yao , Cedric Roux , Sergio Prado , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 04, 2020 at 09:26:48PM +0200, Krzysztof Kozlowski wrote: > Similarly to commit f6361c6b3880 ("ARM: S3C24XX: remove separate restart > code"), the platform watchdog reset code can be removed in favor of > a generic watchdog driver which already handles reset. > > This allows removal of a bunch of machine code and fixes also W=1 > compile warnings: > > arch/arm/plat-samsung/watchdog-reset.c:29:6: warning: no previous prototype for 'samsung_wdt_reset' [-Wmissing-prototypes] > 29 | void samsung_wdt_reset(void) > arch/arm/plat-samsung/watchdog-reset.c:69:13: warning: no previous prototype for 'samsung_wdt_reset_of_init' [-Wmissing-prototypes] > 69 | void __init samsung_wdt_reset_of_init(void) > arch/arm/plat-samsung/watchdog-reset.c:89:13: warning: no previous prototype for 'samsung_wdt_reset_init' [-Wmissing-prototypes] > 89 | void __init samsung_wdt_reset_init(void __iomem *base) > > The generic watchdog-based system reset is not exactly the same as > before. The previous method had a fallback to soft_restart() which now > is gone. > > The commit also removes a FIXME note about calling s3c64xx_clk_init() > inside s3c64xx_init_irq(). No one fixed this since long time and the > note is not meaningful anymore because watchdog part is removed. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Tomasz Figa Applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel