From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0E6C433E1 for ; Thu, 20 Aug 2020 07:54:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D9A2076E for ; Thu, 20 Aug 2020 07:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgHTHx7 (ORCPT ); Thu, 20 Aug 2020 03:53:59 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:48990 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726309AbgHTHx5 (ORCPT ); Thu, 20 Aug 2020 03:53:57 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k8fOT-0006ha-6a; Thu, 20 Aug 2020 17:53:54 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 20 Aug 2020 17:53:53 +1000 Date: Thu, 20 Aug 2020 17:53:53 +1000 From: Herbert Xu To: Ard Biesheuvel Cc: Ben Greear , Linux Crypto Mailing List , Eric Biggers Subject: Re: [PATCH 0/5] crypto: Implement cmac based on cbc skcipher Message-ID: <20200820075353.GA21901@gondor.apana.org.au> References: <8b248ef3-d4c7-43fd-6ae4-1c3381597579@candelatech.com> <20200820070142.GA21343@gondor.apana.org.au> <20200820070645.GA21395@gondor.apana.org.au> <20200820072910.GA21631@gondor.apana.org.au> <20200820074414.GA21848@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Aug 20, 2020 at 09:48:02AM +0200, Ard Biesheuvel wrote: > > > Or are you saying on Ben's machine cbc-aesni would have worse > > performance vs. aes-generic? > > > > Yes, given the pathological overhead of FPU preserve/restore for every > block of 16 bytes processed by the cbcmac wrapper. I'm sceptical. Do we have numbers showing this? You can get them from tcrypt with my patch: https://patchwork.kernel.org/patch/11701343/ Just do modprobe tcrypt mode=400 alg='cmac(aes-aesni)' klen=16 modprobe tcrypt mode=400 alg='cmac(aes-generic)' klen=16 > cmac() is not really relevant for performance, afaict. Only cbcmac() > is used for bulk data. Sure but it's trivial to extend my cmac patch to support cbcmac. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt