From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30CAC433E3 for ; Thu, 20 Aug 2020 14:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF2BB2076E for ; Thu, 20 Aug 2020 14:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597932428; bh=uRIasufyJG6jvkmnVHV59NybArRtiZJedVOR4Y+iZ8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=qJUxqX8IT6SYYNa7N2vFGjQN8ejBMfA5EmTWCuFwYESp23xdEkhRX+KDKBwoNUebb +3puFNGU8h+ODy/mYmjfkf9dUxRqsTSgDCD1ujxPdB6SqHwm872KZp60Aa/1R128wi qThzZE/Hp5MtQ5QKuChX9HJhUykLWgGh+0rMrB7o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728567AbgHTOHH (ORCPT ); Thu, 20 Aug 2020 10:07:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:41826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727973AbgHTOHA (ORCPT ); Thu, 20 Aug 2020 10:07:00 -0400 Received: from coco.lan (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D50F20724; Thu, 20 Aug 2020 14:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597932419; bh=uRIasufyJG6jvkmnVHV59NybArRtiZJedVOR4Y+iZ8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nybwFHcJSEQ+sNorK6h28lhlgOTpiFXwa/QO/tmNCoOemIM/jbAkdHKBh4+JqzM63 fIu2sWwL2L3+Fvq0a/Cdzn/Zh3GQqR5WMMxz0DCY7Hfrzr6BZrIpZkKpN1EDCEaauY MvLAi+xqn9f0CHzZuUNAiOvgkUwF/4KSrktIOYUQ= Date: Thu, 20 Aug 2020 16:06:49 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Cc: Greg Kroah-Hartman , Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , Jakub Kicinski , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Liuyao An , Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200820160649.54741194@coco.lan> In-Reply-To: <20200819173558.GA3733@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: I'm already handling the other comments from your review (I'll send a more complete comment about them after finishing), but I have a doubt what you meant about this: > +static int kirin_drm_bind(struct device *dev) > > +{ > > + struct drm_driver *driver = &kirin_drm_driver; > > + struct drm_device *drm_dev; > > + struct kirin_drm_private *priv; > > + int ret; > > + > > + drm_dev = drm_dev_alloc(driver, dev); > > + if (!drm_dev) > > + return -ENOMEM; > > + > > + ret = kirin_drm_kms_init(drm_dev); > > + if (ret) > > + goto err_drm_dev_unref; > > + > > + ret = drm_dev_register(drm_dev, 0); > There is better ways to do this. See drm_drv.c for the code example. Not sure if I understood your comment here. The drm_drv.c example also calls drm_dev_register(). The only difference is that it calls it inside driver_probe(), while on this driver, it uses: static const struct component_master_ops kirin_drm_ops = { .bind = kirin_drm_bind, .unbind = kirin_drm_unbind, }; static int kirin_drm_platform_probe(struct platform_device *pdev) { ... drm_of_component_match_add(dev, &match, compare_of, remote); ... return component_master_add_with_match(dev, &kirin_drm_ops, match); } Are you meaning that I should get rid of this component API and call kirin_drm_bind() from kirin_drm_platform_probe()? Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F945C433DF for ; Thu, 20 Aug 2020 14:07:07 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55E7820758 for ; Thu, 20 Aug 2020 14:07:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nybwFHcJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55E7820758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 0AA9E2261A; Thu, 20 Aug 2020 14:07:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Px8nl1Y-Q4fV; Thu, 20 Aug 2020 14:07:01 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id BE8B322253; Thu, 20 Aug 2020 14:07:01 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 89AEF1BF59F for ; Thu, 20 Aug 2020 14:07:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 827B287D15 for ; Thu, 20 Aug 2020 14:07:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U+k6z2d5aqMY for ; Thu, 20 Aug 2020 14:06:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id EBF1287CF9 for ; Thu, 20 Aug 2020 14:06:59 +0000 (UTC) Received: from coco.lan (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D50F20724; Thu, 20 Aug 2020 14:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597932419; bh=uRIasufyJG6jvkmnVHV59NybArRtiZJedVOR4Y+iZ8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nybwFHcJSEQ+sNorK6h28lhlgOTpiFXwa/QO/tmNCoOemIM/jbAkdHKBh4+JqzM63 fIu2sWwL2L3+Fvq0a/Cdzn/Zh3GQqR5WMMxz0DCY7Hfrzr6BZrIpZkKpN1EDCEaauY MvLAi+xqn9f0CHzZuUNAiOvgkUwF/4KSrktIOYUQ= Date: Thu, 20 Aug 2020 16:06:49 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200820160649.54741194@coco.lan> In-Reply-To: <20200819173558.GA3733@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liuyao An , netdev@vger.kernel.org, Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: I'm already handling the other comments from your review (I'll send a more complete comment about them after finishing), but I have a doubt what you meant about this: > +static int kirin_drm_bind(struct device *dev) > > +{ > > + struct drm_driver *driver = &kirin_drm_driver; > > + struct drm_device *drm_dev; > > + struct kirin_drm_private *priv; > > + int ret; > > + > > + drm_dev = drm_dev_alloc(driver, dev); > > + if (!drm_dev) > > + return -ENOMEM; > > + > > + ret = kirin_drm_kms_init(drm_dev); > > + if (ret) > > + goto err_drm_dev_unref; > > + > > + ret = drm_dev_register(drm_dev, 0); > There is better ways to do this. See drm_drv.c for the code example. Not sure if I understood your comment here. The drm_drv.c example also calls drm_dev_register(). The only difference is that it calls it inside driver_probe(), while on this driver, it uses: static const struct component_master_ops kirin_drm_ops = { .bind = kirin_drm_bind, .unbind = kirin_drm_unbind, }; static int kirin_drm_platform_probe(struct platform_device *pdev) { ... drm_of_component_match_add(dev, &match, compare_of, remote); ... return component_master_add_with_match(dev, &kirin_drm_ops, match); } Are you meaning that I should get rid of this component API and call kirin_drm_bind() from kirin_drm_platform_probe()? Thanks, Mauro _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AA4C433DF for ; Thu, 20 Aug 2020 14:08:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F31020724 for ; Thu, 20 Aug 2020 14:08:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jE5Gyc4K"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nybwFHcJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F31020724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KOVwv5vjckFdD99dW0kki7PBz1lVUe9ZnmCNI2um2yU=; b=jE5Gyc4KcUiFVvXwSA+0uWW+Y lReMiq1ebBAtDUru2lfHQo+DlrviWBbUQxp2rYHlRJsujrtussTfli7d34zIsxf/Lx13TgKx/q4/J f7BYyagbe7HONBc1NAu3lCKuiIpUj+Yh6zyPCodqCCBukBS6t/4c/d0OeUYMZYDdECBLpMvozJWp2 cD26Hyeb9sc7HtxpGvJYsP7VWe4cUpN1tZhBA6QJvgc8W9LlGgpTz68FMlhKZUmi/HU/qiLW7ZhTR y+YNn82/hnEnq3biierd406VDDZhB6FDOz1kYRUuq1igy9f/tJ8rP5QbQax9oCnSv5N42L6RMUKJa m564wBUqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8lDa-000262-8p; Thu, 20 Aug 2020 14:07:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8lDY-00025c-Jd for linux-arm-kernel@lists.infradead.org; Thu, 20 Aug 2020 14:07:01 +0000 Received: from coco.lan (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D50F20724; Thu, 20 Aug 2020 14:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597932419; bh=uRIasufyJG6jvkmnVHV59NybArRtiZJedVOR4Y+iZ8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nybwFHcJSEQ+sNorK6h28lhlgOTpiFXwa/QO/tmNCoOemIM/jbAkdHKBh4+JqzM63 fIu2sWwL2L3+Fvq0a/Cdzn/Zh3GQqR5WMMxz0DCY7Hfrzr6BZrIpZkKpN1EDCEaauY MvLAi+xqn9f0CHzZuUNAiOvgkUwF/4KSrktIOYUQ= Date: Thu, 20 Aug 2020 16:06:49 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200820160649.54741194@coco.lan> In-Reply-To: <20200819173558.GA3733@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200820_100700_794574_270F2C03 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liuyao An , netdev@vger.kernel.org, Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: I'm already handling the other comments from your review (I'll send a more complete comment about them after finishing), but I have a doubt what you meant about this: > +static int kirin_drm_bind(struct device *dev) > > +{ > > + struct drm_driver *driver = &kirin_drm_driver; > > + struct drm_device *drm_dev; > > + struct kirin_drm_private *priv; > > + int ret; > > + > > + drm_dev = drm_dev_alloc(driver, dev); > > + if (!drm_dev) > > + return -ENOMEM; > > + > > + ret = kirin_drm_kms_init(drm_dev); > > + if (ret) > > + goto err_drm_dev_unref; > > + > > + ret = drm_dev_register(drm_dev, 0); > There is better ways to do this. See drm_drv.c for the code example. Not sure if I understood your comment here. The drm_drv.c example also calls drm_dev_register(). The only difference is that it calls it inside driver_probe(), while on this driver, it uses: static const struct component_master_ops kirin_drm_ops = { .bind = kirin_drm_bind, .unbind = kirin_drm_unbind, }; static int kirin_drm_platform_probe(struct platform_device *pdev) { ... drm_of_component_match_add(dev, &match, compare_of, remote); ... return component_master_add_with_match(dev, &kirin_drm_ops, match); } Are you meaning that I should get rid of this component API and call kirin_drm_bind() from kirin_drm_platform_probe()? Thanks, Mauro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CE0C433DF for ; Thu, 20 Aug 2020 14:07:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A181D20758 for ; Thu, 20 Aug 2020 14:07:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nybwFHcJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A181D20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECDAD6E0EC; Thu, 20 Aug 2020 14:07:00 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD0876E0EC for ; Thu, 20 Aug 2020 14:06:59 +0000 (UTC) Received: from coco.lan (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D50F20724; Thu, 20 Aug 2020 14:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597932419; bh=uRIasufyJG6jvkmnVHV59NybArRtiZJedVOR4Y+iZ8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nybwFHcJSEQ+sNorK6h28lhlgOTpiFXwa/QO/tmNCoOemIM/jbAkdHKBh4+JqzM63 fIu2sWwL2L3+Fvq0a/Cdzn/Zh3GQqR5WMMxz0DCY7Hfrzr6BZrIpZkKpN1EDCEaauY MvLAi+xqn9f0CHzZuUNAiOvgkUwF/4KSrktIOYUQ= Date: Thu, 20 Aug 2020 16:06:49 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200820160649.54741194@coco.lan> In-Reply-To: <20200819173558.GA3733@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liuyao An , netdev@vger.kernel.org, Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Em Wed, 19 Aug 2020 19:35:58 +0200 Sam Ravnborg escreveu: I'm already handling the other comments from your review (I'll send a more complete comment about them after finishing), but I have a doubt what you meant about this: > +static int kirin_drm_bind(struct device *dev) > > +{ > > + struct drm_driver *driver = &kirin_drm_driver; > > + struct drm_device *drm_dev; > > + struct kirin_drm_private *priv; > > + int ret; > > + > > + drm_dev = drm_dev_alloc(driver, dev); > > + if (!drm_dev) > > + return -ENOMEM; > > + > > + ret = kirin_drm_kms_init(drm_dev); > > + if (ret) > > + goto err_drm_dev_unref; > > + > > + ret = drm_dev_register(drm_dev, 0); > There is better ways to do this. See drm_drv.c for the code example. Not sure if I understood your comment here. The drm_drv.c example also calls drm_dev_register(). The only difference is that it calls it inside driver_probe(), while on this driver, it uses: static const struct component_master_ops kirin_drm_ops = { .bind = kirin_drm_bind, .unbind = kirin_drm_unbind, }; static int kirin_drm_platform_probe(struct platform_device *pdev) { ... drm_of_component_match_add(dev, &match, compare_of, remote); ... return component_master_add_with_match(dev, &kirin_drm_ops, match); } Are you meaning that I should get rid of this component API and call kirin_drm_bind() from kirin_drm_platform_probe()? Thanks, Mauro _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel