All of lore.kernel.org
 help / color / mirror / Atom feed
From: Louise Kilheeney <louise.kilheeney@intel.com>
To: dev@dpdk.org
Cc: robin.jarry@6wind.com, anatoly.burakov@intel.com,
	bruce.richardson@intel.com,
	Louise Kilheeney <louise.kilheeney@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>
Subject: [dpdk-dev] [PATCH v5 5/9] app/test-cmdline: support python3 only
Date: Fri, 21 Aug 2020 10:14:48 +0100	[thread overview]
Message-ID: <20200821091452.2482-6-louise.kilheeney@intel.com> (raw)
In-Reply-To: <20200821091452.2482-1-louise.kilheeney@intel.com>

Changed script to explicitly use python3 only to avoid
maintaining python 2 and removed deprecation notice.

Cc: Olivier Matz <olivier.matz@6wind.com>

Signed-off-by: Louise Kilheeney <louise.kilheeney@intel.com>

---
v5: fixed python3 issue casuing script to fail
---
 app/test-cmdline/cmdline_test.py      | 9 ++-------
 app/test-cmdline/cmdline_test_data.py | 1 +
 mk/rte.sdktest.mk                     | 2 +-
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/app/test-cmdline/cmdline_test.py b/app/test-cmdline/cmdline_test.py
index 954428e2bf..074fed7e7f 100755
--- a/app/test-cmdline/cmdline_test.py
+++ b/app/test-cmdline/cmdline_test.py
@@ -1,9 +1,8 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
 # Script that runs cmdline_test app and feeds keystrokes into it.
-from __future__ import print_function
 import cmdline_test_data
 import os
 import pexpect
@@ -19,10 +18,6 @@ def runTest(child, test):
         return 0
     child.expect(test["Result"], 1)
 
-if sys.version_info.major < 3:
-    print("WARNING: Python 2 is deprecated for use in DPDK, and will not work in future releases.", file=sys.stderr)
-    print("Please use Python 3 instead", file=sys.stderr)
-
 #
 # history test is a special case
 #
@@ -43,7 +38,7 @@ def runHistoryTest(child):
     i = 0
 
     # fill the history with numbers
-    while i < history_size / 10:
+    while i < int(history_size / 10):
         # add 1 to prevent from parsing as octals
         child.send("1" + str(i).zfill(8) + cmdline_test_data.ENTER)
         # the app will simply print out the number
diff --git a/app/test-cmdline/cmdline_test_data.py b/app/test-cmdline/cmdline_test_data.py
index 114d2cb6a0..2d9b3262a6 100644
--- a/app/test-cmdline/cmdline_test_data.py
+++ b/app/test-cmdline/cmdline_test_data.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2010-2014 Intel Corporation
 
diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
index 803018ba3a..ad7ef138f0 100644
--- a/mk/rte.sdktest.mk
+++ b/mk/rte.sdktest.mk
@@ -63,7 +63,7 @@ coverage:
 	@mkdir -p $(AUTOTEST_DIR) ; \
 	cd $(AUTOTEST_DIR) ; \
 	if [ -f $(RTE_OUTPUT)/app/test ]; then \
-		python $(RTE_SDK)/test/cmdline_test/cmdline_test.py \
+		python3 $(RTE_SDK)/test/cmdline_test/cmdline_test.py \
 			$(RTE_OUTPUT)/app/cmdline_test; \
 		ulimit -S -n 100 ; \
 		python $(RTE_SDK)/app/test/autotest.py \
-- 
2.17.1


  parent reply	other threads:[~2020-08-21  9:15 UTC|newest]

Thread overview: 175+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 13:23 [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 1/9] app/test-bbdev: support python3 only Louise Kilheeney
2020-05-26 18:58   ` Chautru, Nicolas
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-05-28 12:39   ` Burakov, Anatoly
2020-05-28 12:41     ` Burakov, Anatoly
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 3/9] usertools/dpdk-telemetry-client: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 4/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 5/9] usertools/cpu_layout: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 6/9] app/test-cmdline: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 7/9] app/test: " Louise Kilheeney
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 8/9] devtools: " Louise Kilheeney
2020-05-27  6:15   ` Ray Kinsella
2020-05-22 13:23 ` [dpdk-dev] [PATCH 20.08 9/9] config/arm: " Louise Kilheeney
2020-05-22 13:46   ` Thomas Monjalon
2020-05-22 14:10     ` Kilheeney, Louise
2020-05-23 21:27       ` Thomas Monjalon
2020-05-25  9:53         ` Bruce Richardson
2020-06-25  9:34           ` Harman Kalra
2020-05-25  7:27 ` [dpdk-dev] [PATCH 20.08 0/9] adding support for python 3 only Robin Jarry
2020-05-25  9:51   ` Bruce Richardson
2020-05-25 10:29     ` Robin Jarry
2020-05-25 10:56   ` Kilheeney, Louise
2020-05-25 11:06     ` Robin Jarry
2020-06-17 15:10 ` [dpdk-dev] [PATCH v2 " Louise Kilheeney
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 1/9] app/test-bbdev: support python3 only Louise Kilheeney
2020-06-25 12:46     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-06-25 12:48     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 3/9] usertools/dpdk-telemetry-client: " Louise Kilheeney
2020-06-25 12:49     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 4/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-06-17 17:19     ` Neil Horman
2020-07-02 11:23     ` Neil Horman
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 5/9] usertools/cpu_layout: " Louise Kilheeney
2020-06-25 12:49     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 6/9] app/test-cmdline: " Louise Kilheeney
2020-06-26  9:28     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 7/9] app/test: " Louise Kilheeney
2020-06-26  9:30     ` Burakov, Anatoly
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 8/9] devtools: " Louise Kilheeney
2020-06-17 15:10   ` [dpdk-dev] [PATCH v2 9/9] config/arm: " Louise Kilheeney
2020-06-26  9:31     ` Burakov, Anatoly
2020-07-02 10:37 ` [dpdk-dev] [PATCH v3 0/9] dding support for python 3 only Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 1/9] app/test-bbdev: support python3 only Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 3/9] usertools/dpdk-telemetry-client: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 4/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 5/9] usertools/cpu_layout: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 6/9] app/test-cmdline: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 7/9] app/test: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 8/9] devtools: " Louise Kilheeney
2020-07-02 10:37   ` [dpdk-dev] [PATCH v3 9/9] config/arm: " Louise Kilheeney
2020-07-08  8:59   ` [dpdk-dev] [PATCH v3 0/9] dding support for python 3 only David Marchand
2020-07-08 10:13     ` Kilheeney, Louise
2020-08-04 14:07 ` [dpdk-dev] [PATCH v4 0/9] adding " Louise Kilheeney
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 1/9] usertools/dpdk-telemetry-client: support python3 only Louise Kilheeney
2020-08-05  9:10     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-08-12 14:27     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 3/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-08-12 14:44     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 4/9] usertools/cpu_layout: " Louise Kilheeney
2020-08-12 14:49     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 5/9] app/test-cmdline: " Louise Kilheeney
2020-08-12 15:05     ` Bruce Richardson
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 6/9] app/test: " Louise Kilheeney
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 7/9] devtools: " Louise Kilheeney
2020-08-05  8:44     ` Kinsella, Ray
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 8/9] config/arm: " Louise Kilheeney
2020-08-04 14:07   ` [dpdk-dev] [PATCH v4 9/9] app/test-bbdev: " Louise Kilheeney
2020-08-21  9:14 ` [dpdk-dev] [PATCH v5 0/9]adding support for python 3 only Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 1/9] usertools/dpdk-telemetry-client: support python3 only Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 2/9] usertools/dpdk-devbind: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 3/9] usertools/dpdk-pmdinfo: " Louise Kilheeney
2020-08-21 12:42     ` Neil Horman
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 4/9] usertools/cpu_layout: " Louise Kilheeney
2020-08-21  9:14   ` Louise Kilheeney [this message]
2020-08-21  9:24     ` [dpdk-dev] [PATCH v5 5/9] app/test-cmdline: " Bruce Richardson
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 6/9] app/test: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 7/9] devtools: " Louise Kilheeney
2020-08-21 12:42     ` Neil Horman
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 8/9] config/arm: " Louise Kilheeney
2020-08-21  9:14   ` [dpdk-dev] [PATCH v5 9/9] app/test-bbdev: " Louise Kilheeney
2020-09-15 14:11   ` [dpdk-dev] [PATCH v5 0/9]adding support for python 3 only David Marchand
2020-09-21 11:46   ` [dpdk-dev] [PATCH v6 00/10] adding " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 01/10] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 02/10] usertools/dpdk-devbind: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 03/10] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 04/10] usertools/cpu_layout: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 05/10] app/test-cmdline: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 06/10] app/test: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 07/10] devtools: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 08/10] config/arm: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 09/10] app/test-bbdev: " Kevin Laatz
2020-09-21 11:46     ` [dpdk-dev] [PATCH v6 10/10] buildtools: " Kevin Laatz
2020-09-21 12:03     ` [dpdk-dev] [PATCH v7 00/10] adding support for python 3 only Kevin Laatz
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 01/10] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-25 14:32         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 02/10] usertools/dpdk-devbind: " Kevin Laatz
2020-09-25 14:49         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 03/10] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-25 14:50         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 04/10] usertools/cpu_layout: " Kevin Laatz
2020-09-25 14:51         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 05/10] app/test-cmdline: " Kevin Laatz
2020-09-25 14:52         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 06/10] app/test: " Kevin Laatz
2020-09-25 14:54         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 07/10] devtools: " Kevin Laatz
2020-09-25 14:55         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 08/10] config/arm: " Kevin Laatz
2020-09-25 14:55         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 09/10] app/test-bbdev: " Kevin Laatz
2020-09-25 14:56         ` Robin Jarry
2020-09-21 12:03       ` [dpdk-dev] [PATCH v7 10/10] buildtools: " Kevin Laatz
2020-09-25 14:56         ` Robin Jarry
2020-09-28 10:43       ` [dpdk-dev] [PATCH v8 00/10] adding support for python 3 only Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 01/10] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-28 11:24           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 02/10] usertools/dpdk-devbind: " Kevin Laatz
2020-09-28 11:25           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 03/10] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-28 11:25           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 04/10] usertools/cpu_layout: " Kevin Laatz
2020-09-28 11:26           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 05/10] app/test-cmdline: " Kevin Laatz
2020-09-28 11:27           ` Robin Jarry
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 06/10] app/test: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 07/10] devtools: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 08/10] config/arm: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 09/10] app/test-bbdev: " Kevin Laatz
2020-09-28 10:43         ` [dpdk-dev] [PATCH v8 10/10] buildtools: " Kevin Laatz
2020-09-28 11:23           ` Robin Jarry
2020-09-28 11:29         ` [dpdk-dev] [PATCH v8 00/10] adding support for python 3 only Robin Jarry
2020-09-28 15:09           ` Bruce Richardson
2020-09-28 15:09         ` David Marchand
2020-09-28 15:14           ` Bruce Richardson
2020-09-28 15:36             ` Kevin Laatz
2020-09-29 10:22         ` [dpdk-dev] [PATCH v9 00/11] " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 01/11] usertools/dpdk-telemetry-client: support python3 only Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 02/11] usertools/dpdk-devbind: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 03/11] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 04/11] usertools/cpu_layout: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 05/11] app/test-cmdline: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 06/11] app/test: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 07/11] devtools: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 08/11] config/arm: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 09/11] app/test-bbdev: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 10/11] buildtools: " Kevin Laatz
2020-09-29 10:22           ` [dpdk-dev] [PATCH v9 11/11] doc: " Kevin Laatz
2020-09-30  8:18             ` Kinsella, Ray
2020-09-29 12:22           ` [dpdk-dev] [PATCH v9 00/11] adding support for python 3 only David Marchand
2020-09-29 15:25             ` Kevin Laatz
2020-09-29 15:48               ` Bruce Richardson
2020-09-29 15:54                 ` Robin Jarry
2020-09-29 16:33                   ` Bruce Richardson
2020-09-29 14:40           ` Stephen Hemminger
2020-09-30 11:40           ` [dpdk-dev] [PATCH v10 " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 01/11] usertools/dpdk-telemetry: support python3 only Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 02/11] usertools/dpdk-devbind: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 03/11] usertools/dpdk-pmdinfo: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 04/11] usertools/cpu_layout: " Kevin Laatz
2020-10-02  9:51               ` David Marchand
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 05/11] app/test-cmdline: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 06/11] app/test: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 07/11] devtools: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 08/11] config/arm: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 09/11] app/test-bbdev: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 10/11] buildtools: " Kevin Laatz
2020-09-30 11:40             ` [dpdk-dev] [PATCH v10 11/11] doc: " Kevin Laatz
2020-10-02 11:01               ` David Marchand
2020-10-02 11:07                 ` Kevin Laatz
2020-10-02 11:18                 ` Bruce Richardson
2020-10-02 12:54             ` [dpdk-dev] [PATCH v10 00/11] adding support for python 3 only David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200821091452.2482-6-louise.kilheeney@intel.com \
    --to=louise.kilheeney@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    --cc=robin.jarry@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.