From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE3CC433E1 for ; Fri, 21 Aug 2020 15:55:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B13EE20855 for ; Fri, 21 Aug 2020 15:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbgHUPzZ (ORCPT ); Fri, 21 Aug 2020 11:55:25 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:39000 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbgHUPzS (ORCPT ); Fri, 21 Aug 2020 11:55:18 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8848480516; Fri, 21 Aug 2020 17:55:06 +0200 (CEST) Date: Fri, 21 Aug 2020 17:55:05 +0200 From: Sam Ravnborg To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , Jakub Kicinski , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Liuyao An , Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200821155505.GA300361@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> <20200821155801.0b820fc6@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821155801.0b820fc6@coco.lan> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=D19gQVrFAAAA:8 a=edBkpzIAjiy-cUzT3AwA:9 a=CjuIK1q_8ugA:10 a=W4TVW4IDbPiebHqcZpNg:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro. Thanks for the detailed feedabck. Two comments in the following. Sam > > > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > > > + if (!ctx->dss_pri_clk) { > > > + DRM_ERROR("failed to parse dss_pri_clk\n"); > > > + return -ENODEV; > > > + } > ... > > > I had expected some of these could fail with a PROBE_DEFER. > > Consider to use the newly introduced dev_probe_err() > > Yeah, getting clock lines can fail. I was unable to find dev_probe_err(), > at least on Kernel 5.9-rc1. I saw this comment: > > https://lkml.org/lkml/2020/3/6/356 > > It sounds it didn't reach upstream. Anyway, I add error handling for the > the clk_get calls: > > ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > ret = PTR_ERR_OR_ZERO(ctx->dss_pri_clk); > if (ret == -EPROBE_DEFER) { > return ret; > } else if (ret) { > DRM_ERROR("failed to parse dss_pri_clk: %d\n", ret); > return ret; > } > > This should be able to detect deferred probe, plus to warn > about other errors. I got the name wrong. It is named dev_err_probe(), and was introduced in -rc1. > > Can the panel stuff be moved out and utilise drm_panel? > > I saw the code at drm_panel. The real issue here is that I can't > test anything related to panel support, as I lack any hardware > for testing. So, there's a high chance I may end breaking > something while trying to do that. I will try to take a look again when you post next revision. Maybe we should update it and risk that is not works, so whenever someone try to fix it they do so on top of an up-to-date implmentation. Lets se and decide later. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 444D9C433DF for ; Fri, 21 Aug 2020 15:55:24 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 228D6207DE for ; Fri, 21 Aug 2020 15:55:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 228D6207DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B9AC788055; Fri, 21 Aug 2020 15:55:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9rK9T9HBg9zZ; Fri, 21 Aug 2020 15:55:23 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 07CE287F7F; Fri, 21 Aug 2020 15:55:23 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1651E1BF9BD for ; Fri, 21 Aug 2020 15:55:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0DC7187F7F for ; Fri, 21 Aug 2020 15:55:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EYOo4Rko37hY for ; Fri, 21 Aug 2020 15:55:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by whitealder.osuosl.org (Postfix) with ESMTPS id CE31F87F4A for ; Fri, 21 Aug 2020 15:55:17 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8848480516; Fri, 21 Aug 2020 17:55:06 +0200 (CEST) Date: Fri, 21 Aug 2020 17:55:05 +0200 From: Sam Ravnborg To: Mauro Carvalho Chehab Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200821155505.GA300361@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> <20200821155801.0b820fc6@coco.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821155801.0b820fc6@coco.lan> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=D19gQVrFAAAA:8 a=edBkpzIAjiy-cUzT3AwA:9 a=CjuIK1q_8ugA:10 a=W4TVW4IDbPiebHqcZpNg:22 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liuyao An , netdev@vger.kernel.org, Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Mauro. Thanks for the detailed feedabck. Two comments in the following. Sam > > > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > > > + if (!ctx->dss_pri_clk) { > > > + DRM_ERROR("failed to parse dss_pri_clk\n"); > > > + return -ENODEV; > > > + } > ... > > > I had expected some of these could fail with a PROBE_DEFER. > > Consider to use the newly introduced dev_probe_err() > > Yeah, getting clock lines can fail. I was unable to find dev_probe_err(), > at least on Kernel 5.9-rc1. I saw this comment: > > https://lkml.org/lkml/2020/3/6/356 > > It sounds it didn't reach upstream. Anyway, I add error handling for the > the clk_get calls: > > ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > ret = PTR_ERR_OR_ZERO(ctx->dss_pri_clk); > if (ret == -EPROBE_DEFER) { > return ret; > } else if (ret) { > DRM_ERROR("failed to parse dss_pri_clk: %d\n", ret); > return ret; > } > > This should be able to detect deferred probe, plus to warn > about other errors. I got the name wrong. It is named dev_err_probe(), and was introduced in -rc1. > > Can the panel stuff be moved out and utilise drm_panel? > > I saw the code at drm_panel. The real issue here is that I can't > test anything related to panel support, as I lack any hardware > for testing. So, there's a high chance I may end breaking > something while trying to do that. I will try to take a look again when you post next revision. Maybe we should update it and risk that is not works, so whenever someone try to fix it they do so on top of an up-to-date implmentation. Lets se and decide later. Sam _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A142FC433E1 for ; Fri, 21 Aug 2020 15:56:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 707A120855 for ; Fri, 21 Aug 2020 15:56:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="veIH9t0V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 707A120855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KSEK1uUgJxLvTfp8iT2euMlXhvs73RoPgW8IZLJsfHQ=; b=veIH9t0V0SrmQCMqcwAbb2wAD OYWfYHXc9B7Iow7nb1xUq5J/tsHp++Rv7xN6kj+IswunvW6H8+8GIpoqeMJsd1JIzplLllVFJr59W 5N9VkCZHoHEDQT+Cixj1g8Dn5VA3sAHVf6XHoz/5wuHnGEc0BNXsOMRZ4G6ha/sRxddhdBM/1vApm R3ER3GdSSlCb24saqRRAJKDOLFWYbjloC+iO/1vVN58usEix8+n+BGy39r5RtZRgJEeR0Ak4/dTTr tfWjKX8/tzRCx3fdZgR+QGAXEHuVel4spGTLzLD1mw2HXwtwqroCdO1VbGKcXEedTP1YdZmoXNRmt 1mxwj6A0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k99O2-0006ak-Ox; Fri, 21 Aug 2020 15:55:26 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k99Nz-0006Y2-M0 for linux-arm-kernel@lists.infradead.org; Fri, 21 Aug 2020 15:55:25 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8848480516; Fri, 21 Aug 2020 17:55:06 +0200 (CEST) Date: Fri, 21 Aug 2020 17:55:05 +0200 From: Sam Ravnborg To: Mauro Carvalho Chehab Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200821155505.GA300361@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> <20200821155801.0b820fc6@coco.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821155801.0b820fc6@coco.lan> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=D19gQVrFAAAA:8 a=edBkpzIAjiy-cUzT3AwA:9 a=CjuIK1q_8ugA:10 a=W4TVW4IDbPiebHqcZpNg:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200821_115523_980849_F231C0C7 X-CRM114-Status: GOOD ( 25.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liuyao An , netdev@vger.kernel.org, Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mauro. Thanks for the detailed feedabck. Two comments in the following. Sam > > > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > > > + if (!ctx->dss_pri_clk) { > > > + DRM_ERROR("failed to parse dss_pri_clk\n"); > > > + return -ENODEV; > > > + } > ... > > > I had expected some of these could fail with a PROBE_DEFER. > > Consider to use the newly introduced dev_probe_err() > > Yeah, getting clock lines can fail. I was unable to find dev_probe_err(), > at least on Kernel 5.9-rc1. I saw this comment: > > https://lkml.org/lkml/2020/3/6/356 > > It sounds it didn't reach upstream. Anyway, I add error handling for the > the clk_get calls: > > ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > ret = PTR_ERR_OR_ZERO(ctx->dss_pri_clk); > if (ret == -EPROBE_DEFER) { > return ret; > } else if (ret) { > DRM_ERROR("failed to parse dss_pri_clk: %d\n", ret); > return ret; > } > > This should be able to detect deferred probe, plus to warn > about other errors. I got the name wrong. It is named dev_err_probe(), and was introduced in -rc1. > > Can the panel stuff be moved out and utilise drm_panel? > > I saw the code at drm_panel. The real issue here is that I can't > test anything related to panel support, as I lack any hardware > for testing. So, there's a high chance I may end breaking > something while trying to do that. I will try to take a look again when you post next revision. Maybe we should update it and risk that is not works, so whenever someone try to fix it they do so on top of an up-to-date implmentation. Lets se and decide later. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C558C433E1 for ; Fri, 21 Aug 2020 15:55:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED13D207BB for ; Fri, 21 Aug 2020 15:55:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED13D207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28C69892B6; Fri, 21 Aug 2020 15:55:19 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32B36892B6 for ; Fri, 21 Aug 2020 15:55:18 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 8848480516; Fri, 21 Aug 2020 17:55:06 +0200 (CEST) Date: Fri, 21 Aug 2020 17:55:05 +0200 From: Sam Ravnborg To: Mauro Carvalho Chehab Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200821155505.GA300361@ravnborg.org> References: <20200819152120.GA106437@ravnborg.org> <20200819174027.70b39ee9@coco.lan> <20200819173558.GA3733@ravnborg.org> <20200821155801.0b820fc6@coco.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821155801.0b820fc6@coco.lan> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=D19gQVrFAAAA:8 a=edBkpzIAjiy-cUzT3AwA:9 a=CjuIK1q_8ugA:10 a=W4TVW4IDbPiebHqcZpNg:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Xinliang Liu , Wanchun Zheng , linuxarm@huawei.com, dri-devel , Andrzej Hajda , Laurent Pinchart , devel@driverdev.osuosl.org, Daniel Borkmann , John Fastabend , Xiubin Zhang , Wei Xu , David Airlie , Xinwei Kong , Tomi Valkeinen , Bogdan Togorean , Jakub Kicinski , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Liwei Cai , Jesper Dangaard Brouer , Manivannan Sadhasivam , Chen Feng , Alexei Starovoitov , linaro-mm-sig@lists.linaro.org, Rob Herring , mauro.chehab@huawei.com, Rob Clark , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liuyao An , netdev@vger.kernel.org, Rongrong Zou , bpf@vger.kernel.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Mauro. Thanks for the detailed feedabck. Two comments in the following. Sam > > > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > > > + if (!ctx->dss_pri_clk) { > > > + DRM_ERROR("failed to parse dss_pri_clk\n"); > > > + return -ENODEV; > > > + } > ... > > > I had expected some of these could fail with a PROBE_DEFER. > > Consider to use the newly introduced dev_probe_err() > > Yeah, getting clock lines can fail. I was unable to find dev_probe_err(), > at least on Kernel 5.9-rc1. I saw this comment: > > https://lkml.org/lkml/2020/3/6/356 > > It sounds it didn't reach upstream. Anyway, I add error handling for the > the clk_get calls: > > ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > ret = PTR_ERR_OR_ZERO(ctx->dss_pri_clk); > if (ret == -EPROBE_DEFER) { > return ret; > } else if (ret) { > DRM_ERROR("failed to parse dss_pri_clk: %d\n", ret); > return ret; > } > > This should be able to detect deferred probe, plus to warn > about other errors. I got the name wrong. It is named dev_err_probe(), and was introduced in -rc1. > > Can the panel stuff be moved out and utilise drm_panel? > > I saw the code at drm_panel. The real issue here is that I can't > test anything related to panel support, as I lack any hardware > for testing. So, there's a high chance I may end breaking > something while trying to do that. I will try to take a look again when you post next revision. Maybe we should update it and risk that is not works, so whenever someone try to fix it they do so on top of an up-to-date implmentation. Lets se and decide later. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel