From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E02C433DF for ; Fri, 21 Aug 2020 18:15:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 925912076E for ; Fri, 21 Aug 2020 18:15:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OME1+3Je" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 925912076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9BZA-0007UQ-Qe for qemu-devel@archiver.kernel.org; Fri, 21 Aug 2020 14:15:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9BXx-0006Ak-GL for qemu-devel@nongnu.org; Fri, 21 Aug 2020 14:13:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33883) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k9BXv-0007K6-Bn for qemu-devel@nongnu.org; Fri, 21 Aug 2020 14:13:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598033626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WVRyCH/0B2Beqz10QLwON7xNDrSJ4bQ0T9yZbTyIBPY=; b=OME1+3Je6urjXbrDjtom0nKbloVx4yBkR47lCD+zxl/Jbxwsn9WI+Ouo0+tUAdzidQ2smt x5XkHl5r4gr3ISHK9wX/J/E5f6sezu/ynPqAMnK8W96e3ZkesUtc4LdKv4pTxpAKhmkcSZ hcvFVW2ggGTElg8lWGOeN7X81b2GzFc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-_gFWXcMqObeVGba3harvVg-1; Fri, 21 Aug 2020 14:13:42 -0400 X-MC-Unique: _gFWXcMqObeVGba3harvVg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 237521009462; Fri, 21 Aug 2020 18:13:39 +0000 (UTC) Received: from localhost (unknown [10.10.67.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 04A687E331; Fri, 21 Aug 2020 18:13:23 +0000 (UTC) Date: Fri, 21 Aug 2020 14:13:22 -0400 From: Eduardo Habkost To: David Gibson Subject: Re: Suspicious QOM types without instance/class size Message-ID: <20200821181322.GL642093@habkost.net> References: <20200820215529.GH642093@habkost.net> <20200821014732.GW271315@yekko.fritz.box> MIME-Version: 1.0 In-Reply-To: <20200821014732.GW271315@yekko.fritz.box> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/21 04:26:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-devel@nongnu.org, Gerd Hoffmann , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Christian Borntraeger , =?iso-8859-1?Q?Herv=E9?= Poussineau , Thomas Huth , Alistair Francis , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater , Richard Henderson , "Daniel P. Berrange" , Cornelia Huck , Roman Bolshakov , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 21, 2020 at 11:47:32AM +1000, David Gibson wrote: > On Thu, Aug 20, 2020 at 05:55:29PM -0400, Eduardo Habkost wrote: > > While trying to convert TypeInfo declarations to the new > > OBJECT_DECLARE* macros, I've stumbled on a few suspicious cases > > where instance_size or class_size is not set, despite having type > > checker macros that use a specific type. > > > > The ones with "WARNING" are abstract types (maybe not serious if > > subclasses set the appropriate sizes). The ones with "ERROR" > > don't seem to be abstract types. > > > Comment on the ones within my area: > > > > WARNING: hw/input/adb.c:310:1: class_size should be set to sizeof(ADBDeviceClass)? > > Yeah, that looks like a bug (though we'll get away with it because > it's abstract). Right, luckily we are not touching any ADBDeviceClass field inside adb_device_class_init(). > > > WARNING: hw/ppc/pnv_lpc.c:771:1: instance_size should be set to sizeof(PnvLpcController)? > > Ditto. Agreed. > > Should I make fixes for these, or will you? Please send the fixes, and I will apply them before running the TypeInfo conversion script. > > > ERROR: hw/ppc/spapr_drc.c:771:1: instance_size should be set to sizeof(SpaprDrc)? > > I'm confused by this one. I'm not exactly sure which definition is > tripping the error, and AFAICT they should all be correctly inheriting > instance_size from either TYPE_SPAPR_DR_CONNECTOR or > TYPE_SPAPR_DRC_PHSYICAL. If anything, it looks like > TYPE_SPAPR_DRC_PHB could drop it's explicit override of instance_size. The error is triggered because of this type checking macro at include/hw/ppc/spapr_drc.h: #define SPAPR_DRC_PCI(obj) OBJECT_CHECK(SpaprDrc, (obj), \ TYPE_SPAPR_DRC_PCI) The expectation is that whatever type you use in OBJECT_CHECK will be the one used for instance_size. The script also looks at the parent type, to reduce false positives, but this case was flagged because SPAPR_DRC_PCI uses SpaprDrc, but the parent type (SPAPR_DRC_PHYSICAL) uses SpaprDrcPhysical. Now, I don't understand why we have so many instance checker macros that use the same typedef (SpaprDrc). If the code needs a valid SpaprDrc pointer, it can just use SPAPR_DR_CONNECTOR(). -- Eduardo